On Mon, 14 Aug 2023 12:47:46 GMT, Dmitry Cherepanov
wrote:
> The PR suggests updating copyright headers in two files so that they are the
> same as in other files.
Looks good.
I'm very surprised our header validation process did not pick this up.
Thanks.
-
PR Review: https://gi
On Mon, 14 Aug 2023 21:21:30 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote:
> In FFM, native function would be called via `nep_invoker_blob`. If the
> function has two arguments, it would be following:
>
>
> Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10
> ---
On Sun, 13 Aug 2023 16:43:58 GMT, Christoph wrote:
>> Add new test case with sample modules that contains some
>> requires/exports/uses/provides.
>>
>> We are just unsure if and how we should add some last step of verificaiton
>> with the extracted and decompiled class.
>>
>> Follow up task f
On Mon, 14 Aug 2023 17:44:06 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1364:
>>
>>> 1362: * As the fields must appear in order, the block size
>>> indicates which
>>> 1363: * fields to expect:
>>> 1364: * 0
On Mon, 14 Aug 2023 21:16:27 GMT, Volker Simonis wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added an additional test with with 0 extra header followed by an extra
>> header with a data size
>
> test/jdk/jav
On Mon, 14 Aug 2023 21:08:54 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening select APK, ZIP or JAR files. Please see refer to
> the
On Mon, 14 Aug 2023 20:28:08 GMT, Lance Andersen wrote:
> > net/n3/nanoxml/CDATAReader.class bad extra-field entry:
> > EF block length (61373 bytes) exceeds remaining EF data (4 bytes)
> > test of bad.jar FAILED
> > zip error: Zip file invalid, could not spawn unzip, or wrong unzip
> > (origina
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening select APK, ZIP or JAR files. Please see refer to
> the
`Collections.rotate` method contains a bug. This method throws
IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
reproduce:
final int size = (1 << 30) + 1;
final List list = new ArrayList<>(size);
for (int i = 0; i < size; ++i)
list.add((byte) 0);
Collections.rota
On Mon, 14 Aug 2023 12:56:46 GMT, Nikita Sakharin wrote:
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening select APK, ZIP or JAR files. Please see refer to
> the
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Mon, 14 Aug 2023 18:49:25 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
On Mon, 14 Aug 2023 18:49:25 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
On Mon, 14 Aug 2023 18:41:26 GMT, Sergey Bylokhov wrote:
> > I am not understanding your point. There is a specific order for the Zip64
> > fields based on which fields have the Magic value. the spec does also not
> > suggest that an empty Zip64 extra field can be written to the CEN when
> > t
On Mon, 14 Aug 2023 18:22:27 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 3108:
>>
>>> 3106: break;
>>> 3107: }
>>> 3108: if (size == ZIP64_MINVAL) {
>>
>> Note that we always incr
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening select APK, ZIP or JAR files. Please see refer to
> the
On Mon, 14 Aug 2023 18:32:15 GMT, Lance Andersen wrote:
>I am not understanding your point. There is a specific order for the Zip64
>fields based on which fields have the Magic value. the spec does also not
>suggest that an empty Zip64 extra field can be written to the CEN when there
>is a Zip
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote:
> In FFM, native function would be called via `nep_invoker_blob`. If the
> function has two arguments, it would be following:
>
>
> Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10
> ---
On Mon, 14 Aug 2023 17:59:19 GMT, Sergey Bylokhov wrote:
> > It's unfortunate that there are tools and plugins in the eco system that
> > have these issues. I think you've got the right balance here, meaning
> > tolerating a zip64 extra block with a block size of 0 and rejecting
> > corrupted
On Mon, 14 Aug 2023 18:03:20 GMT, Sergey Bylokhov wrote:
>> Lance Andersen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> c
On Mon, 14 Aug 2023 17:33:30 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
On Mon, 14 Aug 2023 17:33:30 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
On Fri, 11 Aug 2023 22:33:08 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments (8/11/23)
>
> src/java.base/share/classes/java/text/DigitList.java line 521:
>
>> 519:
On Mon, 14 Aug 2023 17:16:36 GMT, Alan Bateman wrote:
> It's unfortunate that there are tools and plugins in the eco system that have
> these issues. I think you've got the right balance here, meaning tolerating a
> zip64 extra block with a block size of 0 and rejecting corrupted extra blocks
> Please review this PR which is a broad clean up of the DigitList class (used
> by Format classes in j.text).
>
> This PR is intended to be a portion of a bigger change (split up to make
> reviewing easier).
>
> The main change combines related Rounding Mode logic in `shouldRoundUp()` -
> (_
On Mon, 14 Aug 2023 13:27:05 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote:
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
> the is an IOException generation when the output stream was flushing the
> buffer.
>
> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
Thi
On Mon, 14 Aug 2023 17:15:21 GMT, Volker Simonis wrote:
>> Lance Andersen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Mon, 14 Aug 2023 14:52:00 GMT, Lance Andersen wrote:
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening
On Mon, 14 Aug 2023 17:33:30 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when open
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening select APK, ZIP or JAR files. Please see refer to
> the
On Mon, 14 Aug 2023 13:27:05 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657
On Mon, 14 Aug 2023 14:52:00 GMT, Lance Andersen wrote:
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening
This PR updates the extra field validation added as part of
[JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with issues
seen with 3rd party tools/libraries where a ZipException may be encountered
when opening select APK, ZIP or JAR files. Please see refer to the links
prov
On Mon, 14 Aug 2023 12:47:46 GMT, Dmitry Cherepanov
wrote:
> The PR suggests updating copyright headers in two files so that they are the
> same as in other files.
The updated license appears to match the expected license:
https://github.com/openjdk/jdk/blob/master/make/data/license-templates
On Sun, 13 Aug 2023 07:15:45 GMT, Alan Bateman wrote:
> AutoDelete is probably a bit overkill but okay.
Thanks! Any more takers?
-
PR Comment: https://git.openjdk.org/jdk/pull/15231#issuecomment-1677361679
On Wed, 9 Aug 2023 10:45:56 GMT, Christian Stein wrote:
> Please review this change to remove Unit-based tests in `java/lang/invoke`
> from `jdk`'s problem list. The underlying race condition in jtreg was fixed
> in release 7.3; which is now the default version used in JDK mainline
> developme
On Wed, 9 Aug 2023 12:52:35 GMT, Weibing Xiao wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
> the is an IOException generation when the output stream was flushing the
> buffer.
>
> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
Weibing Xiao has updated the pull request incrementally wi
The PR suggests updating copyright headers in two files so that they are the
same as in other files.
-
Commit messages:
- update copyright headers
Changes: https://git.openjdk.org/jdk/pull/15269/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15269&range=00
Issue: https:/
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
Currently there is a number of functionality that would be interesting to have
for shared lib load operations in the JDK C code.
Some examples :
Events::log_dll_message for hs-err files reporting
JFR event NativeLibraryLoad
There is the need to update the shared lib Cache on AIX ( see
LoadedLibra
47 matches
Mail list logo
