Re: RFR: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent

2023-08-18 Thread Vyom Tewari
On Fri, 18 Aug 2023 23:14:20 GMT, Brian Burkhalter wrote: > Revise some verbiage about the `RandomAccessFile(String,String)` constructor > so that the string name of a file is referred to as _pathname string_ for > consistency with `java.io.File`. Looks OK to me - Marked as

Re: RFR: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"

2023-08-18 Thread Martin Buchholz
On Fri, 18 Aug 2023 08:18:24 GMT, Viktor Klang wrote: >> The usual tiny improvements, with no guarantee that the intermittent test >> failure is actually fixed. > > test/jdk/java/util/concurrent/SynchronousQueue/Fairness.java line 70: > >> 68:

Re: RFR: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"

2023-08-18 Thread Martin Buchholz
On Fri, 18 Aug 2023 08:15:58 GMT, Viktor Klang wrote: >> The usual tiny improvements, with no guarantee that the intermittent test >> failure is actually fixed. > > test/jdk/java/util/concurrent/SynchronousQueue/Fairness.java line 41: > >> 39: throws Throwable >> 40: { >> 41:

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]

2023-08-18 Thread Weibing Xiao
On Fri, 18 Aug 2023 13:30:54 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v7]

2023-08-18 Thread Weibing Xiao
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created

Re: RFR: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent

2023-08-18 Thread Justin Lu
On Fri, 18 Aug 2023 23:14:20 GMT, Brian Burkhalter wrote: > Revise some verbiage about the `RandomAccessFile(String,String)` constructor > so that the string name of a file is referred to as _pathname string_ for > consistency with `java.io.File`. LGTM - Marked as reviewed by

RFR: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent

2023-08-18 Thread Brian Burkhalter
Revise some verbiage about the `RandomAccessFile(String,String)` constructor so that the string name of a file is referred to as _pathname string_ for consistency with `java.io.File`. - Commit messages: - 8219567: Name of first parameter of RandomAccessFile(String,String) is

Re: RFR: 8314236: Overflow in Collections.rotate [v2]

2023-08-18 Thread Nikita Sakharin
On Wed, 16 Aug 2023 21:38:09 GMT, Stuart Marks wrote: >> Thanks! Done > > @nikita-sakharin > > Thanks for finding this bug and offering to fix it! (And @shipilev thanks for > your assistance on this.) > > Putting the test into a separate JVM will work, but I don't think it's > necessary to

RFR: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear

2023-08-18 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607) which clarifies the behavior of patterns in regards to the max integer digits in j.text.DecimalFormat. The current specification (of `applyPattern`) states that patterns do not set the value of max integer digits.

Re: RFR: 8314236: Overflow in Collections.rotate [v2]

2023-08-18 Thread Nikita Sakharin
On Tue, 15 Aug 2023 09:54:48 GMT, Aleksey Shipilev wrote: >> Nikita Sakharin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8314236: change bug number and summary > > src/java.base/share/classes/java/util/Collections.java line 810: >

Re: RFR: 8041488: Locale-Dependent List Patterns [v8]

2023-08-18 Thread Roger Riggs
On Thu, 10 Aug 2023 17:31:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >>

Re: RFR: 8314544: Matrix multiple benchmark using Vector API

2023-08-18 Thread Paul Sandoz
On Fri, 18 Aug 2023 03:57:24 GMT, Martin Stypinski wrote: > Added a bunch of different implementations for Vector API Matrix > Multiplications: > > - Baseline > - Blocked (Cache Local) > - FMA > - Vector API Simple Implementation > - Vector API Blocked Implementation > > Commit was discussed

Re: RFR: 8041488: Locale-Dependent List Patterns [v8]

2023-08-18 Thread Roger Riggs
On Thu, 10 Aug 2023 17:31:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >>

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Iris Clark
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]

2023-08-18 Thread Aleksei Efimov
On Fri, 18 Aug 2023 13:30:54 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs

Re: [jdk21] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

2023-08-18 Thread Ben Taylor
On Fri, 18 Aug 2023 17:25:10 GMT, Ben Taylor wrote: > Backport is clean, all tests in test/jdk/java/util/zip pass. My mistake, will create the PR against 21u. - PR Comment: https://git.openjdk.org/jdk21/pull/173#issuecomment-1684255033

[jdk21] Withdrawn: 8313765: Invalid CEN header (invalid zip64 extra data field size)

2023-08-18 Thread Ben Taylor
On Fri, 18 Aug 2023 17:25:10 GMT, Ben Taylor wrote: > Backport is clean, all tests in test/jdk/java/util/zip pass. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk21/pull/173

Re: [jdk21] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

2023-08-18 Thread Sergey Bylokhov
On Fri, 18 Aug 2023 17:25:10 GMT, Ben Taylor wrote: > Backport is clean, all tests in test/jdk/java/util/zip pass. It is strange that there is a request for jdk21u but there is no PR for that repo. - PR Comment: https://git.openjdk.org/jdk21/pull/173#issuecomment-1684250803

Re: [jdk21] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

2023-08-18 Thread Alan Bateman
On Fri, 18 Aug 2023 17:25:10 GMT, Ben Taylor wrote: > Backport is clean, all tests in test/jdk/java/util/zip pass. JDK 21 is at RC, only P1 issues with approval. There is already a fix request for jdk21u. The 21.0.1 release is only a few weeks after JDK 21. - PR Comment:

[jdk21] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

2023-08-18 Thread Ben Taylor
Backport is clean, all tests in test/jdk/java/util/zip pass. - Commit messages: - Backport 13f6450e2e70df4df8bd882def837fbd5bef1524 Changes: https://git.openjdk.org/jdk21/pull/173/files Webrev: https://webrevs.openjdk.org/?repo=jdk21=173=00 Issue:

Integrated: 8310815: Clarify the name of the main class, services and provider classes in module descriptor

2023-08-18 Thread Mandy Chung
On Wed, 16 Aug 2023 18:42:00 GMT, Mandy Chung wrote: > Clarify the spec of `ModuleDescriptor::mainClass`, `ModuleDescriptor::uses`, > `ModuleDescriptor.Provides::service` and > `ModuleDescriptor.Provides::providers` to return a binary name. > > This PR also fixes JDK-8314449 to update the

RFR: 8314483: Optionally override copyright header in generated source

2023-08-18 Thread Erik Joelsson
In the JDK build we have various build tools that generate source code from data files. For most of these tools, the source files are based on template files, which already have copyright headers, but for some, the complete source file is generated by the tool, which is providing the copyright

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]

2023-08-18 Thread Weibing Xiao
On Fri, 18 Aug 2023 13:20:50 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]

2023-08-18 Thread Weibing Xiao
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]

2023-08-18 Thread Weibing Xiao
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-18 Thread Alan Bateman
On Fri, 18 Aug 2023 12:02:05 GMT, Matthias Baesken wrote: > I checked the usage of sun/nio/fs/UnixConstants.java and seems we would need > to make the class public and an additional export for this like > > ``` > exports sun.nio.fs to > +java.prefs, > jdk.net; > ``` > >

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-18 Thread Matthias Baesken
On Fri, 18 Aug 2023 12:14:35 GMT, Jaikiran Pai wrote: > Hello Matthias, I think adding some diagnostics in this class would be a good > thing. Like in the JBS issue that this PR links to, there's another JBS issue > https://bugs.openjdk.org/browse/JDK-8304938 where we run into intermittent >

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-18 Thread Jaikiran Pai
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote: > We run into some BackingStoreException: Couldn't get file lock. e.g. here : > > [JShell] Exception in thread "main" java.lang.IllegalStateException: > java.util.prefs.BackingStoreException: Couldn't get file lock. > [JShell] at >

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Erik Joelsson
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-18 Thread Matthias Baesken
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote: > We run into some BackingStoreException: Couldn't get file lock. e.g. here : > > [JShell] Exception in thread "main" java.lang.IllegalStateException: > java.util.prefs.BackingStoreException: Couldn't get file lock. > [JShell] at >

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread David Holmes
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Christian Stein
Please review the change to update to using jtreg 7.3,1. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. This change

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v12]

2023-08-18 Thread sid8606
On Fri, 18 Aug 2023 04:41:25 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with two additional > commits since the last revision: > > - Calculate the code size. > - Fix missing spcaces

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v12]

2023-08-18 Thread Martin Doerr
On Fri, 18 Aug 2023 04:41:25 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with two additional > commits since the last revision: > > - Calculate the code size. > - Fix missing spcaces

Re: RFR: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"

2023-08-18 Thread Viktor Klang
On Thu, 17 Aug 2023 22:35:39 GMT, Martin Buchholz wrote: > The usual tiny improvements, with no guarantee that the intermittent test > failure is actually fixed. test/jdk/java/util/concurrent/SynchronousQueue/Fairness.java line 41: > 39: throws Throwable > 40: { > 41: int

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-18 Thread Matthias Baesken
On Thu, 17 Aug 2023 19:50:56 GMT, Roger Riggs wrote: >> Hi Roger, sounds like a good idea to translate it to a more informative >> string. >> Do you have an utility function in mind that does this ? > > Not trivial in java, there are platform specific native functions to get the > string