Re: RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children [v2]

2023-08-29 Thread Matthias Baesken
On Tue, 29 Aug 2023 12:10:34 GMT, Matthias Baesken wrote: >> We have some failures in TreeTest.java where the expected number of child >> processes is differing from what we really get. It would be good to have >> more output to analyze these cases. > > Matthias Baesken has updated the pull req

Integrated: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children

2023-08-29 Thread Matthias Baesken
On Tue, 29 Aug 2023 07:51:59 GMT, Matthias Baesken wrote: > We have some failures in TreeTest.java where the expected number of child > processes is differing from what we really get. It would be good to have more > output to analyze these cases. This pull request has now been integrated. Cha

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v5]

2023-08-29 Thread Chen Liang
On Tue, 1 Aug 2023 20:21:11 GMT, Naoto Sato wrote: >> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 >> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored >> the in-house cache with WeakHashMap, and removed the Key class as it is no >> longer nee

Re: RFR: 8313718: make container at requires command configurable [v2]

2023-08-29 Thread Mikhailo Seledtsov
> Container ecosystem is growing. It would be beneficial to define custom > command to figure out whether a specific test host or environment allows for > container testing. This enhancement seeks to make the command used by jtreg > "requires" extension configurable, specifically > test/jtreg-e

Re: RFR: 8313718: make container at requires command configurable

2023-08-29 Thread Mikhailo Seledtsov
On Tue, 29 Aug 2023 22:01:22 GMT, Mikhailo Seledtsov wrote: > Container ecosystem is growing. It would be beneficial to define custom > command to figure out whether a specific test host or environment allows for > container testing. This enhancement seeks to make the command used by jtreg >

Re: RFR: 8313718: make container at requires command configurable

2023-08-29 Thread Mikhailo Seledtsov
On Wed, 30 Aug 2023 02:49:09 GMT, David Holmes wrote: >> Container ecosystem is growing. It would be beneficial to define custom >> command to figure out whether a specific test host or environment allows for >> container testing. This enhancement seeks to make the command used by jtreg >> "re

Re: RFR: 8313718: make container at requires command configurable

2023-08-29 Thread David Holmes
On Tue, 29 Aug 2023 22:01:22 GMT, Mikhailo Seledtsov wrote: > Container ecosystem is growing. It would be beneficial to define custom > command to figure out whether a specific test host or environment allows for > container testing. This enhancement seeks to make the command used by jtreg >

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Vladimir Kozlov
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Srinivas Vamsi Parasa
On Tue, 29 Aug 2023 20:44:32 GMT, Srinivas Vamsi Parasa wrote: > > > Hi, We already have correctness tests. See > > > test/jdk/java/util/Arrays/Sorting.java > > > The latest version you can find in PR > > > https://github.com/openjdk/jdk/pull/13568/files > > > > > > Does test/jdk/java/util/A

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Srinivas Vamsi Parasa
On Tue, 29 Aug 2023 20:36:04 GMT, Vladimir Kozlov wrote: > > Hi, We already have correctness tests. See > > test/jdk/java/util/Arrays/Sorting.java > > The latest version you can find in PR > > https://github.com/openjdk/jdk/pull/13568/files > > Does test/jdk/java/util/Arrays/Sorting.java trigg

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Vladimir Kozlov
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8314236: Overflow in Collections.rotate [v9]

2023-08-29 Thread Stuart Marks
On Tue, 29 Aug 2023 20:00:49 GMT, Nikita Sakharin wrote: >> `Collections.rotate` method contains a bug. This method throws >> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way >> to reproduce: >> >> final int size = (1 << 30) + 1; >> final List list = new ArrayList<>(s

RFR: 8313718: make container at requires command configurable

2023-08-29 Thread Mikhailo Seledtsov
Container ecosystem is growing. It would be beneficial to define custom command to figure out whether a specific test host or environment allows for container testing. This enhancement seeks to make the command used by jtreg "requires" extension configurable, specifically test/jtreg-ext/requires

Re: RFR: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear [v2]

2023-08-29 Thread Justin Lu
On Tue, 29 Aug 2023 18:02:51 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect review comments: Non sci notation first. Link to Scientific >> Notation section > > src/java.base/share/classes/jav

Re: RFR: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear [v2]

2023-08-29 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607) > which clarifies the behavior of patterns in regards to the max integer > digits in j.text.DecimalFormat. > > The current specification (of `applyPattern`) states that patterns do not set > the value of max integer

Re: CFV: New Core Libraries Group Member: Lance Andersen

2023-08-29 Thread Stuart Marks
Vote: yes On 8/25/23 8:23 AM, Roger Riggs wrote: I hereby nominate Lance Andersen to Membership in the Core Libraries Group Lance has been contributing to the OpenJDK at Oracle since 2007. He has been the JDBC spec lead since 2005 and an OpenJDK committer since day 1. He has extensive experie

Re: CFV: New Core Libraries Group Member: Daniel Fuchs

2023-08-29 Thread Stuart Marks
Vote: yes On 8/25/23 8:23 AM, Roger Riggs wrote: I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group Daniel has been contributing to the OpenJDK Core Libraries at Oracle since 2012. He is leading the networking team and has made nearly 400 contributions to OpenJDK since J

Re: CFV: New Core Libraries Group Member: Michael McMahon

2023-08-29 Thread Stuart Marks
Vote: yes On 8/25/23 8:24 AM, Roger Riggs wrote: I hereby nominate Michael McMahon to Membership in the Core Libraries Group Michael has been contributing to the OpenJDK Core Libraries since 2008, originally at Sun Microsystems, now Oracle. He has deep networking experience and has made more

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v8]

2023-08-29 Thread Mandy Chung
> 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some > frameworks > like logging may only interest in

Re: RFR: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions

2023-08-29 Thread Naoto Sato
On Tue, 29 Aug 2023 16:53:29 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148) > which is a conformance change to specify exceptions in java.text.ChoiceFormat. > > Makes `IllegalArgumentException` apparent for `applyPattern` and > `setChoices`

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Srinivas Vamsi Parasa
On Tue, 29 Aug 2023 20:36:04 GMT, Vladimir Kozlov wrote: > Hi, We already have correctness tests. See > test/jdk/java/util/Arrays/Sorting.java > > The latest version you can find in PR > https://github.com/openjdk/jdk/pull/13568/files Hello Vladimir (@iaroslavski), Thank you for providing th

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Vladimir Kozlov
On Tue, 29 Aug 2023 19:32:44 GMT, iaroslavski wrote: > Hi, We already have correctness tests. See > test/jdk/java/util/Arrays/Sorting.java > > The latest version you can find in PR > https://github.com/openjdk/jdk/pull/13568/files Does test/jdk/java/util/Arrays/Sorting.java trigger usage of t

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Sandhya Viswanathan
On Tue, 29 Aug 2023 19:28:17 GMT, Alan Bateman wrote: >> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clean up parameters passed to arrayPartition; update the check to load >> library > > The changes to DualPivo

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v29]

2023-08-29 Thread Vladimir Kozlov
On Tue, 29 Aug 2023 17:32:26 GMT, Srinivas Vamsi Parasa wrote: >>> The reason this PR is focused on Linux is because the AVX512 sort and >>> partitioning routines are based on Intel’s x86-simd-library >>> (https://github.com/intel/x86-simd-sort) which was originally developed >>> with GCC as

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

2023-08-29 Thread Naoto Sato
On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu wrote: > Please review this PR which refines the spec of `equals()` and `hashCode()` > in `java.text.Format` related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFormat`)

Re: RFR: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear [v2]

2023-08-29 Thread Justin Lu
> Please review this PR and [CSR > ](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for > BreakIterator instances when text has not been set. > > For example, calling `BreakIterator.getWordInstance().next();` has an > ambiguous result. > A boundary searching operation was

Re: RFR: 8314236: Overflow in Collections.rotate [v8]

2023-08-29 Thread Nikita Sakharin
On Tue, 29 Aug 2023 03:02:56 GMT, Stuart Marks wrote: >> Nikita Sakharin has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> fix overflow in Collections.rotate and write tests > > (The bot has already admonished yo

Re: RFR: 8314236: Overflow in Collections.rotate [v9]

2023-08-29 Thread Nikita Sakharin
> `Collections.rotate` method contains a bug. This method throws > IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to > reproduce: > > final int size = (1 << 30) + 1; > final List list = new ArrayList<>(size); > for (int i = 0; i < size; ++i) > list.add((byte) 0);

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread iaroslavski
On Tue, 29 Aug 2023 16:57:11 GMT, Srinivas Vamsi Parasa wrote: > > My testing passed. But I am not sure correctness of code is fully tested. > > For now we have only JMH benchmark for this new code. Do we have JDK test > > which can check correctness of this code? > > Hi Vladimir, will add th

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread iaroslavski
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Alan Bateman
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Chris Plummer
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Roger Riggs
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear

2023-08-29 Thread Naoto Sato
On Thu, 24 Aug 2023 21:39:39 GMT, Justin Lu wrote: > Please review this PR and [CSR > ](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for > BreakIterator instances when text has not been set. > > For example, calling `BreakIterator.getWordInstance().next();` has an > a

Re: RFR: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear

2023-08-29 Thread Justin Lu
On Tue, 29 Aug 2023 18:02:51 GMT, Naoto Sato wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607) >> which clarifies the behavior of patterns in regards to the max integer >> digits in j.text.DecimalFormat. >> >> The current specification (of `applyPattern`)

Re: RFR: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear

2023-08-29 Thread Naoto Sato
On Fri, 18 Aug 2023 21:28:34 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607) > which clarifies the behavior of patterns in regards to the max integer > digits in j.text.DecimalFormat. > > The current specification (of `applyPattern`) states

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v29]

2023-08-29 Thread Srinivas Vamsi Parasa
On Tue, 29 Aug 2023 16:02:57 GMT, Vladimir Kozlov wrote: >> If it's tied to GCC as well, then we should probably include that in the >> condition here unless it's also expected to work with Clang. >> (`TOOLCHAIN_TYPE` = `gcc`) > >> The reason this PR is focused on Linux is because the AVX512 so

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v3]

2023-08-29 Thread Alan Bateman
On Tue, 29 Aug 2023 12:35:19 GMT, Severin Gehwolf wrote: > @AlanBateman Gentle ping. On my list, it's a lot to get through and a number of aspects to this that I think will require refinement and discussion. - PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-1697864

Re: RFR: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions

2023-08-29 Thread Justin Lu
On Tue, 29 Aug 2023 16:53:29 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148) > which is a conformance change to specify exceptions in java.text.ChoiceFormat. > > Makes `IllegalArgumentException` apparent for `applyPattern` and > `setChoices`

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Alan Bateman
On Tue, 29 Aug 2023 16:59:22 GMT, Daniel Fuchs wrote: >> how about "s/filtering/excluding"? > > Yes - that's better. The example use filter so it might be better to have the text use the same word, up to you, I think "filtering out known implementation classes" works too. - PR Rev

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Srinivas Vamsi Parasa
On Tue, 29 Aug 2023 16:04:58 GMT, Vladimir Kozlov wrote: > My testing passed. But I am not sure correctness of code is fully tested. For > now we have only JMH benchmark for this new code. Do we have JDK test which > can check correctness of this code? Hi Vladimir, will add the JDK tests to ch

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Srinivas Vamsi Parasa
On Mon, 28 Aug 2023 23:35:56 GMT, Erik Joelsson wrote: >> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clean up parameters passed to arrayPartition; update the check to load >> library > > make/modules/java.base

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Daniel Fuchs
On Tue, 29 Aug 2023 16:39:56 GMT, Mandy Chung wrote: >> src/java.base/share/classes/java/lang/StackWalker.java line 73: >> >>> 71: * 1. To find the first caller filtering a known list of >>> implementation class: >>> 72: * {@snippet lang="java" : >>> 73: * StackWalker walker = >>> Stack

RFR: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions

2023-08-29 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148) which is a conformance change to specify exceptions in java.text.ChoiceFormat. Makes `IllegalArgumentException` apparent for `applyPattern` and `setChoices`, as well as for the associated constructors that call the meth

Re: RFR: JDK-8314611: Provide more explicative error message parsing Currencies [v4]

2023-08-29 Thread Justin Lu
> Please review this PR which updates some exceptions in j.util.Currency to > have an explicit error message (as opposed to nothing). > > The exceptions are thrown when the ISO 4217/3166 currency/country codes are > in an invalid form, or do not exist. Justin Lu has updated the pull request inc

Re: RFR: JDK-8314611: Provide more explicative error message parsing Currencies [v3]

2023-08-29 Thread Justin Lu
On Tue, 29 Aug 2023 16:40:07 GMT, Naoto Sato wrote: > I think the same wording changes are needed in the test, as it checks the > error messages word by word. You're totally right, just fixed. - PR Comment: https://git.openjdk.org/jdk/pull/15458#issuecomment-1697803949

Re: RFR: JDK-8314611: Provide more explicative error message parsing Currencies [v4]

2023-08-29 Thread Naoto Sato
On Tue, 29 Aug 2023 16:48:27 GMT, Justin Lu wrote: >> Please review this PR which updates some exceptions in j.util.Currency to >> have an explicit error message (as opposed to nothing). >> >> The exceptions are thrown when the ISO 4217/3166 currency/country codes are >> in an invalid form, or

Re: RFR: 8041488: Locale-Dependent List Patterns [v12]

2023-08-29 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Roger Riggs
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > I don't think this is the best change across so many files. > It gives a very ugly name to a common test fu

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Mandy Chung
On Tue, 29 Aug 2023 13:16:56 GMT, Daniel Fuchs wrote: >> Mandy Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revised the API change. Add Option::DROP_METHOD_INFO >> - Review feedback from Remi > > src/java.base/share/classes/

Re: RFR: JDK-8314611: Provide more explicative error message parsing Currencies [v3]

2023-08-29 Thread Naoto Sato
On Mon, 28 Aug 2023 22:45:40 GMT, Justin Lu wrote: >> Please review this PR which updates some exceptions in j.util.Currency to >> have an explicit error message (as opposed to nothing). >> >> The exceptions are thrown when the ISO 4217/3166 currency/country codes are >> in an invalid form, or

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Mandy Chung
On Tue, 29 Aug 2023 16:13:11 GMT, Alan Bateman wrote: >> Mandy Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revised the API change. Add Option::DROP_METHOD_INFO >> - Review feedback from Remi > > src/java.base/share/classes/

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Mandy Chung
On Tue, 29 Aug 2023 13:19:11 GMT, Daniel Fuchs wrote: >> Mandy Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revised the API change. Add Option::DROP_METHOD_INFO >> - Review feedback from Remi > > src/java.base/share/classes/

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Mandy Chung
On Tue, 29 Aug 2023 16:12:27 GMT, Alan Bateman wrote: >> Mandy Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revised the API change. Add Option::DROP_METHOD_INFO >> - Review feedback from Remi > > src/java.base/share/classes/

Re: RFR: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed

2023-08-29 Thread Naoto Sato
On Tue, 22 Aug 2023 12:22:54 GMT, Andrey Turbanov wrote: > After [JDK-8245241](https://bugs.openjdk.org/browse/JDK-8245241), the field > `sun.util.locale.provider.LocaleProviderAdapter#defaultLocaleProviderAdapter` > is only written in `` and then is not used after. > We can remove it. Thanks

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Alan Bateman
On Tue, 29 Aug 2023 00:16:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per fr

Re: RFR: 8315117: Update Zlib Data Compression Library to Version 1.3

2023-08-29 Thread Lance Andersen
On Tue, 29 Aug 2023 13:25:57 GMT, Alan Bateman wrote: > Okay, assuming tests are passing on windows-x64 and macos-aarch64 as these > are the two that will usually use the bundled zlib. Yes, both were clean in my mach5 runs - PR Comment: https://git.openjdk.org/jdk/pull/15453#issue

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v29]

2023-08-29 Thread Vladimir Kozlov
On Mon, 28 Aug 2023 23:28:44 GMT, Erik Joelsson wrote: >> Hi Erik, >> >> The reason this PR is focused on Linux is because the AVX512 sort and >> partitioning routines are based on Intel’s x86-simd-library >> (https://github.com/intel/x86-simd-sort) which was originally developed with >> GCC

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Vladimir Kozlov
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8297777: jdk.jlink StringSharingPlugin uses com.sun.tools.classfile library

2023-08-29 Thread Adam Sotona
On Wed, 23 Aug 2023 23:50:29 GMT, Qing Xiao wrote: > Migrate jdk.jlink StringSharingPlugin to use new classfile library Marked as reviewed by asotona (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15408#pullrequestreview-1600806536

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-08-29 Thread Jatin Bhateja
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v7]

2023-08-29 Thread Sean Coffey
> Recursive initialization calls possible during loading of LoggerFinder > service. > > This fix detects the recursive call and returns a temporary LoggerFinder that > is backed by a lazy logger. Automated test case developed to simulate loading > of an external LoggerFinder service while als

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Leo Korinth
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > I don't think this is the best change across so many files. > It gives a very ugly name to a common test fu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Roger Riggs
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children [v2]

2023-08-29 Thread Roger Riggs
On Tue, 29 Aug 2023 12:10:34 GMT, Matthias Baesken wrote: >> We have some failures in TreeTest.java where the expected number of child >> processes is differing from what we really get. It would be good to have >> more output to analyze these cases. > > Matthias Baesken has updated the pull req

RFR: JDK-8315214: Do not run sun/tools/jhsdb tests concurrently

2023-08-29 Thread Matthias Baesken
The sun/tools/jhsdb tests have issues when we run them concurrently . So add a related config to TEST.root. - Commit messages: - JDK-8315214 Changes: https://git.openjdk.org/jdk/pull/15469/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15469&range=00 Issue: https://bugs.o

Re: RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children [v2]

2023-08-29 Thread Thomas Stuefe
On Tue, 29 Aug 2023 12:10:34 GMT, Matthias Baesken wrote: >> We have some failures in TreeTest.java where the expected number of child >> processes is differing from what we really get. It would be good to have >> more output to analyze these cases. > > Matthias Baesken has updated the pull req

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v7]

2023-08-29 Thread Daniel Fuchs
On Tue, 29 Aug 2023 00:16:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per fr

Re: RFR: 8315117: Update Zlib Data Compression Library to Version 1.3

2023-08-29 Thread Alan Bateman
On Mon, 28 Aug 2023 16:31:06 GMT, Lance Andersen wrote: > Hi all, > > Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK > > The [Zlib Data Compression Library](https://github.com/madler/zlib ) has > released Zlib 1.3 on August 18, 2023. > > There are a [small number of >

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v6]

2023-08-29 Thread Daniel Fuchs
On Tue, 29 Aug 2023 11:58:14 GMT, Sean Coffey wrote: >> Recursive initialization calls possible during loading of LoggerFinder >> service. >> >> This fix detects the recursive call and returns a temporary LoggerFinder >> that is backed by a lazy logger. Automated test case developed to simul

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v3]

2023-08-29 Thread Severin Gehwolf
On Thu, 10 Aug 2023 17:21:31 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a "jmodless" jlink mode to the JDK. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> install might not come with the packaged modules (directory `jmods`). This >> is

Re: RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children [v2]

2023-08-29 Thread Matthias Baesken
> We have some failures in TreeTest.java where the expected number of child > processes is differing from what we really get. It would be good to have more > output to analyze these cases. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revi

Integrated: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note

2023-08-29 Thread Pavel Rappo
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote: > Please review this trivial PR. This pull request has now been integrated. Changeset: a4e97aa4 Author:Pavel Rappo URL: https://git.openjdk.org/jdk/commit/a4e97aa4ebe6fcfc3ed9e45ed81df1d55e52d621 Stats: 4 lines in 1 file chang

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v6]

2023-08-29 Thread Sean Coffey
> Recursive initialization calls possible during loading of LoggerFinder > service. > > This fix detects the recursive call and returns a temporary LoggerFinder that > is backed by a lazy logger. Automated test case developed to simulate loading > of an external LoggerFinder service while als

Re: RFR: JDK-8314194: Reusing CyclicBarrier, it should be possible to change the barrierCommand

2023-08-29 Thread chenggwang
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote: > eg:5 individuals in the first round of written exams,ending with a ranking > based on everyone's score points; and a second round of interviews, with a > ranking based on the average of the three interviewers' scores;The two rounds > of ran

RFR: JDK-8314194: Reusing CyclicBarrier, it should be possible to change the barrierCommand

2023-08-29 Thread chenggwang
eg:5 individuals in the first round of written exams,ending with a ranking based on everyone's score points; and a second round of interviews, with a ranking based on the average of the three interviewers' scores;The two rounds of ranking methods are the barrierCommand, and they are different -

Re: RFR: JDK-8314194: Reusing CyclicBarrier, it should be possible to change the barrierCommand

2023-08-29 Thread Dalibor Topic
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote: > eg:5 individuals in the first round of written exams,ending with a ranking > based on everyone's score points; and a second round of interviews, with a > ranking based on the average of the three interviewers' scores;The two rounds > of ran

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi

Integrated: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"

2023-08-29 Thread Kevin Walls
On Thu, 24 Aug 2023 11:34:13 GMT, Kevin Walls wrote: > Several tests from test/jdk/sun/tools/jstatd are intermittent. > > Port clashes when run at the same time on the same machine have been a > problem. > The RMI error "no such object in table" can mean a reference on the RMI > server has bee

Re: RFR: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table" [v3]

2023-08-29 Thread Kevin Walls
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote: >> Several tests from test/jdk/sun/tools/jstatd are intermittent. >> >> Port clashes when run at the same time on the same machine have been a >> problem. >> The RMI error "no such object in table" can mean a reference on the RMI >> server h

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note [v2]

2023-08-29 Thread Kevin Walls
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote: >> Please review this trivial PR. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8314753 > - Initial commit Look

Re: RFR: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges

2023-08-29 Thread Christoph Langer
On Mon, 28 Aug 2023 05:24:09 GMT, Arno Zeller wrote: >> I think you might use System.getProperty("user.name"). But I am not sure >> about domain names of users on Windows. >> I am also not sure why the user name is currently determined by creating a >> file - there might be a reason for this th

Re: RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children

2023-08-29 Thread Thomas Stuefe
On Tue, 29 Aug 2023 07:51:59 GMT, Matthias Baesken wrote: > We have some failures in TreeTest.java where the expected number of child > processes is differing from what we really get. It would be good to have more > output to analyze these cases. Looks good. Small nit inline. test/jdk/java/la

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-29 Thread Alan Bateman
On Mon, 28 Aug 2023 07:28:48 GMT, Matthias Baesken wrote: > Hi Alan , when adding the test group sun/tools/jhsdb in TEST.root to the > exclusiveAccess.dirs , I cannot see the error any more. So it seems your > suggestions is correct . My command was actually wondering why we didn't have a TEST

RFR: JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children

2023-08-29 Thread Matthias Baesken
We have some failures in TreeTest.java where the expected number of child processes is differing from what we really get. It would be good to have more output to analyze these cases. - Commit messages: - JDK-8315213 Changes: https://git.openjdk.org/jdk/pull/15466/files Webrev: ht

Re: RFR: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table" [v3]

2023-08-29 Thread Serguei Spitsyn
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote: >> Several tests from test/jdk/sun/tools/jstatd are intermittent. >> >> Port clashes when run at the same time on the same machine have been a >> problem. >> The RMI error "no such object in table" can mean a reference on the RMI >> server h