On Mon, 4 Sep 2023 04:58:08 GMT, 温绍锦 wrote:
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
On Tue, 5 Sep 2023 02:46:21 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
On Sat, 8 Jul 2023 07:14:12 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/util/HexDigits.java line 44:
>>
>>> 42: * 0 -> '00' -> ('0' << 8) | '0' -> 0x3030
>>> 43: * 1 -> '01' -> ('0' << 8) | '1' -> 0x3130
>>> 44: * 2 -> '02' -> ('0' << 8) | '2' -> 0x3230
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
On Mon, 4 Sep 2023 16:13:53 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add comments
>
> src/java.base/share/classes/java/lang/StringUTF16.java line 1534:
>
>> 1532: */
>> 1533: static int
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
On Mon, 4 Sep 2023 07:26:37 GMT, Aleksey Shipilev wrote:
> Similar to other issues in the same area. I have no PPC32 machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after
On Mon, 4 Sep 2023 16:00:05 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
On Mon, 4 Sep 2023 11:33:30 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Mon, 4 Sep 2023 15:50:12 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
On Mon, 4 Sep 2023 15:38:19 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Mon, 4 Sep 2023 14:53:33 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separate type cast from Shift bindings.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 425:
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
On Mon, 4 Sep 2023 14:56:18 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Mon, 4 Sep 2023 14:56:18 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Mon, 4 Sep 2023 14:54:05 GMT, Martin Doerr wrote:
> Do you see a good place for such a comment?
PPC CallArranger seems like a good place to me. We have a similar explanation
comment in the AArch64 CallArranger.
> Maybe it would be better to use a different size for the last chunk. Maybe
>
On Mon, 4 Sep 2023 14:56:18 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Mon, 4 Sep 2023 14:50:37 GMT, Martin Doerr wrote:
>>> as it would no longer need an input type?
>>
>> Yes. Then both shift ops would always operate on `long`.
>
> I've changed it. Note that I need many more conversions because buffer
> load/store also use subtypes of `int`. Please take a
On Mon, 4 Sep 2023 12:22:00 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
On Mon, 4 Sep 2023 12:44:51 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Split Shift into ShiftLeft and ShiftRight + minor improvements.
>
>
On Mon, 4 Sep 2023 14:33:08 GMT, Jorn Vernee wrote:
>>> I think it's worth it in order to have a cleaner contract for the shift
>>> ops, should we want to use them for anything else in the future, but also
>>> just to make them easier to understand for future readers.
>>
>> I agree that
On Mon, 4 Sep 2023 14:27:27 GMT, Maurizio Cimadamore
wrote:
> as it would no longer need an input type?
Yes. Then both shift ops would always operate on `long`.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15417#discussion_r1315016599
On Mon, 4 Sep 2023 14:18:44 GMT, Jorn Vernee wrote:
> If this struct is passed as an argument, then the load of the second 'half'
> of the struct would look like this:
It would perhaps be cleaner if in the MSB/LSB comments we said:
LSBs are zzz...z
LSBs are 000...0
(e.g. avoid to refer to
On Fri, 1 Sep 2023 18:40:55 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test
On Mon, 4 Sep 2023 12:20:52 GMT, Martin Doerr wrote:
>> Sorry for the delay, I've been on vacation.
>
>> Sorry for the delay, I've been on vacation.
>
> No problem. Hope you had a good time! Thanks for your feedback.
@TheRealMDoerr We've been discussing the shifts in order to wrap our heads
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit directly from
> constant-folding of BitSets:
>
>
On Mon, 4 Sep 2023 12:22:00 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Mon, 4 Sep 2023 12:19:42 GMT, Martin Doerr wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 398:
>>
>>> 396: bindings.add(Binding.cast(type, int.class));
>>> 397: type = int.class;
>>> 398: }
>>
>> Part of the casts
On Thu, 1 Jun 2023 09:37:29 GMT, Aleksey Shipilev wrote:
>> UUID is the very important class that is used to track identities of objects
>> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
>> of total CPU time, and is frequently a scalability bottleneck due to
>>
On Mon, 4 Sep 2023 07:26:36 GMT, Jorn Vernee wrote:
> Sorry for the delay, I've been on vacation.
No problem. Hope you had a good time! Thanks for your feedback.
> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 398:
>
>> 396:
On Mon, 4 Sep 2023 07:06:39 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary imports.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 695:
>
>> 693:
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This PR adds the required functionality to the Java code.
>
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote:
>> Modify the `Space` instances used for size comparison to be created with
>> total number of bytes derived from the Windows `diskFree` utility instead of
>> Cygwin’s `df`.
>
> Brian Burkhalter has updated the pull request
On Fri, 1 Sep 2023 13:27:58 GMT, Alan Bateman wrote:
> > Hi Alan , Your assumption 'I assume the use of System.getProperty is
> > problematic when running with a SM.' is most likely correct.
>
> You'll need to test with a SM that denies reading the system property to be
> sure. There are
On Mon, 4 Sep 2023 06:54:40 GMT, Per Minborg wrote:
>> This PR proposes adding a new method to BitSet that provides an immutable
>> snapshot of the set in the form of an `IntPredicate`.
>>
>> The predicate is eligible for constant folding.
>>
>> Here are some classes in the JDK that would
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Wed, 26 Apr 2023 04:34:34 GMT, Chen Liang wrote:
> This patch aims to correct handling of annotations on parameters with the
> help of `MethodParameters` attribute, which will be always available once
> #9862 is integrated.
>
> It utilizes and expands upon the existing parameter matching
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Fri, 1 Sep 2023 08:14:26 GMT, Qing Xiao wrote:
> /test/jdk/tools/lib/tests/JImageValidator.java, tests in
> /test/jdk/tools/jlink and /test/jdk/tools/jimage use on
> com.sun.tools.classfile and should be converted to Classfile API.
Following tier2 test is affected by the change and fails:
On Fri, 1 Sep 2023 18:40:55 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test
On Sat, 8 Jul 2023 00:20:20 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Fri, 1 Sep 2023 14:59:19 GMT, Jaikiran Pai wrote:
> I asked for Mark's and Joe's inputs on this in the linked JBS issue
> https://bugs.openjdk.org/browse/JDK-8233160. Mark has suggested that we keep
> this `java.vendor.url.bug` system property non-optional and also not to add
> any
On Fri, 1 Sep 2023 11:32:45 GMT, Markus Grönlund wrote:
>> Thanks. One other thing that I see when more testing with generational ZGC
>> is that ZPageAllocator::alloc_page will record an event and this can happen
>> during a mount transition. So I think JfrStackTrace::record also needs to
>>
On Fri, 1 Sep 2023 08:32:20 GMT, Christoph Langer wrote:
>> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
>> as user that is member of the Administrators group. In that case new files
>> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
On Mon, 4 Sep 2023 08:01:16 GMT, Julian Waters wrote:
> Is this all clear for sponsorship?
Yes, I have checked with @dholmes-ora
-
PR Comment: https://git.openjdk.org/jdk/pull/15343#issuecomment-1704827486
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
> In the virtual thread implementation, thread identity switches to the carrier
> before freezing and switches back to the virtual thread after thawing. This
> was a forced move due to issues getting JVMTI to work with virtual threads.
> JVMTI can now hide events during transitions so we can
On Fri, 1 Sep 2023 08:32:20 GMT, Christoph Langer wrote:
>> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
>> as user that is member of the Administrators group. In that case new files
>> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Wed, 30 Aug 2023 20:34:01 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the
Similar to other issues in the same area. I have no SPARC machine to test the
build on, but this matches other fixes for other architectures
(https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
after this fix the SPARC Zero build completes fine.
-
Similar to other issues in the same area. I have no PPC32 machine to test the
build on, but this matches other fixes for other architectures
(https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
after this fix the PPC32 Zero build completes fine.
-
On Fri, 25 Aug 2023 09:24:15 GMT, Maurizio Cimadamore
wrote:
>> The ABI says: "An aggregate or union smaller than one doubleword in size is
>> padded so that it appears in the least significant bits of the doubleword.
>> All others are padded, if necessary, at their tail."
>>
On Fri, 25 Aug 2023 10:59:45 GMT, Martin Doerr wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
>> 8.
On Thu, 31 Aug 2023 06:53:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8233160?
>
> It has been noted in https://bugs.openjdk.org/browse/JDK-8232753 that:
>
>> The java.vendor.url.bug property has been
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit directly from
> constant-folding of BitSets:
>
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.StringUpperLower.*"
>
>
>
> ## 1.
> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
> * cpu : intel xeon sapphire rapids
67 matches
Mail list logo
