On Wed, 18 Oct 2023 11:56:14 GMT, Claes Redestad wrote:
> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
> One idea to reduce this is to generate expression trees with fewer branches
> by looking up and using the prefix-less `prepend` methods directly for cases
>
On Thu, 19 Oct 2023 01:22:46 GMT, David Holmes wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add s390 support
>
> src/hotspot/share/gc/shared/gcLocker.cpp line 139:
>
>> 137: // has called `jni_unlock`, but
> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
> CLI options to jpackage to provide signing identity directly to `codesign`
> and `productbuild` tools as per CSR
> [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
> - If `codesign` or `productbuild`
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Wed, 18 Oct 2023 17:35:58 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this
On Wed, 18 Oct 2023 19:05:06 GMT, Matthew Donovan wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 110:
> 108:
> 109: private static VarHandle getVarHandle(StructLayout struct, String
> name) {
> 110:
On Wed, 18 Oct 2023 20:08:26 GMT, Phil Race wrote:
>> Requiring users to specify the size of the sequence layout was done in order
>> to dispel the illusion that there was any kind of special handling for a
>> sequence layout created without a size. e.g. if you try to allocate with it,
>>
On Wed, 18 Oct 2023 06:26:24 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main module is specified. The module name will be stored in
On Tue, 17 Oct 2023 23:34:56 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
That's interesting. As soon as this went RFR, skara started to send all the
emails from several weeks of already resolved discussions but with a current
timestamp, like we
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one additional
On Wed, 18 Oct 2023 15:24:14 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Wed, 18 Oct 2023 19:05:06 GMT, Matthew Donovan wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional
On Wed, 18 Oct 2023 06:16:15 GMT, Jorn Vernee wrote:
>>> > I'm unclear why it is "better". It seems more obscure to me.
>>>
>>> Ok. I think it's better because it doesn't require creating a maximum size
>>> sequence layout in order to then make a var handle out of, which is a bit
>>> of a
On Wed, 18 Oct 2023 18:20:49 GMT, Stuart Marks wrote:
>> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 77:
>>
>>> 75:
>>> 76: public void testRmiCommunication(RMIServerSocketFactory
>>> serverFactory) throws Exception {
>>> 77: Hello stub =
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
I've added a test, which although it does not check the rendering is correct,
it checks that the rendering would be identical in both the JNI and FFM cases.
So if it's
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 425:
> 423: float startY = (float)startPt.getY();
> 424:
> 425: MemorySegment
On Tue, 17 Oct 2023 22:53:30 GMT, Phil Race wrote:
> I'm unclear why it is "better". It seems more obscure to me.
Ok. I think it's better because it doesn't require creating a maximum size
sequence layout in order to then make a var handle out of, which is a bit of a
hack IMO. One that was
On Wed, 18 Oct 2023 04:44:30 GMT, Phil Race wrote:
>>> I'm unclear why it is "better". It seems more obscure to me.
>>
>> Ok. I think it's better because it doesn't require creating a maximum size
>> sequence layout in order to then make a var handle out of, which is a bit of
>> a hack IMO.
On Fri, 1 Sep 2023 03:45:24 GMT, Phil Race wrote:
> Probably I should not have posted this PR even as draft if it is going to get
> attention as it isn't really ready for that.
No! That is really interesting proposal and discussion!
BTW this PR is not in the draft state.
-
PR
On Wed, 18 Oct 2023 03:43:15 GMT, Jorn Vernee wrote:
> > I'm unclear why it is "better". It seems more obscure to me.
>
> Ok. I think it's better because it doesn't require creating a maximum size
> sequence layout in order to then make a var handle out of, which is a bit of
> a hack IMO. One
On Tue, 17 Oct 2023 11:50:20 GMT, Jorn Vernee wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
>
>> 308: SequenceLayout glyphInfosLayout =
>> MemoryLayout.sequenceLayout(maxinfo,
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
> 308: SequenceLayout glyphInfosLayout =
> MemoryLayout.sequenceLayout(maxinfo, GlyphInfoLayout);
>
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
@prrace did you check how this change affects the performance, especially
startup? I have experimented with Panama for littlecms:
On Wed, 30 Aug 2023 02:55:34 GMT, Sergey Bylokhov wrote:
> @prrace did you check how this change affects the performance, especially
> startup? I have experimented with Panama for littlecms:
> https://bugs.openjdk.org/browse/JDK-8313344 and found that the biggest issue
> is a cold start, 8 ms
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 55:
> 53: public class HBShaper {
> 54:
> 55: /*
Nice with the original C struct as a comment.
8318364: Add an FFM-based implementation of harfbuzz OpenType layout
-
Commit messages:
- remove tailing white space
- use scaling
- Fix windows build, remove perf. logging
- Add test, fix bug
- use allocateFrom
- add offset param
- suppressed restricted warnings, now builds
> This PR refactors the SSLSocketParametersTest by removing
> redundant/unnecessary classes and cleans up the logic around expected
> exceptions.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
added reachability fence for the
On Tue, 17 Oct 2023 11:33:00 GMT, Matthew Donovan wrote:
>> test/lib/jdk/test/lib/Asserts.java line 588:
>>
>>> 586: }
>>> 587: // fail() throws a RuntimeException so this is unreachable.
>>> 588: return null;
>>
>> Hm, this is unfortunate. Even though this method
On Mon, 16 Oct 2023 19:57:12 GMT, Naoto Sato wrote:
> CLDR provides very few short names for time zones, such as PST/PDT. This will
> typically end up substituting names from the COMPAT provider. Once the COMPAT
> is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY.
>
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
Sorry, I didn't realize Lance was calling on me to review, certainly a reminder
to read 'mention'
On Mon, 16 Oct 2023 11:13:57 GMT, Mark Sheppard wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>
> Reasons:
>
> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
> creating a new shortcut can make writing shorter;
> * Since all possible values of `byte` are legal Latin-1 characters,
>
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15 39052.832 ± 107.496 ns/op
> +
On Wed, 18 Oct 2023 15:43:12 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
On Wed, 18 Oct 2023 09:00:09 GMT, Per Minborg wrote:
>> This PR proposes to add a number of "capturing factories" in classes in the
>> `java.util.function` package.
>>
>> The PR additionally (an optionally) proposes to add a new function
>> `UnaryOperator::andThenUnary` to allow composition
Hi Alan,
Thanks for your response and the suggestion. I have copied, net-dev on my
original mail. I will wait for a response from net-dev group.
Regards,
Ramdas
From: Alan Bateman
Sent: Wednesday, October 18, 2023 8:51 PM
To: Nandagiri, Ramadasu (NSDi) ;
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
Anyone want to review? I will integrate tomorrow.
-
PR Comment:
On Wed, 18 Oct 2023 16:39:47 GMT, Alan Bateman wrote:
> We have to be very careful with proposals like this as it means code outside
> of java.lang having access to the underlying bytes. I think other
> alternatives needs to be explored to avoid this and related concerns.
Yes, adding another
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN,
On Wed, 18 Oct 2023 17:04:52 GMT, Sidraya Jayagond
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add PPC impl
>> - add missing file
>
> Add s390x port from here
>
On Wed, 18 Oct 2023 14:29:01 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Wed, 18 Oct 2023 09:00:09 GMT, Per Minborg wrote:
>> This PR proposes to add a number of "capturing factories" in classes in the
>> `java.util.function` package.
>>
>> The PR additionally (an optionally) proposes to add a new function
>> `UnaryOperator::andThenUnary` to allow composition
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Wed, 18 Oct 2023 15:32:34 GMT, Maurizio Cimadamore
wrote:
> This PR updates the man pages for `javac` and `java` to document:
> * the new `javac` warning for restricted methods (`-Xlint:restricted`)
> * the `java` option to allow access to restricted methods without warnings
>
On Wed, 18 Oct 2023 16:27:58 GMT, Roger Riggs wrote:
> The new usages that are driving this change would be better served by a
> method dedicated to creating latin1 strings from a caller provided byte
> array. The JavaLangAccess shared secret interface is already overused, but it
> is
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code
On Wed, 18 Oct 2023 15:32:34 GMT, Maurizio Cimadamore
wrote:
> This PR updates the man pages for `javac` and `java` to document:
> * the new `javac` warning for restricted methods (`-Xlint:restricted`)
> * the `java` option to allow access to restricted methods without warnings
>
On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 18 Oct 2023 16:04:34 GMT, Jim Laskey wrote:
>> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
>> One idea to reduce this is to generate expression trees with fewer branches
>> by looking up and using the prefix-less `prepend` methods directly for cases
>>
On Wed, 18 Oct 2023 11:56:14 GMT, Claes Redestad wrote:
> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
> One idea to reduce this is to generate expression trees with fewer branches
> by looking up and using the prefix-less `prepend` methods directly for cases
>
On Mon, 16 Oct 2023 11:28:36 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
Marked as reviewed by srl (Committer).
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update lastModifiedTime comment
-
Changes:
On Wed, 18 Oct 2023 14:29:01 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
In #16006 using `StringConcatFactory` seem to induce a run-to-run variance. One
idea to reduce this is to generate expression trees with fewer branches by
looking up and using the prefix-less `prepend` methods directly for cases where
constant is null/empty so that the prefixed prepender will
> CLDR provides very few short names for time zones, such as PST/PDT. This will
> typically end up substituting names from the COMPAT provider. Once the COMPAT
> is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY.
> Although some of the short names in the COMPAT provider are
On Wed, 18 Oct 2023 15:13:14 GMT, Magnus Ihse Bursie wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Delay populating GMT format at runtime. Reflecting review comments.
>
> make/modules/jdk.localedata/Gensrc.gmk
On Mon, 18 Sep 2023 13:17:25 GMT, Lance Andersen wrote:
>> Please review this PR which improves the Zip64 extra header validation:
>>
>> - Throw a ZipException If the extra len field is 0 and :
>> -- size, csize, or loc offset are set to 0x
>> -- disk starting number is set to 0x
>>
This PR updates the man pages for `javac` and `java` to document:
* the new `javac` warning for restricted methods (`-Xlint:restricted`)
* the `java` option to allow access to restricted methods without warnings
(`--enable-native-access`)
-
Commit messages:
- Initial push
Changes:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because
On Fri, 22 Sep 2023 15:31:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 524:
>>
>>> 522: protected Object clone() throws CloneNotSupportedException {
>>> 523: AbstractMap result = (AbstractMap)super.clone();
>>> 524: return result;
On 18/10/2023 15:55, Nandagiri, Ramadasu (NSDi) wrote:
Hi,
Please see the discussion in the following mails. One of the TCK test
cases, api/java_net/MulticastSocket/ClassLevel.html is failing on
NonStop platform as NonStop doesn't support IP_MULTICAST_ALL option.
We would like this test
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
Marked as reviewed by lancea (Reviewer).
On Tue, 19 Sep 2023 23:48:07 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 375:
>>
>>> 373: */
>>> 374: public Collection values() {
>>> 375: return new AbstractCollection<>() {
>>
>> Note that this causes `m.values().equals(m.values())`
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
Hi,
Please see the discussion in the following mails. One of the TCK test cases,
api/java_net/MulticastSocket/ClassLevel.html is failing on NonStop platform as
NonStop doesn't support IP_MULTICAST_ALL option.
We would like this test case to be excluded from TCK. Please share your
thoughts on
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Sun, 15 Oct 2023 16:36:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Corrected use of whitespace in text block.
On Wed, 18 Oct 2023 14:38:41 GMT, Martin Doerr wrote:
> I wonder if the native_invoker_size_per_arg thing still works good enough. We
> may exceed the computed size, now, right?
Good point. I'll have a look at enhancing the test we have for this.
Intuitively, I think it will be okay. It's
On Wed, 18 Oct 2023 13:49:40 GMT, Jorn Vernee wrote:
> > Note: This error is not related to this PR. It was broken by
> > https://github.com/openjdk/jdk/commit/b12c471a990eb8f789410a20084918368c655659
> > which is incorrect for Big Endian. Should I file a new issue or is that
> > already
On Wed, 18 Oct 2023 13:13:07 GMT, Martin Doerr wrote:
>> Jorn Vernee has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Add xor benchmark
>> - add readOnly heap segment test
>> - shorten linker doc
>> - use allocateFrom in benchmarks
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
On Wed, 18 Oct 2023 13:13:07 GMT, Martin Doerr wrote:
>> Jorn Vernee has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Add xor benchmark
>> - add readOnly heap segment test
>> - shorten linker doc
>> - use allocateFrom in benchmarks
On Wed, 18 Oct 2023 13:53:35 GMT, Maurizio Cimadamore
wrote:
>> This PR moves turns default methods in `MemorySegment` and `MemoryLayout`
>> into ordinary abstract methods.
>> These interfaces cannot be subclasses by developers (they are sealed), so
>> there is no reson for having default
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one additional
> This PR moves turns default methods in `MemorySegment` and `MemoryLayout`
> into ordinary abstract methods.
> These interfaces cannot be subclasses by developers (they are sealed), so
> there is no reson for having default methods there. Also, default methods can
> have some detrimental
On Wed, 18 Oct 2023 13:13:07 GMT, Martin Doerr wrote:
> Note: This error is not related to this PR. It was broken by
> https://github.com/openjdk/jdk/commit/b12c471a990eb8f789410a20084918368c655659
> which is incorrect for Big Endian. Should I file a new issue or is that
> already known?
On Wed, 18 Oct 2023 08:18:47 GMT, Matthias Baesken wrote:
> 8315026 adjusted and improved the describings comments already for AIX/Linux.
> But macOS was not adjusted.
Thanks for the updates.
-
Marked as reviewed by rriggs (Reviewer).
PR Review:
On Wed, 18 Oct 2023 12:45:05 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Wed, 11 Oct 2023 11:18:41 GMT, Per Minborg wrote:
>> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update copyright year
> - Revoke change
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because
On Wed, 18 Oct 2023 09:42:27 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
On Wed, 18 Oct 2023 12:09:28 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/layout/AbstractLayout.java
>> line 47:
>>
>>> 45: import java.util.Optional;
>>> 46: import java.util.Set;
>>> 47: import java.util.function.Function;
>>
>> There are quite a few
On Wed, 18 Oct 2023 04:06:17 GMT, Jorn Vernee wrote:
>> This PR moves turns default methods in `MemorySegment` and `MemoryLayout`
>> into ordinary abstract methods.
>> These interfaces cannot be subclasses by developers (they are sealed), so
>> there is no reson for having default methods
On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
This PR moves turns default methods in `MemorySegment` and `MemoryLayout` into
ordinary abstract methods.
These interfaces cannot be subclasses by developers (they are sealed), so there
is no reson for having default methods there. Also, default methods can have
some detrimental effects, as
On Tue, 17 Oct 2023 17:31:30 GMT, Maurizio Cimadamore
wrote:
> This PR moves turns default methods in `MemorySegment` and `MemoryLayout`
> into ordinary abstract methods.
> These interfaces cannot be subclasses by developers (they are sealed), so
> there is no reson for having default methods
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Wed, 18 Oct 2023 11:12:43 GMT, Maurizio Cimadamore
wrote:
>> This had a pretty big impact, actually. Especially on the larger sizes:
>>
>>
>> Benchmark (size) Mode Cnt Score Error
>> Units
>> CriticalCalls.callNotPinned 100 avgt 30 84.818 �
On Wed, 18 Oct 2023 10:48:58 GMT, Jorn Vernee wrote:
>> Good point. I made this benchmark a while ago, before we had the more
>> optimized allocate variants
>
> This had a pretty big impact, actually. Especially on the larger sizes:
>
>
> Benchmark (size) Mode Cnt
1 - 100 of 137 matches
Mail list logo
