Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-12 Thread Jorn Vernee
On Fri, 10 Nov 2023 07:56:46 GMT, suchismith1993 wrote: > > That said, I think we should limit the exported symbols to only those found > > in the standard C library header files: > > https://en.cppreference.com/w/c/header > > Currently the symbols are restricted to some parts of libc and the

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-12 Thread Alan Bateman
On Fri, 10 Nov 2023 16:30:35 GMT, suchismith1993 wrote: > There is not generic way of generating this. It needs a manual intervention > and symbols are to be added on a need basis in future. Looks like a list to > be maintained. I had tried adding comments to explain the list, but that > cause

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-12 Thread Jorn Vernee
On Mon, 13 Nov 2023 02:32:48 GMT, David Holmes wrote: > I cannot decide if this is an AIX issue for not using dynamic libraries; a > FFI issue for assuming dynamic libraries; or a test issue. Won't this be a > general problem for any function you try to access via FFI that is statically > link

Re: RFR: JDK-8319123 : Implementation of JEP-461: Stream Gatherers (Preview) [v4]

2023-11-12 Thread Viktor Klang
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Addressing further review feedback - Changes: - all: https://git.openjdk.org/jdk/pull/16420/files

Re: RFR: 8318776: Require supports_cx8 to always be true [v3]

2023-11-12 Thread David Holmes
> As discussed in JBS all platforms (some tweaks to Zero are in progress) > actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip > out the locked-based alternatives to using it and just add a guarantee that > it is true at runtime. And all platforms except some ARM variant

Re: RFR: 8318776: Require supports_cx8 to always be true [v2]

2023-11-12 Thread David Holmes
> As discussed in JBS all platforms (some tweaks to Zero are in progress) > actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip > out the locked-based alternatives to using it and just add a guarantee that > it is true at runtime. And all platforms except some ARM variant

RFR: 8318776: Require supports_cx8 to always be true

2023-11-12 Thread David Holmes
As discussed in JBS all platforms (some tweaks to Zero are in progress) actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip out the locked-based alternatives to using it and just add a guarantee that it is true at runtime. And all platforms except some ARM variants set `

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-12 Thread David Holmes
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) I cannot decide if this is an AIX issue for not using dynamic libraries; a FFI issue for assumin

RFR: JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args

2023-11-12 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868) which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_ static factory methods that have the _style_ parameter. - Commit messages: - init Changes: https://git.openjdk.org/jdk/pull/16624

Integrated: JDK-8318189: ChoiceFormat::format throws undocumented AIOOBE

2023-11-12 Thread Justin Lu
On Thu, 9 Nov 2023 21:58:12 GMT, Justin Lu wrote: > Please review this PR which makes an `ArrayIndexOutOfBoundsException` > apparent in ChoiceFormat::format. > > An _incomplete_ ChoiceFormat can be created, which is not revealed until > format is invoked. This pull request has now been integr

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v6]

2023-11-12 Thread Alan Bateman
On Wed, 18 Oct 2023 17:37:30 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a "jmodless" jlink mode to the JDK. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> install might not come with the packaged modules (directory `jmods`). This >> is

Re: RFR: 8316557: Make fields final in 'sun.util' package

2023-11-12 Thread Andrey Turbanov
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote: > A few classes in `sun.util` package have non-final fields which could easily > be marked `final`. Can I get a review? - PR Comment: https://git.openjdk.org/jdk/pull/15736#issuecomment-1807066050