> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Addressing last review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16420/files
-
On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos wrote:
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature.
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Integrates Paul Sandoz's feedback/changes
Co-authored-by: Paul Sandoz
On Mon, 13 Nov 2023 15:37:29 GMT, Severin Gehwolf wrote:
> It's not clear what you mean by that. Dropped from what? The CSR? Something
> else? The run-image based link needs the `--add-run-image-resources` plugin
> for it to work.
I mean the list of plugins that are listed by --list-plugins.
On Mon, 13 Nov 2023 23:48:25 GMT, Paul Sandoz wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor improvements to Gatherer Javadoc
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 166:
>
>>
On Mon, 13 Nov 2023 21:59:05 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is
On Mon, 13 Nov 2023 07:46:37 GMT, Jorn Vernee wrote:
>>> For some context: `java.lang.foreign.Linker.nativeLinker().defaultLookup()`
>>> returns a `SymbolLookup` that can be used to find symbols from the standard
>>> library.
>>>
>>> We use a shim library that re-exports symbols from the
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Mon, 13 Nov 2023 17:00:32 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>>
On Mon, 13 Nov 2023 19:41:48 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request with a new target base due to
On Mon, 13 Nov 2023 23:35:11 GMT, Naoto Sato wrote:
> Correcting the explanation of the `DateFormat.SHORT` constant.
src/java.base/share/classes/java/text/DateFormat.java line 120:
> 118: * result; from {@link #SHORT} to {@link #MEDIUM} to {@link #LONG} to
> {@link #FULL}. The exact result
On Mon, 13 Nov 2023 08:36:44 GMT, Tobias Hartmann wrote:
>> Below is baseline data collected using a modified version of the
>> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
>> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
>> i7-1185G7,
On Mon, 13 Nov 2023 09:22:13 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor improvements to Gatherer Javadoc
On Mon, 4 Sep 2023 04:58:08 GMT, Shaojin Wen wrote:
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I
On Mon, 13 Nov 2023 21:38:11 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868)
>> which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_
>> static factory methods that have the _style_ parameter.
>
> Justin Lu has updated
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
This pull request has now been integrated.
Changeset: fe0ccdf5
Author:Naoto
Correcting the explanation of the `DateFormat.SHORT` constant.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16645/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16645=00
Issue: https://bugs.openjdk.org/browse/JDK-8319986
Stats: 1 line in 1
Classes in the `java.lang.ref` package would benefit from an update to bring
the spec in line with how the VM already behaves. The changes would focus on
_happens-before_ edges at some key points during reference processing.
A couple key things we want to be able to say are:
-
On Mon, 13 Nov 2023 16:09:10 GMT, Maurizio Cimadamore
wrote:
>> This simplePR tweaks the factory which wraps custom cleanup actions passed
>> to `MemorySegment::reinterpret`, so that any exception thrown by the custom
>> cleanup is swallowed when the arena is closed.
>>
>> This aligns the
On Mon, 13 Nov 2023 18:33:55 GMT, Naoto Sato wrote:
>> test/jdk/java/time/test/java/time/format/TestDateTimeParsing.java line 260:
>>
>>> 258: .toFormatter(Locale.ROOT)
>>> 259: .toFormat();
>>> 260: assertEquals(f.parseObject("17-30", new ParsePosition(0)),
>>>
On Mon, 13 Nov 2023 18:41:08 GMT, Naoto Sato wrote:
>> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
>> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
>> null.
>
> Naoto Sato has updated the pull request incrementally with one additional
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
which overrides and provides an implementation of `toString()` in
_java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
This change is primarily to provide a more informative String representation of
On Mon, 13 Nov 2023 19:32:18 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review, one -> any
>
> src/java.base/share/classes/java/text/DateFormat.java line 68:
>
>> 66: * styles. The
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868)
> which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_
> static factory methods that have the _style_ parameter.
Justin Lu has updated the pull request incrementally with one additional commit
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote:
>> ~~I will force push to change ONLY the commit message once I get a bug
>> created - I am not currently an author. In draft until I do that.~~ Done
>>
>> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin
>>
>> This
On Wed, 8 Nov 2023 21:58:47 GMT, Eamonn McManus wrote:
> This change simply replaces "period" with "duration", or in one case replaces
> "period unit" with just "unit".
This pull request has now been integrated.
Changeset: 965ae729
Author:Eamonn McManus
URL:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Mon, 13 Nov 2023 19:49:17 GMT, Alan Bateman wrote:
> I assume you'll run the tests a number of times to make sure they are stable.
I always run tiers 1-3 before integrating, but will add also separate runs of
these tests with repeats.
-
PR Comment:
On Mon, 13 Nov 2023 19:41:48 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request with a new target base due to
On Mon, 13 Nov 2023 18:41:08 GMT, Naoto Sato wrote:
>> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
>> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
>> null.
>
> Naoto Sato has updated the pull request incrementally with one additional
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains
> In the Windows implementation of java.io.File.getCanonicalPath, strip any
> long path or UNC prefix before canonicalizing the remainder of the pathname.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
On Sat, 11 Nov 2023 11:18:04 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287843: Remove unused constant and method from WindowsPrefixes test
>
>
On Sun, 12 Nov 2023 21:39:29 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868)
> which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_
> static factory methods that have the _style_ parameter.
On Tue, 7 Nov 2023 14:18:41 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> void test(Object o) {
>> switch (o) {
>> case X1 -> {}
>> case X2 -> {}
>> ...(about 100 cases)
>> ```
>>
>> javac will compile the switch into a switch whose selector is an indy
>> invocation
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
comment fix^2
On Fri, 10 Nov 2023 01:20:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote:
> That would probably also involve taking existing documentation such as the
> note about not opening entries with "."/"..", and the POSIX permissions
> mappings? Would it make sense to split the rest of the changes in this PR
> from
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the Islamic Calendar to
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
This pull request
On Wed, 8 Nov 2023 21:58:47 GMT, Eamonn McManus wrote:
> This change simply replaces "period" with "duration", or in one case replaces
> "period unit" with just "unit".
Looks good.
I reviewed the CSR, it can be "Finalized" to get its review started.
-
Marked as reviewed by
On Mon, 13 Nov 2023 16:05:08 GMT, Maurizio Cimadamore
wrote:
> After some offline discussions, I've decided to add a new exception
> (Arena.CleanupException) which is used to wrap custom cleanup action
> exceptions and rethrow them on close.
To be clear, the reasons as to why the original
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore
wrote:
> This simplePR tweaks the factory which wraps custom cleanup actions passed to
> `MemorySegment::reinterpret`, so that any exception thrown by the custom
> cleanup is swallowed when the arena is closed.
>
> This aligns the
> This simplePR tweaks the factory which wraps custom cleanup actions passed to
> `MemorySegment::reinterpret`, so that any exception thrown by the custom
> cleanup is swallowed when the arena is closed.
>
> This aligns the behavior of confined/shared session with that of implicit
> session
On Sat, 11 Nov 2023 14:04:11 GMT, Alan Bateman wrote:
>> Yakov Shafranovich has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed more line breaks
>> - fixed line breaks
>
> src/jdk.zipfs/share/classes/module-info.java line 310:
>
On Sun, 12 Nov 2023 11:37:31 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Add a message when a run-image based link is being performed
>> - Add hint to the modified file case
>> -
On Mon, 13 Nov 2023 12:02:11 GMT, Stewart X Addison wrote:
> ~~I will force push to change ONLY the commit message once I get a bug
> created - I am not currently an author. In draft until I do that.~~ Done
>
> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin
>
> This fixes a
> ~~I will force push to change ONLY the commit message once I get a bug
> created - I am not currently an author. In draft until I do that.~~ Done
>
> FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin
>
> This fixes a build break which has shown up on 32-bit Windows (Deprecated
~~I will force push to change ONLY the commit message once I get a bug created
- I am not currently an author. In draft until I do that.~~ Done
FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin
This fixes a build break which has shown up on 32-bit Windows (Deprecated but
not
On Thu, 9 Nov 2023 15:39:54 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/aarch64/downcallLinker_aarch64.cpp line 182:
>>
>>> 180: ArgumentShuffle arg_shuffle(filtered_java_regs, out_regs,
>>> shuffle_reg);
>>> 181:
>>> 182: #ifndef PRODUCT
>>
>> Any particular reason to exclude the logging
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
On Mon, 13 Nov 2023 07:41:11 GMT, Alan Bateman wrote:
> > There is not generic way of generating this. It needs a manual intervention
> > and symbols are to be added on a need basis in future. Looks like a list to
> > be maintained. I had tried adding comments to explain the list, but that
>
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
LGTM. See comments though.
src/java.base/share/classes/sun/util/locale/StringTokenIterator.java line 33:
> 31: package sun.util.locale;
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
line 48:
> 46: public class CLDRCalendarDataProviderImpl
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Mon, 13 Nov 2023 08:35:21 GMT, Jorn Vernee wrote:
> Not sure whether always swallowing the exceptions is the right move... it
> seems like an advantage that explicit arenas _can_ report exceptions thrown
> by cleanup actions. Silently ignoring exceptions seems bad, but something
> that is
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading expressions around.
Per Minborg has updated the pull request incrementally
On Fri, 10 Nov 2023 07:19:42 GMT, Per Minborg wrote:
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading expressions around.
On Mon, 13 Nov 2023 09:22:13 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor improvements to Gatherer Javadoc
Marked
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Minor improvements to Gatherer Javadoc
-
Changes:
- all:
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore
wrote:
> This simplePR tweaks the factory which wraps custom cleanup actions passed to
> `MemorySegment::reinterpret`, so that any exception thrown by the custom
> cleanup is swallowed when the arena is closed.
>
> This aligns the
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote:
> Below is baseline data collected using a modified version of the
> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
> i7-1185G7, which
On Fri, 10 Nov 2023 07:19:42 GMT, Per Minborg wrote:
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading expressions around.
71 matches
Mail list logo
