On Thu, 4 Jan 2024 13:41:40 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating copyright year of modified files.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5307:
>
>> 5305:
> Hi,
>
> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only
> targets.
> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
> instruction set.
> These are very frequently used APIs in columnar database filter operation.
>
> Implementation uses a
On Thu, 4 Jan 2024 13:30:24 GMT, Emanuel Peter wrote:
>> test/micro/org/openjdk/bench/jdk/incubator/vector/ColumnFilterBenchmark.java
>> line 94:
>>
>>> 92:IntVector vec = IntVector.fromArray(ispecies, intinCol, i);
>>> 93:VectorMask pred =
On Wed, 3 Jan 2024 09:51:24 GMT, Stefan Karlsson wrote:
> Most functions in ProcessTools are declared to throw Exceptions, or one of
> its subclasses. However, there are a small number of functions that are
> unnecessarily declared to throw Throwable instead of Exception. I propose
> that we
On Fri, 5 Jan 2024 07:03:26 GMT, Jatin Bhateja wrote:
>> And what about some result verification? Or is there another test that does
>> that?
>
> We do have extensive functional tests for compress/expand APIs in
>
On Thu, 4 Jan 2024 13:33:08 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating copyright year of modified files.
>
>
On 5/01/2024 12:24 am, Glavo wrote:
I expect there are security reasons why the JDK tries to find
the file itself in these specific paths, rather than letting the
platform code search for it.
I think this should have nothing to do with security. If there is a
vulnerability in the
On Thu, 4 Jan 2024 19:09:34 GMT, Joe Wang wrote:
> backport of PR: https://github.com/openjdk/jdk/pull/17252
This pull request has now been integrated.
Changeset: b1219319
Author:Joe Wang
URL:
https://git.openjdk.org/jdk22/commit/b121931959e08951a8cc02eb925a77657441f175
Stats:
amber-...@openjdk.org
On Thu, Jan 4, 2024 at 8:29 PM Bradley Willcott
wrote:
> Hi there.
> I am sorry if this is 'off subject'. However, where do I go to propose a
> new java feature? And please be nice :-).
>
> Thanks,
> Brad.
>
Try and search up the idea before posting though. A lot of people have made
feature requests before you.
On Thu, Jan 4, 2024 at 8:40 PM David Alayachew
wrote:
> amber-...@openjdk.org
>
> On Thu, Jan 4, 2024 at 8:29 PM Bradley Willcott
> wrote:
>
>> Hi there.
>> I am sorry if this is 'off
Hi there.
I am sorry if this is 'off subject'. However, where do I go to propose a
new java feature? And please be nice :-).
Thanks,
Brad.
On Thu, 21 Dec 2023 19:10:59 GMT, Calvin Cheung wrote:
> Please review this change for enabling full module graph even when
> -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is
> already being done in `FileMapInfo::validate_boot_class_paths()`. The full
> module graph will
On Sat, 23 Dec 2023 08:08:35 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Alan and Ioi
>
> Marked as reviewed by alanb (Reviewer).
Thanks @AlanBateman @mlchung for the reviews.
On Thu, 4 Jan 2024 19:30:00 GMT, Justin Lu wrote:
>> Please review this PR which splits up the _LocaleProvidersRun_ test file for
>> performance and maintenance reasons.
>>
>> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR,
>> HOST, SPI, etc.) was getting rather
On Thu, 4 Jan 2024 19:09:34 GMT, Joe Wang wrote:
> backport of PR: https://github.com/openjdk/jdk/pull/17252
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/32#pullrequestreview-1804849821
On Thu, 4 Jan 2024 19:09:34 GMT, Joe Wang wrote:
> backport of PR: https://github.com/openjdk/jdk/pull/17252
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/32#pullrequestreview-1804842674
On Wed, 30 Aug 2023 22:35:43 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
> Please review this PR which splits up the _LocaleProvidersRun_ test file for
> performance and maintenance reasons.
>
> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR,
> HOST, SPI, etc.) was getting rather long, as all related bugs were added to
> the single test
On Thu, 4 Jan 2024 19:01:31 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup comments
>> - provide both SPI classes under build for relevant test files
>
>
backport of PR: https://github.com/openjdk/jdk/pull/17252
-
Commit messages:
- Backport 755722ced60a686799c7f419feae61c04ce41f09
Changes: https://git.openjdk.org/jdk22/pull/32/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=32=00
Issue:
On Wed, 3 Jan 2024 23:30:41 GMT, Justin Lu wrote:
> Please review this PR which splits up the _LocaleProvidersRun_ test file for
> performance and maintenance reasons.
>
> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR,
> HOST, SPI, etc.) was getting rather long,
On Fri, 18 Aug 2023 03:57:24 GMT, Martin Stypinski wrote:
> Added a bunch of different implementations for Vector API Matrix
> Multiplications:
>
> - Baseline
> - Blocked (Cache Local)
> - FMA
> - Vector API Simple Implementation
> - Vector API Blocked Implementation
>
> Commit was discussed
On Thu, 4 Jan 2024 18:37:59 GMT, Markus KARG wrote:
>> No: the third param of
>> [Arrays.copyOfRange](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Arrays.html#copyOfRange(byte[],int,int))
>> is `to`, not `len`.
>
> Ah, this explains why it did not fail originally, but
On Thu, 4 Jan 2024 18:32:55 GMT, Markus KARG wrote:
>> The final position instead of the number of bytes to write was being passed
>> to `ByteArrayOuputStream.write(byte[],int,int)`.
>
> src/java.base/share/classes/java/io/BufferedInputStream.java line 650:
>
>> 648: } else {
On Thu, 4 Jan 2024 18:35:49 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/BufferedInputStream.java line 650:
>>
>>> 648: } else {
>>> 649: // Prevent poisoning and leaking of buf
>>> 650: byte[] buffer =
On Wed, 3 Jan 2024 18:01:59 GMT, Brian Burkhalter wrote:
> The final position instead of the number of bytes to write was being passed
> to `ByteArrayOuputStream.write(byte[],int,int)`.
src/java.base/share/classes/java/io/BufferedInputStream.java line 650:
> 648: } else {
>
On Wed, 3 Jan 2024 00:49:01 GMT, Calvin Cheung wrote:
>> Please review this change for enabling full module graph even when
>> -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is
>> already being done in `FileMapInfo::validate_boot_class_paths()`. The full
>> module graph
On Thu, 4 Jan 2024 13:34:50 GMT, Johny Jose wrote:
> tzdata2023d changes
LTGM too, assuming all the tests passed
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17268#pullrequestreview-1804702013
On Thu, 4 Jan 2024 17:26:37 GMT, Naoto Sato wrote:
> 8322647: Short name for the `Europe/Lisbon` time zone is incorrect
This pull request has now been integrated.
Changeset: a72afb38
Author:Naoto Sato
URL:
On Thu, 4 Jan 2024 17:26:37 GMT, Naoto Sato wrote:
> 8322647: Short name for the `Europe/Lisbon` time zone is incorrect
Marked as reviewed by joehw (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/30#pullrequestreview-1804685583
8322647: Short name for the `Europe/Lisbon` time zone is incorrect
-
Commit messages:
- Backport ad31ec5c5f120082cedd7b9ece45b6b44147c0c5
Changes: https://git.openjdk.org/jdk22/pull/30/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=30=00
Issue:
On Mon, 13 Nov 2023 21:59:05 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
This pull request has
On Fri, 22 Dec 2023 18:59:20 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979), where the parsing
> of TZDB files was incorrect. With this fix, `TimeZoneNames_en.java` which is
> generated during the build time has
On Fri, 22 Dec 2023 18:59:20 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979), where the parsing
> of TZDB files was incorrect. With this fix, `TimeZoneNames_en.java` which is
> generated during the build time has
On Thu, 4 Jan 2024 14:21:54 GMT, Valeh Hajiyev wrote:
> why do you think the code would avoid heapify? `initFromCollection` method
> will be called regardless of the type of the collection passed, which will
> heapify the queue.
I simply mean to point out:
1. That if the given comparator
On Thu, 4 Jan 2024 14:53:46 GMT, Patricio Chilano Mateo
wrote:
>> This test was recently added by JDK-8322818. On some test systems, the test
>> passes a bit after the timeout so the test is marked as failed. The changes
>> here dial down the iterations from 100k to 25k to reduce the
On Thu, 4 Jan 2024 11:51:47 GMT, Alan Bateman wrote:
> This test was recently added by JDK-8322818. On some test systems, the test
> passes a bit after the timeout so the test is marked as failed. The changes
> here dial down the iterations from 100k to 25k to reduce the execution time
> for
On Thu, 4 Jan 2024 13:34:50 GMT, Johny Jose wrote:
> tzdata2023d changes
LGTM
-
Marked as reviewed by coffeys (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17268#pullrequestreview-1804359390
On Thu, 4 Jan 2024 11:51:47 GMT, Alan Bateman wrote:
> This test was recently added by JDK-8322818. On some test systems, the test
> passes a bit after the timeout so the test is marked as failed. The changes
> here dial down the iterations from 100k to 25k to reduce the execution time
> for
On Thu, 4 Jan 2024 05:39:01 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2
>> only targets.
>> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
>> instruction set.
>> These are very frequently used APIs in
tzdata2023d changes
-
Commit messages:
- 8322725: (tz) Update Timezone Data to 2023d
Changes: https://git.openjdk.org/jdk/pull/17268/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17268=00
Issue: https://bugs.openjdk.org/browse/JDK-8322725
Stats: 140 lines in 14 files
On Wed, 3 Jan 2024 20:36:46 GMT, jmehrens wrote:
> > I think this ticket should focus on adding the new constructor as part of
> > the API.
>
> Okay. I would think the code would avoid heapify when the caller does foolish
> things with this API such as:
>
> ```
> SortedSet ss =
>
> I expect there are security reasons why the JDK tries to find
> the file itself in these specific paths, rather than letting the
> platform code search for it.
>
I think this should have nothing to do with security. If there is a
vulnerability in the platform code, there is nothing the JDK
On Thu, 4 Jan 2024 13:09:30 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating copyright year of modified files.
>
>
On Thu, 4 Jan 2024 13:34:50 GMT, Johny Jose wrote:
> tzdata2023d changes
@naotoj Can you please review the changes
-
PR Comment: https://git.openjdk.org/jdk/pull/17268#issuecomment-1877117106
On Thu, 4 Jan 2024 12:53:07 GMT, Alan Bateman wrote:
>> -Djdk.tracePinnedThreads is a debugging option that dates from early
>> development in the loom repo to identify pinned threads. It has several
>> issues and this tracing option will eventually be removed (use the JFR
>> events instead).
> -Djdk.tracePinnedThreads is a debugging option that dates from early
> development in the loom repo to identify pinned threads. It has several
> issues and this tracing option will eventually be removed (use the JFR events
> instead). Several hangs have been reported when running with the
On Wed, 20 Dec 2023 20:25:07 GMT, Jim Laskey wrote:
> The new repeat methods were not clearing the toStringCache.
This pull request has now been integrated.
Changeset: df22fb32
Author:Jim Laskey
URL:
https://git.openjdk.org/jdk/commit/df22fb322e6c4c9931a770bd0abf4c43b83c4e4a
Stats:
This test was recently added by JDK-8322818. On some test systems, the test
passes a bit after the timeout so the test is marked as failed. The changes
here dial down the iterations from 100k to 25k to reduce the execution time for
release builds. No change for debug builds as this already uses
On Thu, 21 Dec 2023 07:55:50 GMT, Jaikiran Pai wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clear sooner
>
> test/jdk/java/lang/StringBuilder/StringBufferRepeat.java line 138:
>
>> 136: sb.repeat('*',
> The new repeat methods were not clearing the toStringCache.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Nit in test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17172/files
- new:
> The new repeat methods were not clearing the toStringCache.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
On Wed, 3 Jan 2024 21:29:57 GMT, Joshua Cao wrote:
>> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
>> `transfer()`. When coming from the copy constructor, the Map is empty, so
>> there is nothing to transfer. But `transfer()` will still copy all the empty
>>
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
On Wed, 3 Jan 2024 11:41:20 GMT, Matthias Baesken wrote:
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
>
55 matches
Mail list logo
