On Tue, 16 Jan 2024 21:18:55 GMT, Vicente Romero wrote:
> Updating ASM to version 9.6,
>
> Thanks in advance for the reviews,
> Vicente
Looks okay to me. I would rely on your testing for verification.
-
Marked as reviewed by mchung (Reviewer).
PR Review:
On Tue, 16 Jan 2024 21:18:55 GMT, Vicente Romero wrote:
> Updating ASM to version 9.6,
>
> Thanks in advance for the reviews,
> Vicente
hi Mandy, thanks for your comments,
> The change looks okay to me. Most of the changes are doc change. I see many
> files are updated just to remove the
On Thu, 25 Jan 2024 13:33:10 GMT, Andrew Dinn wrote:
>> Requiring such an API opens the module to anybody, though, punching a hole
>> into the module boundary.
>>
>> BB currently opens the jdk.internal.misc.Unsafe class to a module on a
>> seperate class loader that is not reachable outside
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
On Tue, 23 Jan 2024 11:40:00 GMT, Kim Barrett wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweak Reference.enqueue memory consistency effects wording
>
>
On Thu, 25 Jan 2024 22:49:39 GMT, Justin Lu wrote:
> In terms of the CSR,...
Hi Justin, thanks again very much for the comments and careful review. The CSR
should be updated accordingly.
-
PR Comment: https://git.openjdk.org/jdk/pull/17416#issuecomment-1911134650
On Thu, 25 Jan 2024 21:38:54 GMT, Archie Cobbs wrote:
>> Please consider this fix to ensure that going from `MessageFormat` to
>> pattern string via `toPattern()` and then back via `new MessageFormat()`
>> results in a format that is equivalent to the original.
>>
>> The quoting and escaping
> Please consider this fix to ensure that going from `MessageFormat` to pattern
> string via `toPattern()` and then back via `new MessageFormat()` results in a
> format that is equivalent to the original.
>
> The quoting and escaping rules for `MessageFormat` pattern strings are really
>
On Mon, 15 Jan 2024 10:48:23 GMT, Aleksey Shipilev wrote:
> Some jtreg tests require resolvable external dependencies. This resolution is
> delegated to JIB, which is not used in vanilla OpenJDK testing. It would be
> convenient to add a keyword that marks tests that require these external
>
On Mon, 15 Jan 2024 10:48:23 GMT, Aleksey Shipilev wrote:
> Some jtreg tests require resolvable external dependencies. This resolution is
> delegated to JIB, which is not used in vanilla OpenJDK testing. It would be
> convenient to add a keyword that marks tests that require these external
>
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Small
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Tidy
On Wed, 24 Jan 2024 21:28:29 GMT, Leonid Mesnik wrote:
>> Some jtreg tests require resolvable external dependencies. This resolution
>> is delegated to JIB, which is not used in vanilla OpenJDK testing. It would
>> be convenient to add a keyword that marks tests that require these external
>>
On Thu, 25 Jan 2024 14:48:16 GMT, Maurizio Cimadamore
wrote:
> I don't 100% buy the `MethodHandleImpl` analogy. In that case the check is
> not simply used to save a branch, but to spare spinning of a completely new
> lambda form.
Doing this to save a few intructions would not likely to
On Mon, 22 Jan 2024 20:52:32 GMT, Roger Riggs wrote:
> When an exception handler for an OutOfMemoryError uses string concatenation
> to compose an exception message, the invoke dynamic string format
> implementation may itself exhaust memory, preventing the exception from being
> handled.
>
> When an exception handler for an OutOfMemoryError uses string concatenation
> to compose an exception message, the invoke dynamic string format
> implementation may itself exhaust memory, preventing the exception from being
> handled.
> Explicit use of String.concat() call can improve
On Thu, 25 Jan 2024 12:52:21 GMT, Maurizio Cimadamore
wrote:
>>> > Naive question: the right way to use this would be almost invariably be
>>> > like this:
>>> > ```
>>> > if (isCompileConstant(foo) && fooHasCertainStaticProperties(foo)) {
>>> > // fast-path
>>> > }
>>> > // slow path
>>>
> Hi,
>
> This patch introduces `JitCompiler::isConstantExpression` which can be used
> to statically determine whether an expression has been constant-folded by the
> Jit compiler, leading to more constant-folding opportunities. For example, it
> can be used in
On Thu, 25 Jan 2024 05:06:12 GMT, David Holmes wrote:
>> I agree. All values are produced by evaluating expressions. In this case we
>> want to query whether a value produced by the compiler evaluating its
>> expression is a constant value (inputs to the expression are constants and
>> the
On Thu, 25 Jan 2024 12:52:21 GMT, Maurizio Cimadamore
wrote:
>>> > Naive question: the right way to use this would be almost invariably be
>>> > like this:
>>> > ```
>>> > if (isCompileConstant(foo) && fooHasCertainStaticProperties(foo)) {
>>> > // fast-path
>>> > }
>>> > // slow path
>>>
> From: "Viktor Klang"
> To: "Remi Forax"
> Cc: "core-libs-dev" , "Paul Sandoz"
>
> Sent: Wednesday, January 24, 2024 2:45:15 PM
> Subject: Re: Gatherer: spliterator characteristics are not propagated
> As a (related) side-note, the ability to implement the interface directly has
> a
>
On Thu, 25 Jan 2024 09:57:13 GMT, Maurizio Cimadamore
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 148:
>
>> 146:
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Tidy
On Thu, 25 Jan 2024 12:16:13 GMT, Rafael Winterhalter
wrote:
> Requiring such an API opens the module to anybody, though, punching a hole
> into the module boundary.
How so? Any module created to print Lookups can easily rely on a shared secret
to secure the API. Byteman employs a non-null
> From: "Viktor Klang"
> To: "Remi Forax"
> Cc: "core-libs-dev" , "Paul Sandoz"
>
> Sent: Wednesday, January 24, 2024 2:34:11 PM
> Subject: Re: Gatherer: spliterator characteristics are not propagated
> Presuming that you mean mutating the Gatherer such that its behavior isn't
> stable, the
On Thu, 25 Jan 2024 07:41:27 GMT, Roland Westrelin wrote:
> > > Naive question: the right way to use this would be almost invariably be
> > > like this:
> > > ```
> > > if (isCompileConstant(foo) && fooHasCertainStaticProperties(foo)) {
> > > // fast-path
> > > }
> > > // slow path
> > >
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
On Thu, 25 Jan 2024 10:22:52 GMT, Maurizio Cimadamore
wrote:
>> see my other comment above that I think supersedes this one
>
> I see what you mean, that said, I think having some high-level checks driving
> low-level classfile generation is pretty standard for code generators (e.g.
> lambda
On Thu, 25 Jan 2024 10:21:26 GMT, Maurizio Cimadamore
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 404:
>
>> 402:
On Wed, 24 Jan 2024 17:29:09 GMT, Vicente Romero wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant test from checkUnconditionallyExact
>
>
On Thu, 25 Jan 2024 10:15:48 GMT, Maurizio Cimadamore
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 592:
>
>> 590:
On Thu, 25 Jan 2024 10:12:31 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 471:
>>
>>> 469: // o instanceof float
>>> 470: Label notNumber = cb.newLabel();
>>>
On Thu, 14 Dec 2023 03:57:51 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding a comment to the test
>
> I have uploaded a few commits addressing the review comments, thanks!
Will this
On Thu, 25 Jan 2024 09:15:38 GMT, Matthias Baesken wrote:
>> According to the sysinfo manpage (
>> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
>> related entries in the struct sysinfo are given as multiples of mem_unit
>> bytes.
>> "In the above structure, sizes
On Wed, 24 Jan 2024 10:07:17 GMT, Matthias Baesken wrote:
> According to the sysinfo manpage (
> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
> related entries in the struct sysinfo are given as multiples of mem_unit
> bytes.
> "In the above structure, sizes of
On Wed, 24 Jan 2024 17:30:34 GMT, Vicente Romero wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 461:
>>
>>> 459: // Object o = ...
>>> 460: // o instanceof Wrapped(float)
>>> 461:
On Wed, 24 Jan 2024 23:50:51 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Thu, 25 Jan 2024 09:15:38 GMT, Matthias Baesken wrote:
>> According to the sysinfo manpage (
>> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
>> related entries in the struct sysinfo are given as multiples of mem_unit
>> bytes.
>> "In the above structure, sizes
On Wed, 24 Jan 2024 23:50:51 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Thu, 25 Jan 2024 09:15:26 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>>
On Wed, 24 Jan 2024 15:37:58 GMT, Vicente Romero wrote:
>> Aggelos Biboudis has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Enhance Javadoc of ExactConversionsSupport (2)
>> - Enhance Javadoc of ExactConversionsSupport
>
>
On Thu, 4 Jan 2024 05:28:59 GMT, Jatin Bhateja wrote:
> Hi,
>
> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only
> targets.
> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
> instruction set.
> These are very frequently used APIs in
On Thu, 25 Jan 2024 06:39:56 GMT, Alexander Kriegisch wrote:
>> Setting '-javaagent' is mainly an operations problem. Many build tools do
>> not allow to declare a test dependency this way as the life cycles are not
>> laid out for it, the internal repository location might be machine
>>
On Wed, 24 Jan 2024 23:50:51 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Wed, 24 Jan 2024 21:28:29 GMT, Leonid Mesnik wrote:
>> Some jtreg tests require resolvable external dependencies. This resolution
>> is delegated to JIB, which is not used in vanilla OpenJDK testing. It would
>> be convenient to add a keyword that marks tests that require these external
>>
On Tue, 23 Jan 2024 11:56:58 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2
>> only targets.
>> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
>> instruction set.
>> These are very frequently used APIs
> According to the sysinfo manpage (
> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
> related entries in the struct sysinfo are given as multiples of mem_unit
> bytes.
> "In the above structure, sizes of the memory and swap fields are given as
> multiples of
On Wed, 24 Jan 2024 10:07:17 GMT, Matthias Baesken wrote:
> According to the sysinfo manpage (
> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
> related entries in the struct sysinfo are given as multiples of mem_unit
> bytes.
> "In the above structure, sizes of
On Tue, 23 Jan 2024 10:21:42 GMT, Goetz Lindenmaier wrote:
> I backport this to fix this issue in 22. We see it failing there in our CI.
This pull request has now been integrated.
Changeset: 57bc96e5
Author:Goetz Lindenmaier
URL:
50 matches
Mail list logo
