Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Jaikiran Pai
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Jaikiran Pai
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause

Re: RFR: 8324573: HashMap::putAll should resize to sum of both map sizes [v4]

2024-02-08 Thread Stuart Marks
On Thu, 8 Feb 2024 17:01:15 GMT, Joshua Cao wrote: >> I think we should step back from benchmarks a bit and examine the various >> tradeoffs occurring here. Certainly we can speed things up by pre-resizing >> the map to be larger. However, this can result in a map that is too large >> for the

Re: RFR: 8315487: Security Providers Filter [v8]

2024-02-08 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by

Re: RFR: 8325506: Ensure randomness is only read from provided SecureRandom object [v2]

2024-02-08 Thread Weijun Wang
> Many crypto service classes require a `SecureRandom` object at > initialization. This test goes through each of them and calculates (generate, > encrypt, sign,...) twice with the same `SecureRandom` object and ensures the > output is the same. Weijun Wang has updated the pull request

Re: RFR: 8325506: Ensure randomness is only read from provided SecureRandom object

2024-02-08 Thread Weijun Wang
On Thu, 8 Feb 2024 20:53:03 GMT, Kevin Driver wrote: >> Many crypto service classes require a `SecureRandom` object at >> initialization. This test goes through each of them and calculates >> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and >> ensures the output is

Re: RFR: 8325203: System.exit(0) kills the launched 3rd party application

2024-02-08 Thread Alexander Matveev
On Thu, 8 Feb 2024 20:57:51 GMT, Alexey Semenyuk wrote: > Tested with the use case from the CR. > > The idea of the fix is to prevent grandchildren processes from being > automatically attached to the job killing all processes attached to it when > the job object is destroyed. > > Filed a

RFR: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags

2024-02-08 Thread Leonid Mesnik
Tests updated to use jtreg vm flags. Tested by running tests with different flags and tier1. - Commit messages: - 8316451 Changes: https://git.openjdk.org/jdk/pull/17781/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17781=00 Issue:

RFR: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only

2024-02-08 Thread Leonid Mesnik
There are several .sh tests which use ${TESTVMOPTS} only. Updated them to use ${TESTJAVAOPTS} also. Tested by running them with different options and tier1. - Commit messages: - 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only Changes:

Integrated: 8325505: Fix Javadoc ResourceBundle::getString

2024-02-08 Thread Thiago Henrique Hüpner
On Wed, 10 Jan 2024 12:35:56 GMT, Thiago Henrique Hüpner wrote: > 8325505: Fix Javadoc ResourceBundle::getString This pull request has now been integrated. Changeset: d91fb17a Author:Thiago Henrique Hüpner Committer: Naoto Sato URL:

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v7]

2024-02-08 Thread Naoto Sato
On Thu, 8 Feb 2024 21:29:19 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344) >> which adds MessageFormat pattern support for the following subformats: >> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is >> intended to

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v6]

2024-02-08 Thread Justin Lu
On Thu, 8 Feb 2024 21:16:45 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move the if-else nFmt checking to a package-private method in NumberFormat > >

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v7]

2024-02-08 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344) > which adds MessageFormat pattern support for the following subformats: > ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is > intended to provide pattern support for the more recently added JDK

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v6]

2024-02-08 Thread Naoto Sato
On Thu, 8 Feb 2024 20:37:18 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344) >> which adds MessageFormat pattern support for the following subformats: >> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is >> intended to

Re: RFR: 8325203: System.exit(0) kills the launched 3rd party application

2024-02-08 Thread Alexey Semenyuk
On Thu, 8 Feb 2024 20:57:51 GMT, Alexey Semenyuk wrote: > Tested with the use case from the CR. > > The idea of the fix is to prevent grandchildren processes from being > automatically attached to the job killing all processes attached to it when > the job object is destroyed. > > Filed a

RFR: 8325203: System.exit(0) kills the launched 3rd party application

2024-02-08 Thread Alexey Semenyuk
Tested with the use case from the CR. Filed a follow-up https://bugs.openjdk.org/browse/JDK-8325525 CR to track adding a jtreg test for the issue. - Commit messages: - 8325203: System.exit(0) kills the launched 3rd party application Changes:

Re: RFR: 8325506: Ensure randomness is only read from provided SecureRandom object

2024-02-08 Thread Kevin Driver
On Thu, 8 Feb 2024 16:34:00 GMT, Weijun Wang wrote: > Many crypto service classes require a `SecureRandom` object at > initialization. This test goes through each of them and calculates (generate, > encrypt, sign,...) twice with the same `SecureRandom` object and ensures the > output is the

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v6]

2024-02-08 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344) > which adds MessageFormat pattern support for the following subformats: > ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is > intended to provide pattern support for the more recently added JDK

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2024-02-08 Thread Vladimir Yaroslavskiy
On Thu, 8 Feb 2024 01:54:45 GMT, Srinivas Vamsi Parasa wrote: >> Hello Vamsi (@vamsi-parasa), >> >> Many thanks for the results! Now we can see that intrinsics are applied in >> all cases, >> but there are big differences between the same code. >> >> For example, >> parallelSort REPEATED

Re: RFR: 8325505: Fix Javadoc ResourceBundle::getString [v2]

2024-02-08 Thread Justin Lu
On Thu, 8 Feb 2024 17:31:15 GMT, Thiago Henrique Hüpner wrote: >> 8325505: Fix Javadoc ResourceBundle::getString > > Thiago Henrique Hüpner has updated the pull request incrementally with one > additional commit since the last revision: > > Apply changes from review Marked as reviewed by

Re: RFR: 8325505: Fix Javadoc ResourceBundle::getString [v2]

2024-02-08 Thread Naoto Sato
On Thu, 8 Feb 2024 17:31:15 GMT, Thiago Henrique Hüpner wrote: >> 8325505: Fix Javadoc ResourceBundle::getString > > Thiago Henrique Hüpner has updated the pull request incrementally with one > additional commit since the last revision: > > Apply changes from review LGTM -

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Magnus Ihse Bursie
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request

Re: RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment [v3]

2024-02-08 Thread Jorn Vernee
On Thu, 11 Jan 2024 16:21:38 GMT, Peter Levart wrote: >> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It >> returns `-1` (meaning that regions are equal) when passing the same instance >> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless

Re: RFR: 8325505: Fix Javadoc ResourceBundle::getString [v2]

2024-02-08 Thread Thiago Henrique Hüpner
> 8325505: Fix Javadoc ResourceBundle::getString Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Apply changes from review - Changes: - all: https://git.openjdk.org/jdk/pull/17346/files - new:

Re: RFR: 8325505: Fix Javadoc ResourceBundle::getString

2024-02-08 Thread Justin Lu
On Wed, 10 Jan 2024 12:35:56 GMT, Thiago Henrique Hüpner wrote: > 8325505: Fix Javadoc ResourceBundle::getString Thanks for the fix, looks correct. In addition to the other comment I left, can you also bump the latter copyright year at the top of the file to 2024.

Re: RFR: 8324573: HashMap::putAll should resize to sum of both map sizes [v4]

2024-02-08 Thread Joshua Cao
On Wed, 7 Feb 2024 20:50:57 GMT, Stuart Marks wrote: >> Joshua Cao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extract msize variable > > I think we should step back from benchmarks a bit and examine the various > tradeoffs

RFR: 8325506: Ensure randomness is only read from provided SecureRandom object

2024-02-08 Thread Weijun Wang
Many crypto service classes require a `SecureRandom` object at initialization. This test goes through each of them and calculates (generate, encrypt, sign,...) twice with the same `SecureRandom` object and ensures the output is the same. - Commit messages: - initial change

RFR: 8325505: Fix Javadoc ResourceBundle::getString

2024-02-08 Thread Thiago Henrique Hüpner
8325505: Fix Javadoc ResourceBundle::getString - Commit messages: - Fix Javadoc ResourceBundle::getString Changes: https://git.openjdk.org/jdk/pull/17346/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17346=00 Issue: https://bugs.openjdk.org/browse/JDK-8325505 Stats: 1

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Joachim Kern
On Thu, 8 Feb 2024 09:03:10 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Once more, remove AIX dirent64 et al defines > > And also `#define statvfs statvfs64` is not necessary with the

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Eirik Bjørsnøs
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Eirik Bjørsnøs
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a > small-sized ZIP64 ZIP file specifically created to reproduce the issue being > tested. > > The disk space requirement of this test is known to cause problems in some > builds, see

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Magnus Ihse Bursie
On Thu, 8 Feb 2024 09:03:10 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Once more, remove AIX dirent64 et al defines > > And also `#define statvfs statvfs64` is not necessary with the

RFR: 8325485: IncrementInstructions.of(int, int) is not storing the args

2024-02-08 Thread Adam Sotona
ClassFile API provides two sets of instructions implementations (bound and unbound). Unbound implementation of `IncrementInstruction::constant` returns invalid value. This bug discovered a hole in the ClassFile API test coverage. This patch provides very simple fix of `IncrementInstruction`

[jdk22] Integrated: 8325001: Typo in the javadocs for the Arena::ofShared method

2024-02-08 Thread Per Minborg
On Thu, 1 Feb 2024 12:07:52 GMT, Per Minborg wrote: > 8325001: Typo in the javadocs for the Arena::ofShared method This pull request has now been integrated. Changeset: 6d9a50ea Author:Per Minborg URL: https://git.openjdk.org/jdk22/commit/6d9a50ea148c1c37b9a1d0475d4aae78ea8f822b

Re: OpenJDK 17: Loitering AbstractQueuedSynchronizer$ConditionNode instances

2024-02-08 Thread Frank Kretschmer
Hello Thomas, hello Core-Libs-Dev, thank you for cc'ing my email. In deed my idea/suggestion is to modify the AbstractQueuedSynchronizer$ConditionNode handling in such a way that it gets unlinked from the chain of condition nodes if it is not needed any more (it might be the "nextWaiter" node),

Re: [jdk22] RFR: 8325001: Typo in the javadocs for the Arena::ofShared method

2024-02-08 Thread Maurizio Cimadamore
On Thu, 1 Feb 2024 12:07:52 GMT, Per Minborg wrote: > 8325001: Typo in the javadocs for the Arena::ofShared method Marked as reviewed by mcimadamore (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/100#pullrequestreview-1869843579

Integrated: 8323746: Add PathElement hashCode and equals

2024-02-08 Thread Per Minborg
On Wed, 31 Jan 2024 13:04:07 GMT, Per Minborg wrote: > This PR proposes to implement `hashCode()` and `equals()` methods for > implementations of `PathElement`. > > In doing so, the previous `PathElementImpl` was removed and replaced in favor > of distinct `record` implementations, each

Re: OpenJDK 17: Loitering AbstractQueuedSynchronizer$ConditionNode instances

2024-02-08 Thread Thomas Schatzl
Hi, since this looks like a suggestion for a change to the libraries similar to the mentioned JDK-6805775, and not actually GC, cc'ing the core-libs-dev mailing list. Hth, Thomas On 07.02.24 15:20, Frank Kretschmer wrote: Hi Java GC-experts, I'm facing an interesting G1 garbage

Re: RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v4]

2024-02-08 Thread Justin Lu
On Wed, 7 Feb 2024 15:18:09 GMT, Roger Riggs wrote: >> Would it work with custom implementations for say NumberFormat via the SPI? > > Just moving the if...then... else code to a package-private static method in > the respective XXFormat class would work the same. > I had not thought of an

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-08 Thread Matthias Baesken
On Tue, 6 Feb 2024 08:05:14 GMT, Matthias Baesken wrote: >>> I hope finally the AIX part of this PR is done. >> >> Thanks for the AIX related effort ; I put it again into our internal >> build/test queue. > >> >> Thanks for the AIX related effort ; I put it again into our internal >>

Integrated: 8325150: (tz) Update Timezone Data to 2024a

2024-02-08 Thread Johny Jose
On Wed, 7 Feb 2024 08:45:40 GMT, Johny Jose wrote: > Timezone data 2024a changes This pull request has now been integrated. Changeset: 917838e0 Author:Johny Jose Committer: Sean Coffey URL: https://git.openjdk.org/jdk/commit/917838e0a564b1f2cbfb6cc214ccbfd1a237019f Stats: 195

Re: RFR: 8323746: Add PathElement hashCode and equals [v2]

2024-02-08 Thread Per Minborg
On Sat, 3 Feb 2024 11:28:51 GMT, ExE Boss wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make all PathElements records > > src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 494: > >> 492:

Re: RFR: 8323746: Add PathElement hashCode and equals [v3]

2024-02-08 Thread Per Minborg
> This PR proposes to implement `hashCode()` and `equals()` methods for > implementations of `PathElement`. > > In doing so, the previous `PathElementImpl` was removed and replaced in favor > of distinct `record` implementations, each reflecting its own path element > selection type. This also

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Joachim Kern
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request

Re: RFR: JDK-8324930: java/lang/StringBuilder problem with concurrent jtreg runs

2024-02-08 Thread Matthias Baesken
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote: > On some Windows machines we see sometimes OOM errors because of high resource > (memory/swap) consumption. This is especially seen when the jtreg runs have > higher concurrency. A solution is to put the java/lang/StringBuilder tests