> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote:
>> As part of the ongoing effort to enable jcheck whitespace checking to all
>> text files, it is now time to address assembly (.S) files. The hotspot
>> assembly files were fixed as part of the hotspot mapfile removal, so only a
>>
On Tue, 12 Mar 2024 14:06:11 GMT, Aggelos Biboudis
wrote:
> In cases where the compiler needs to unbox a `long`, `float`, `double` and
> then run the exactness check, we were getting a crash. While the selector
> value is always boxed, the type (which controls the execution flow) was not,
>
On Thu, 14 Mar 2024 04:11:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8328066?
>
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
> the failure was observed on
On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Fri, 15 Mar 2024 11:30:08 GMT, Jaikiran Pai wrote:
> The reason why 2GB is needed in this test is explained in
> https://bugs.openjdk.org/browse/JDK-8285386.
ok thanks ... i'll re-read
-
PR Comment: https://git.openjdk.org/jdk/pull/18290#issuecomment-1999485205
On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Thu, 29 Feb 2024 09:45:35 GMT, Nizar Benalla wrote:
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class
`/covered`
-
PR Comment: https://git.openjdk.org/jdk/pull/18055#issuecomment-1988621229
I added `@since` tags for methods/constructors that do not match the `@since`
of the enclosing class
-
Commit messages:
- fix rest of private/public since tags
- fix PrintStream:write:(byte[]) since tag
- Merge branch 'openjdk:master' into add-missing-since-tags
- added missing
On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Thu, 14 Mar 2024 20:54:32 GMT, Mandy Chung wrote:
> > The updated patch uses a **build-only** `jlink` plugin, still called
> > `--create-linkable-runtime` which is _a)_ added only at build time with
> > `--add-modules` and _b)_ now generates the diff and prepares the image for
> > runtime
On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Thu, 14 Mar 2024 21:16:04 GMT, Erik Joelsson wrote:
> About the configure options,
>
> ```
> --enable-keep-packaged-modules
> enable keeping of packaged modules in jdk image
> [enabled]
> --enable-runtime-link-image
> enable producing
On Thu, 14 Mar 2024 21:59:54 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>>
On Wed, 13 Mar 2024 07:53:30 GMT, Christoph Langer wrote:
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument
On Wed, 13 Mar 2024 14:23:01 GMT, Raffaello Giulietti
wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Generate large strings in parameter generator methods
>
> I was thinking more something like
>
>
On Thu, 14 Mar 2024 17:35:22 GMT, Mandy Chung wrote:
> Trivial fix. Improve the error message to print the cause of the module
> resolution failure if present.
Tests that depend on exception messages can be problematic but this one is easy
to change if/when the exception message changes.
On Thu, 7 Mar 2024 17:37:59 GMT, Christoph Langer wrote:
> > > Thanks for exploring the possibility of improving tracebility of test
> > > invocations to reported bugs.
> > > >
> >
> >
> > I've given this test change a second thought, maybe you can try to separate
> > the test into two
19 matches
Mail list logo
