Re: RFR: 8360046: Scalability issue when submitting virtual threads with almost empty tasks [v7]

2025-09-06 Thread Doug Lea
> This set of updates reduces contention-based performance loss under heavy > over-subscription, while also improving perfomance more generally. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v12]

2025-09-06 Thread Roger Riggs
On Thu, 3 Jul 2025 09:53:30 GMT, Kieran Farrell wrote: >> src/java.base/share/classes/java/util/UUID.java line 212: >> >>> 210: * @since 26 >>> 211: */ >>> 212: public static UUID unixEpochTimeMillis() { >> >> Is there a list anywhere on the names that have been discussed already?

Re: Add Multipath TCP (MPTCP) Support to the Java Networking API

2025-09-06 Thread Geliang Tang
Hi Alan, Thanks for your reply. On Fri, 2025-09-05 at 10:28 +0100, Alan Bateman wrote: >   > On 05/09/2025 09:43, Geliang Tang wrote: >   >   > >   > > : > > > > 3. Proposed Java API Changes > > > > The goal is to allow Java applications to opt-in to using MPTCP > > when > > creating sockets, w

Re: RFR: 8364660: ClassVerifier::ends_in_athrow() should be removed [v2]

2025-09-06 Thread Chen Liang
On Thu, 4 Sep 2025 18:24:57 GMT, Matias Saavedra Silva wrote: >> The logic located in `ClassVerifier::ends_in_athrow()` is no longer required >> by the JVM Spec as of Java SE 22 (see JVMS 4.10) and the error cases should >> be handled by the stack map table and its rules for `uninitializedThis

Re: RFR: 8366588: VectorAPI: Re-intrinsify VectorMask.laneIsSet where the input index is a variable

2025-09-06 Thread Aleksey Shipilev
On Fri, 5 Sep 2025 08:13:28 GMT, erifan wrote: > Intrinsic support for `VectorMask.laneIsSet` with a **variable** input index > was introduced in PR #14200, but was inadvertently broken by PR #25673. This > PR restores the intrinsic functionality and adds some JTReg tests. > > Benchmarks on Nv

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v3]

2025-09-06 Thread Volkan Yazici
> [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused `tier1` > failures, and hence, backed out in [JDK-8366693] (#27050). This PR > reintroduces JDK-8356439 with sufficient fixes. > > [JDK-8356439]: https://bugs.openjdk.org/browse/JDK-8356439 > [JDK-8362893]: https://bugs.open

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v2]

2025-09-06 Thread Andrey Turbanov
On Thu, 4 Sep 2025 09:41:43 GMT, Volkan Yazici wrote: >> [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused >> `tier1` failures, and hence, backed out in [JDK-8366693] (#27050). This PR >> reintroduces JDK-8356439 with sufficient fixes. >> >> [JDK-8356439]: https://bugs.open

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread Chen Liang
On Sat, 6 Sep 2025 13:48:53 GMT, Francesco Andreuzzi wrote: >> In this PR I introduce some constants in `StackMapGenerator`. No change in >> logic is expected. >> >> Passes tests in `jdk/classfile`. > > Francesco Andreuzzi has updated the pull request incrementally with one > additional commit

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread duke
On Sat, 6 Sep 2025 13:48:53 GMT, Francesco Andreuzzi wrote: >> In this PR I introduce some constants in `StackMapGenerator`. No change in >> logic is expected. >> >> Passes tests in `jdk/classfile`. > > Francesco Andreuzzi has updated the pull request incrementally with one > additional commit

RFR: 8367027: java/lang/ProcessBuilder/Basic.java fails on Windows AArch64

2025-09-06 Thread Saint Wesonga
This test fails with errors like >'=C:=,=ExitValue=3,PROCESSOR_ARCHITECTURE=ARM64,SystemRoot=C:\Windows,'< not equal to '=C:=,=ExitValue=3,SystemRoot=C:\Windows,' The test does not expect the PROCESSOR_ARCHITECTURE variable to be returned from the ProcessBuilder (called at https://github.com/o

Re: RFR: 8360046: Scalability issue when submitting virtual threads with almost empty tasks [v6]

2025-09-06 Thread Doug Lea
> This set of updates reduces contention-based performance loss under heavy > over-subscription, while also improving perfomance more generally. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Refactor to improve locality and signalling

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread Chen Liang
On Sat, 6 Sep 2025 13:48:53 GMT, Francesco Andreuzzi wrote: >> In this PR I introduce some constants in `StackMapGenerator`. No change in >> logic is expected. >> >> Passes tests in `jdk/classfile`. > > Francesco Andreuzzi has updated the pull request incrementally with one > additional commit

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread Francesco Andreuzzi
On Sat, 6 Sep 2025 13:55:03 GMT, Chen Liang wrote: >> Francesco Andreuzzi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> inclusive > > Reviewer's note: This brings more parity with c++ verifier code as done in > JDK-8359920 (28e96e333b

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread Francesco Andreuzzi
On Sat, 6 Sep 2025 13:22:56 GMT, Chen Liang wrote: >> Francesco Andreuzzi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> inclusive > > src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java > line 188: > >> 186

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-06 Thread Francesco Andreuzzi
> In this PR I introduce some constants in `StackMapGenerator`. No change in > logic is expected. > > Passes tests in `jdk/classfile`. Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision: inclusive - Changes: - all

Re: RFR: 8354871: Replace stack map frame type magics with constants [v2]

2025-09-06 Thread Francesco Andreuzzi
> In this PR I introduce some constants in `StackMapGenerator`. No change in > logic is expected. > > Passes tests in `jdk/classfile`. Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review Co

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-06 Thread Magnus Ihse Bursie
On Fri, 5 Sep 2025 22:47:58 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.base/gensrc/GensrcBuffer.gmk line 162: >> >>> 160:$$(CAT) $$($1_BIN_SNIPPET_FILES) >> $$($1_REAL_OUTPUT).tmp >>> 161:$$(ECHO) "}" >> $$($1_REAL_OUTPUT).tmp >>> 162:$$(MV) $$($1_REAL_OUTPUT).tm

Re: RFR: 8354871: Replace stack map frame type magics with constants

2025-09-06 Thread Francesco Andreuzzi
On Mon, 1 Sep 2025 09:00:32 GMT, Francesco Andreuzzi wrote: > In this PR I introduce some constants in `StackMapGenerator`. No change in > logic is expected. > > Passes tests in `jdk/classfile`. Hi @liach, could you have a look at this PR since you opened the ticket? - PR Comment

Re: RFR: 8361950: Update to use jtreg 8 [v4]

2025-09-06 Thread Alan Bateman
On Sat, 6 Sep 2025 01:04:56 GMT, Chen Liang wrote: > #26749 was merged 4 days ago. Can we integrate this one now? I think it would be useful to get input from @dholmes-ora and @lkorinth before doing this. There seems to be several timeout issues in the last few days, a few follow-on changes t