Re: RFR: 8360025: (se) Convert kqueue Selector Implementation to use FFM APIs [v4]

2025-09-07 Thread Alan Bateman
On Wed, 3 Sep 2025 12:08:49 GMT, Darragh Clarke wrote: > So I double checked the changes made there and wrote this up, I can make it > more precise or change wording if its going to be attached to a file. Package > info currently contains the script used to generate the code > > **Common chang

Re: RFR: 8361950: Update to use jtreg 8 [v4]

2025-09-07 Thread David Holmes
On Thu, 4 Sep 2025 22:01:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 8. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the requiredVersi

Re: RFR: 8328874: Class::forName0 should validate the class name length early [v12]

2025-09-07 Thread Guanqiang Han
On Wed, 3 Sep 2025 18:40:26 GMT, Roger Riggs wrote: >> Guanqiang Han has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Class.java >> >> change overflow check > >> /reviewers 2 reviewer >> >> I recommend putting this PR on hold

Re: RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v4]

2025-09-07 Thread Shaojin Wen
> This PR introduces a new efficient API for appending two-digit integers to > StringBuilders and refactors DateTimeHelper to leverage this new > functionality. > > Changes include: > > 1. New `appendPair` method for efficient two-digit integer formatting (00-99): >- Added `AbstractStringBu

Re: RFR: 8366588: VectorAPI: Re-intrinsify VectorMask.laneIsSet where the input index is a variable

2025-09-07 Thread erifan
On Fri, 5 Sep 2025 10:12:35 GMT, Aleksey Shipilev wrote: >> Intrinsic support for `VectorMask.laneIsSet` with a **variable** input index >> was introduced in PR #14200, but was inadvertently broken by PR #25673. This >> PR restores the intrinsic functionality and adds some JTReg tests. >> >> B

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-07 Thread Chen Liang
On Sat, 6 Sep 2025 13:48:53 GMT, Francesco Andreuzzi wrote: >> In this PR I introduce some constants in `StackMapGenerator`. No change in >> logic is expected. >> >> Passes tests in `jdk/classfile`. > > Francesco Andreuzzi has updated the pull request incrementally with one > additional commit

Integrated: 8354871: Replace stack map frame type magics with constants

2025-09-07 Thread Francesco Andreuzzi
On Mon, 1 Sep 2025 09:00:32 GMT, Francesco Andreuzzi wrote: > In this PR I introduce some constants in `StackMapGenerator`. No change in > logic is expected. > > Passes tests in `jdk/classfile`. This pull request has now been integrated. Changeset: 8a6b8751 Author:Francesco Andreuzzi Com

Integrated: 8361533: Apply java.io.Serial annotations in java.logging

2025-09-07 Thread Sergey Bylokhov
On Wed, 9 Jul 2025 02:58:28 GMT, Sergey Bylokhov wrote: > Please review the application of the `@Serial` annotation > ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the > java.logging module to enable stricter compile-time checking of > serialization-related declarati

Re: RFR: 8360046: Scalability issue when submitting virtual threads with almost empty tasks [v8]

2025-09-07 Thread Doug Lea
> This set of updates reduces contention-based performance loss under heavy > over-subscription, while also improving perfomance more generally. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: revive topLevelExec, adjust occrdingly; smal

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v2]

2025-09-07 Thread Volkan Yazici
On Thu, 4 Sep 2025 09:45:57 GMT, Andrey Turbanov wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve docs > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 344: > >> 342: * @re

Re: Duration.MAX_VALUE

2025-09-07 Thread Pavel Rappo
This is useful; thanks. It would be good to see more of your data. My use case is also duration which practically means **forever**. I pass it to methods that accept timeouts, and expect these methods to correctly interpret it. One example of a practical interpretation is java.util.concurrent.Tim

Re: RFR: 8366854: Extend jtreg failure handler with THP info [v2]

2025-09-07 Thread Stefan Karlsson
> I propose that we also dump /proc/meminfo, /proc/vmstat, and > /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure > handler. > > This information has been helpful when investigating a failure where there > was an unexpected lack of transparent huge pages. Stefan Karlsson

Re: RFR: 8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64

2025-09-07 Thread Aleksey Shipilev
On Thu, 4 Sep 2025 15:47:33 GMT, Aleksey Shipilev wrote: > GetStackTraceALotWhenPinned test times out every so often in GHA. > > The last sightings are on macos-aarch64: > > > 2025-09-04T10:41:29.357879Z => 87894 of 10 > 2025-09-04T10:41:30.365534Z => 88105 of 10 > Timeout signalled af

Re: RFR: 8366854: Extend jtreg failure handler with THP info [v2]

2025-09-07 Thread Aleksey Shipilev
On Thu, 4 Sep 2025 07:49:56 GMT, Stefan Karlsson wrote: >> I propose that we also dump /proc/meminfo, /proc/vmstat, and >> /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure >> handler. >> >> This information has been helpful when investigating a failure where there >> was

RFR: 8366854: Extend jtreg failure handler with THP info

2025-09-07 Thread Stefan Karlsson
I propose that we also dump /proc/meminfo, /proc/vmstat, and /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure handler. This information has been helpful when investigating a failure where there was an unexpected lack of transparent huge pages. - Commit message

Re: Excessive copying of Collection.toArray()

2025-09-07 Thread Stuart Marks
There have been previous attempts to reduce copying here and there, but they do suffer from the problems you have described. See https://github.com/openjdk/jdk/pull/12212 That's a valuable link. It touches on the same problem and potential solutions. It's a shame it was abandoned. This sup

Re: RFR: 8365428: Unclear comments on java.lang.invoke Holder classes [v4]

2025-09-07 Thread Ioi Lam
On Fri, 5 Sep 2025 00:00:34 GMT, Chen Liang wrote: >> java.lang.invoke has a few Holder classes in DirectMethodHandle, >> DelegatingMethodHandle, Invokers, and LambdaForm. >> >> Currently, the comments simply refer to "Placeholder for xxx generated >> ahead-of-time". >> >> However, they carry

Re: RFR: 8366854: Extend jtreg failure handler with THP info [v2]

2025-09-07 Thread Thomas Schatzl
On Thu, 4 Sep 2025 07:49:56 GMT, Stefan Karlsson wrote: >> I propose that we also dump /proc/meminfo, /proc/vmstat, and >> /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure >> handler. >> >> This information has been helpful when investigating a failure where there >> was

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods

2025-09-07 Thread Andrey Turbanov
On Thu, 4 Sep 2025 06:36:20 GMT, Volkan Yazici wrote: > [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused `tier1` > failures, and hence, backed out in [JDK-8366693] (#27050). This PR > reintroduces JDK-8356439 with sufficient fixes. > > [JDK-8356439]: https://bugs.openjdk.o

Re: RFR: 8328874: Class::forName0 should validate the class name length early [v15]

2025-09-07 Thread Guanqiang Han
> Validate class name length immediately after GetStringUTFLength() in > Class.forName0. This prevents potential issues caused by overly long class > names before they reach later code that would reject them, throwing > ClassNotFoundException early. Guanqiang Han has updated the pull request in

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-07 Thread Chen Liang
On Tue, 2 Sep 2025 22:20:26 GMT, Chen Liang wrote: >> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird >> state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, >> run it as a main class, and paste the generated VarHandleGuards class. >> >> This p

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-07 Thread Paul Sandoz
On Tue, 2 Sep 2025 22:20:26 GMT, Chen Liang wrote: >> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird >> state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, >> run it as a main class, and paste the generated VarHandleGuards class. >> >> This p

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v3]

2025-09-07 Thread Roger Riggs
On Thu, 4 Sep 2025 11:22:31 GMT, Volkan Yazici wrote: >> [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused >> `tier1` failures, and hence, backed out in [JDK-8366693] (#27050). This PR >> reintroduces JDK-8356439 with sufficient fixes. >> >> [JDK-8356439]: https://bugs.open

Re: RFR: 8361207: Build native Windows ARM64 MSI packages

2025-09-07 Thread Alexey Semenyuk
On Wed, 2 Jul 2025 11:15:00 GMT, Armin Schrenk wrote: > Add support for native ARM64 Windows MSI pacakges to jpackage. > > For some reasoning and more info, check out the ticket on JBS: > https://bugs.openjdk.org/browse/JDK-8361207. Changes requested by asemenyuk (Reviewer). src/jdk.jpackage/

Re: RFR: 8366854: Extend jtreg failure handler with THP info [v2]

2025-09-07 Thread Leonid Mesnik
On Thu, 4 Sep 2025 07:49:56 GMT, Stefan Karlsson wrote: >> I propose that we also dump /proc/meminfo, /proc/vmstat, and >> /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure >> handler. >> >> This information has been helpful when investigating a failure where there >> was

Re: Add Multipath TCP (MPTCP) Support to the Java Networking API

2025-09-07 Thread Alan Bateman
On 05/09/2025 09:43, Geliang Tang wrote: : 3. Proposed Java API Changes The goal is to allow Java applications to opt-in to using MPTCP when creating sockets, without breaking existing code. The proposed changes are additive and backward-compatible. The core idea is to add a boolean mptcp para

Re: RFR: 8328874: Class::forName0 should validate the class name length early [v14]

2025-09-07 Thread ExE Boss
On Sun, 7 Sep 2025 09:03:56 GMT, Guanqiang Han wrote: >> Validate class name length immediately after GetStringUTFLength() in >> Class.forName0. This prevents potential issues caused by overly long class >> names before they reach later code that would reject them, throwing >> ClassNotFoundExc

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-07 Thread Magnus Ihse Bursie
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote: > Several java classes in java.base is generated from templates using SPP, the > "Stream Preprocessor". Unfortunately much of this code is very old and has > survived unchanged since pre-JDK 7. It does not follow modern makefile > stan

Re: RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v2]

2025-09-07 Thread Volkan Yazici
On Thu, 4 Sep 2025 09:01:25 GMT, Andrey Turbanov wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve docs > > src/java.base/share/classes/java/lang/String.java line 691: > >> 689: } >> 690: >> 691: /

Re: RFR: 8354871: Replace stack map frame type magics with constants [v3]

2025-09-07 Thread Chen Liang
On Sat, 6 Sep 2025 13:48:53 GMT, Francesco Andreuzzi wrote: >> In this PR I introduce some constants in `StackMapGenerator`. No change in >> logic is expected. >> >> Passes tests in `jdk/classfile`. > > Francesco Andreuzzi has updated the pull request incrementally with one > additional commit

Re: RFR: 8328874: Class::forName0 should validate the class name length early [v13]

2025-09-07 Thread Guanqiang Han
> Validate class name length immediately after GetStringUTFLength() in > Class.forName0. This prevents potential issues caused by overly long class > names before they reach later code that would reject them, throwing > ClassNotFoundException early. Guanqiang Han has updated the pull request wi

Re: RFR: 8354871: Replace stack map frame type magics with constants

2025-09-07 Thread Chen Liang
On Mon, 1 Sep 2025 09:00:32 GMT, Francesco Andreuzzi wrote: > In this PR I introduce some constants in `StackMapGenerator`. No change in > logic is expected. > > Passes tests in `jdk/classfile`. Thanks for pinging me. This must have got forgotten in the stream of emails. src/java.base/share/c

Re: RFR: 8328874: Class::forName0 should validate the class name length early [v14]

2025-09-07 Thread Guanqiang Han
> Validate class name length immediately after GetStringUTFLength() in > Class.forName0. This prevents potential issues caused by overly long class > names before they reach later code that would reject them, throwing > ClassNotFoundException early. Guanqiang Han has updated the pull request wi