Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Athijegannathan Sundararajan
On Wed, 24 Jan 2024 06:50:36 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. >> The test is currently implemented using a mix of shell script and a Java >> main method. >> >> Reviewers may notice the following changes: >> >> - The

[jdk22] Integrated: 8310995: missing @since tags in 36 jdk.dynalink classes

2024-01-10 Thread Athijegannathan Sundararajan
On Wed, 10 Jan 2024 06:32:54 GMT, Athijegannathan Sundararajan wrote: > backported from jdk mainline "as is" without any modifications. This pull request has now been integrated. Changeset: 33f07b56 Author:Athijegannathan Sundararajan URL: https://git.openjdk.org

[jdk22] RFR: 8310995: missing @since tags in 36 jdk.dynalink classes

2024-01-09 Thread Athijegannathan Sundararajan
backported from jdk mainline "as is" without any modifications. - Commit messages: - Backport 176606d0cb9117ca9080261f898cd57339fa5a85 Changes: https://git.openjdk.org/jdk22/pull/49/files Webrev: https://webrevs.openjdk.org/?repo=jdk22=49=00 Issue:

Integrated: 8310995: missing @since tags in 36 jdk.dynalink classes

2024-01-08 Thread Athijegannathan Sundararajan
On Mon, 8 Jan 2024 13:24:55 GMT, Athijegannathan Sundararajan wrote: > Adding missing "@ since 9" in javadoc comment of the public classes, > interfaces and packages of the jdk.dynalink module. This pull request has now been integrated. Changeset: 176606d0 Author:

RFR: 8310995: missing @since tags in 36 jdk.dynalink classes

2024-01-08 Thread Athijegannathan Sundararajan
Adding missing "@ since 9" in javadoc comment of the public classes, interfaces and packages of the jdk.dynalink module. - Commit messages: - 8310995: missing @since tags in 36 jdk.dynalink classes Changes: https://git.openjdk.org/jdk/pull/17305/files Webrev:

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Athijegannathan Sundararajan
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a

Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v39]

2022-12-05 Thread Athijegannathan Sundararajan
On Mon, 5 Dec 2022 10:31:52 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-434 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations

2022-11-14 Thread Athijegannathan Sundararajan
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8292317? > > The `java.util.Iterator` has a `forEachRemaining(Consumer action)` > method. As per its contract, the implementations are

Re: RFR: JDK-8293892: Add links to JVMS 19 and 20 from ClassFileFormatVersion enum constants

2022-09-15 Thread Athijegannathan Sundararajan
On Fri, 16 Sep 2022 02:59:32 GMT, Joe Darcy wrote: > Analogous fix to one already done for javax.lang.model.SourceVersion > (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but > redirect to the spec language page > > https://docs.oracle.com/javase/specs/index.html > > The

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-23 Thread Athijegannathan Sundararajan
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a