On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19366#pullrequestreview-2074232921
On Mon, 20 May 2024 22:42:20 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 11 commits:
>
> - Fix-up test.
> - Merge branch 'master' into JDK-8330188
> - Adjust test
On Fri, 17 May 2024 18:04:02 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-05-16. Locale tests pass as expected after update.
>
> Associated announcement ->
>
On Thu, 9 May 2024 00:49:43 GMT, xiaotaonan wrote:
> …ersion
>
> Release Note: System Property for Java SE Specification Maintenance Version
This system property should not be set for a feature release. It should only
be set if there has been a JCP Maintenance Release. Perhaps this PR
On Mon, 29 Apr 2024 22:50:26 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains seven
On Wed, 24 Apr 2024 08:54:53 GMT, Jin Kwon wrote:
>> Fix typos within the `DatabaseMetaData.java`.
>
> Jin Kwon has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8330686: Fix typos in the DatabaseMetaData javadoc
>
> Reviewed-by: jpai
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote:
> 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007547483
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Correct release date as observed in review feedback.
> - Improve javadoc of class file update.
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
Marked as reviewed by iris
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18788#pullrequestreview-2002041316
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
The copyright year was not updated in all files *14.java. I assume that's
intentional.
I've also Reviewed the associated CSRs.
make/conf/version-numbers.conf line 36:
> 34: DEFAULT_VERSION_EXTRA2=0
> 35:
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
I like the new switch!
-
Marked as reviewed by iris (Reviewer).
PR Review:
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
Marked as
On Wed, 27 Mar 2024 19:58:17 GMT, Naoto Sato wrote:
> Clarifying the behavior for non-ASCII digits in Double/Float.valueOf(String)
> method descriptions. A draft CSR has also been created.
Associated CSR also Reviewed. I like the relocation of existing text to the
more appropriate
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955535154
On Wed, 13 Mar 2024 20:10:25 GMT, Roger Riggs wrote:
>> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
>> assumption about GC behavior and a race condition.
>>
>> Removed test based on incorrect assumptions about simultaneous clearing of
>> WeakReferences.
>>
On Wed, 13 Mar 2024 18:01:21 GMT, Roger Riggs wrote:
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
> assumption about GC behavior and a race condition.
>
> Removed test based on incorrect assumptions about simultaneous clearing of
> WeakReferences.
> Added a
On Wed, 13 Mar 2024 16:06:26 GMT, Naoto Sato wrote:
>> Adding a table that maps JDK versions and corresponding CLDR releases as an
>> implNote. A draft CSR has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 12 Mar 2024 18:50:38 GMT, Naoto Sato wrote:
>> Adding a table that maps JDK versions and corresponding CLDR releases as an
>> implNote. A draft CSR has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato wrote:
>> Removing left over "applet" mention in the package-info doc.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing review comments
Marked as reviewed by iris
On Thu, 7 Mar 2024 23:31:46 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-03-07. Tests pass as expected after update.
>
> Associated announcement ->
>
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925813600
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18158#pullrequestreview-1923843891
On Wed, 6 Mar 2024 21:32:11 GMT, Naoto Sato wrote:
> Fixing timeout failures in the test case. Time zone names that are missing
> (chiefly for minor locales) are now calculated at runtime after the fix to
> JDK-8174269. This extra calculation time was multiplied in the test case as
> it
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which suggests we remove the package-private,
> unused and deprecated method `java.util.jar.Manifest.make72Safe`.
>
> This method was marked deprecated after a cleanup/refactoring in
>
On Tue, 20 Feb 2024 19:56:53 GMT, Lance Andersen wrote:
> Please review the updates to open/src/java.base/share/legal/zlib.md to update
> the file from zlib 1.2.13 to zlib 1.3.1 which was missed as part of the PR
> for [JDK-8324632](https://bugs.openjdk.org/browse/JDK-8324632)
Marked as
On Tue, 20 Feb 2024 18:34:59 GMT, Naoto Sato wrote:
> Fixing a typo in the said method.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17933#pullrequestreview-1891250872
Vote: yes
Iris
On Wed, 7 Feb 2024 08:45:40 GMT, Johny Jose wrote:
> Timezone data 2024a changes
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17743#pullrequestreview-1868554271
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote:
> This update drops the "ea" from the version string.
>
> We also propagate the following fixes from the markdown sources to the troff
> manpage file:
>
> JDK-8322478: Update java manpage for multi-file source-code launcher
> JDK-8302233:
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which improves test coverage of
> `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i"
> characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java`
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked
> fine and the generated javadoc looks fine.
Marked as reviewed by iris (Reviewer).
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> There are a [small number of
On Mon, 22 Jan 2024 20:52:32 GMT, Roger Riggs wrote:
> When an exception handler for an OutOfMemoryError uses string concatenation
> to compose an exception message, the invoke dynamic string format
> implementation may itself exhaust memory, preventing the exception from being
> handled.
>
On Tue, 23 Jan 2024 18:40:42 GMT, Justin Lu wrote:
> Please review this PR which clarifies some confusion for the digit getter and
> setter methods of DecimalFormat.
>
> When formatting non `BigInteger` and `BigDecimal` values, DecimalFormat uses
> 309/340 as hard limits for integer and
On Thu, 18 Jan 2024 21:02:26 GMT, Naoto Sato wrote:
>> Fixing incorrect std/dst transitions for time zones that have rules beyond
>> 2037. The year 2037 restriction seems to come from the old `zic` command
>> implementation and thus can be expanded in the JDK. Arbitrary I chose 2100
>> which
On Thu, 18 Jan 2024 19:37:33 GMT, Naoto Sato wrote:
> Fixing incorrect std/dst transitions for time zones that have rules beyond
> 2037. The year 2037 restriction seems to come from the old `zic` command
> implementation and thus can be expanded in the JDK. Arbitrary I chose 2100
> which is
On Fri, 12 Jan 2024 18:25:25 GMT, Justin Lu wrote:
> Please review this PR which is a backport of commit
> [4ea7b364](https://github.com/openjdk/jdk/commit/4ea7b36447ea96d62b1ca164c34e2b2b74a16579)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The original commit was a
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote:
> Backport to fix the regression introduced in JDK 22.
Verified changes same as those in main-line.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817021441
On Wed, 10 Jan 2024 20:56:14 GMT, Naoto Sato wrote:
> Backporting the document only fix to jdk22
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/59#pullrequestreview-1814223539
On Tue, 9 Jan 2024 23:55:30 GMT, Naoto Sato wrote:
> Backporting the document clarification to JDK22
Confirmed that this change corresponds to the changes in main-line and the
previously approved CSR.
-
Marked as reviewed by iris (Reviewer).
PR Review:
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk)
On Tue, 9 Jan 2024 00:51:28 GMT, Naoto Sato wrote:
> Adding an explanation of the locale-related system properties in the
> `System.getProperties()` method. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/lang/System.java line 818:
> 816: * {@link
On Fri, 5 Jan 2024 17:05:04 GMT, Dan Lutker wrote:
> Clean backport tzdata 2023d.
> `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test
> test/jdk/sun/util/resources test/jdk/sun/text/resources
> test/jdk/sun/util/calendar"` is all passing
Marked as reviewed by iris
On Mon, 8 Jan 2024 13:24:55 GMT, Athijegannathan Sundararajan
wrote:
> Adding missing "@ since 9" in javadoc comment of the public classes,
> interfaces and packages of the jdk.dynalink module.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Thu, 4 Jan 2024 19:09:34 GMT, Joe Wang wrote:
> backport of PR: https://github.com/openjdk/jdk/pull/17252
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/32#pullrequestreview-1804849821
On Fri, 22 Dec 2023 18:59:20 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979), where the parsing
> of TZDB files was incorrect. With this fix, `TimeZoneNames_en.java` which is
> generated during the build time has
On Mon, 18 Dec 2023 11:56:50 GMT, Aleksei Voitylov
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [fde5b168](https://github.com/openjdk/jdk/commit/fde5b16817c3263236993f2e8c2d2469610d99bd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780486241
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Tue, 5 Dec 2023 01:48:14 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 15 commits:
>
> - Merge branch 'master' into JDK-8319413
> - Add
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update symbol files to JDK 22 b26.
>
> test/langtools/tools/javac/versions/Versions.java line 97:
>
>> 95:
On Fri, 1 Dec 2023 21:24:47 GMT, Naoto Sato wrote:
>> This is the fix to JLine, which makes it on par with the built-in Console
>> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato wrote:
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
Marked as reviewed by iris (Reviewer).
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' into JDK-8319413
> -
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1754401831
On Tue, 28 Nov 2023 21:36:20 GMT, Joe Wang wrote:
>> Fix errors in the built-in Catalog implementation, specifically:
>> -- incorrect case in the property name as defined in the CSR
>> (https://bugs.openjdk.org/browse/JDK-8306056)
>> -- tests needed to be updated accordingly
>> --
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote:
> Time to start making preparations for JDK 23.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1751551968
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote:
> Applying an update from the upstream source, quote: "Removing synchronized
> from the getInstance() methods". As the reporter noted, this change was made
> 16 years ago.
>
> Tests: SQE & unit tests passed
Verified `synchronized` keyword
On Mon, 20 Nov 2023 19:48:20 GMT, Alan Bateman wrote:
> This API is sitting out JDK 22, meaning no API/implementation changes in this
> PR. We expect this API to do a third preview in JDK 23 with some API changes.
>
> So for now, we just need to bump JEP number/title that shows up in the
>
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733201186
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote:
>> Correcting the explanation of the `DateFormat.SHORT` constant.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> abbreviated/full clarification
Marked as reviewed by iris
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote:
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16532#pullrequestreview-1716553613
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote:
> Please review this simple change which refines the specification of some
> NumberFormat methods (with unsupported operations) to separate the API and
> implementation specification.
Marked as reviewed by iris (Reviewer).
-
PR
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote:
>> Spec clarification of `ListFormat.equals()` method, utilizing newly
>> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also
>> been drafted.
>
> Naoto Sato has updated the pull request incrementally with one
On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote:
> Proposing adding getter methods for `locale` and `patterns` fields in the
> `ListFormat` instances. Those fields are used for `equals()`, but without the
> public getter methods, users cannot tell the reasoning of the equality of two
>
On Wed, 18 Oct 2023 15:32:34 GMT, Maurizio Cimadamore
wrote:
> This PR updates the man pages for `javac` and `java` to document:
> * the new `javac` warning for restricted methods (`-Xlint:restricted`)
> * the `java` option to allow access to restricted methods without warnings
>
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
Marked as reviewed by iris (Reviewer).
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote:
> The open nroff manpage files are out of sync with their closed markdown
> sources and need to be refreshed.
>
> The changes to apply are coming from:
>
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> to
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to `IllegalFormatException`
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16140#pullrequestreview-1672411158
On Thu, 5 Oct 2023 20:02:44 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote:
> Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument
> on calling `ListFormat::parseObject()`. A corresponding CSR has also been
> drafted.
Documents existing behaviour. Associated CSR also Reviewed.
-
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those time zones are
> the
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote:
>> Remove unused imports in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by iris (Reviewer).
On Wed, 27 Sep 2023 17:29:29 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new internal annotation that is used to mark all
>> restricted me
>> thods in the FFM API. The new annotation is similar to the one we used for
>> preview API methods.
>>
>> We plan to use the new annotation
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15667#pullrequestreview-1620730522
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote:
> There are several methods defined by sun.misc.Unsafe that have standard API
> equivalents for many years and releases. The change proposed here is to
> deprecate, for removal, the park, unpark, getLoadAverage, loadFence,
> storeFence, and
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote:
>> In the JDK build we have various build tools that generate source code from
>> data files. For most of these tools, the source files are based on template
>> files, which already have copyright headers, but for some, the complete
>>
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.3,1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the
On Mon, 14 Aug 2023 12:47:46 GMT, Dmitry Cherepanov
wrote:
> The PR suggests updating copyright headers in two files so that they are the
> same as in other files.
The updated license appears to match the expected license:
On Thu, 3 Aug 2023 16:31:01 GMT, Justin Lu wrote:
> Please review this PR which updates the IANA data from version 05-11-2023 to
> version
> [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html).
>
> The contents of the update added variant subtag
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote:
> Please review a patch that add `@since` tags following existing convention
> for XML APIs in java.xml and jdk.xml.dom modules.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote:
> Please review this PR (L10N translation update), which is a backport of
> commit
> [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
Added @since tags follow existing convention for XML APIs in java.xml and
jdk.xml.dom modules.
-
Marked as reviewed by iris (Reviewer).
PR Review:
On Mon, 31 Jul 2023 21:13:16 GMT, Justin Lu wrote:
> Please review this change which contains a backport of commit
> [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This PR is a
Vote: yes
Thanks,
Iris
Vote: yes
Thanks,
Iris
Vote: yes
Thanks,
Iris
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote:
> Main changes are to use 21 instead of 21-ea. In addition the following files
> contain additional updates from the closed sources:
>
> - src/java.base/share/man/java.1
>
> [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131):
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote:
> Please review this PR which backports
> https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d
>
> Thank you
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Tue, 11 Jul 2023 17:21:13 GMT, Alan Bateman wrote:
> Clean backport of https://git.openjdk.org/jdk/pull/14679
Same as 22.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk21/pull/113#pullrequestreview-1524839981
1 - 100 of 206 matches
Mail list logo
