On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780488559
ned in the standard
cited by the package info page, so I don’t see the harm in making it accessible
without interpretation.
Alan
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Networ
On Tue, 12 Dec 2023 11:59:36 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which adds validation of incorrect LOC signatures in
>> `ZipFileSystem`.
>>
>> `ZipFile` already rejects the case where the offset pointed to from the CEN
>> header does not start with the expected LOC
On Mon, 11 Dec 2023 15:38:28 GMT, Eirik Bjorsnos wrote:
> Please review this PR which adds validation of incorrect LOC signatures in
> `ZipFileSystem`.
>
> `ZipFile` already rejects the case where the offset pointed to from the CEN
> header does not start with the expected LOC signature. It
On Mon, 11 Dec 2023 17:22:14 GMT, Eirik Bjorsnos wrote:
> > One quick comment, if we are updating this test, we should look to get rid
> > of input.zip
>
> I started going down that road, but felt uneasy about the amount of unrelated
> changes in a single PR. I'd like to make efficient use of
On Fri, 8 Dec 2023 20:28:20 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we rewrite the
> `../zip/ZipFile/ReadZip.java` test to JUnit.
>
> The current test is a single main method with a sequence of fairly unrelated
> scenarios. It would benefit from a rewrite to
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP
On Tue, 5 Dec 2023 15:58:14 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we retire the ZIP test
> `NoExtensionSignature` along with its `test.jar` test vector.
>
> The concern of a missing data descriptor signature is covered by the recently
> updated
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjorsnos wrote:
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name
On Fri, 1 Dec 2023 08:49:34 GMT, Alan Bateman wrote:
>> Thanks Jai, that makes sense. Replaced full path with just the base name in
>> latest commit.
>
> I think the second paragraph of the method description is problematic.
> Documenting the representation and then saying it is subject to
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1755023783
On Tue, 28 Nov 2023 20:49:38 GMT, Justin Lu wrote:
>> Please review this PR which converts the shell test,
>> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from
>> _PropertiesTest.java_. It tests both the ways to
On Tue, 28 Nov 2023 20:11:42 GMT, Joe Wang wrote:
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> --
On Thu, 16 Nov 2023 20:52:08 GMT, Eirik Bjorsnos wrote:
> > Regarding you comment about checking whether or not to check if the
> > combined length of the CEN header + name length + comment length + extra
> > length > 65K bytes, I chose to add this given the strong wording given this
> > is a
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by lancea
On Wed, 15 Nov 2023 20:10:53 GMT, Eirik Bjorsnos wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
ink the question is whether it's worth the disruption, is your motivation to
cleanup this area or something stronger?
-Alan
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burl
On Mon, 27 Nov 2023 21:12:17 GMT, Justin Lu wrote:
>> Please review this PR which fixes timeouts for the two tests:
>> _java/util/Locale/LocaleProvidersRun.java_ and
>> _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_.
>>
>> These tests were updated to accept VM flags in
>>
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote:
> Applying an update from the upstream source, quote: "Removing synchronized
> from the getInstance() methods". As the reporter noted, this change was made
> 16 years ago.
>
> Tests: SQE & unit tests passed
This looks OK.
Please add a the
On Mon, 27 Nov 2023 16:17:14 GMT, Eirik Bjorsnos wrote:
> Please review this trivial, formatting and documentation-only change which
> adds missing whitespace around a few `if` statements, `while` statements and
> assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`.
>
>
On Mon, 20 Nov 2023 19:15:18 GMT, Justin Lu wrote:
>> Please review this PR which allows these _j.util_ tests to launch new JVM
>> processes with VM flags,
>>
>> This is primarily done using by switching to
>> `ProcessTools::createTestJavaProcessBuilder`.
>
> Justin Lu has updated the pull
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
Thank you Joe.
All good by me and Congrats on moving this across
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Hi Joe,
Thank you for all
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733121214
On Wed, 15 Nov 2023 20:13:15 GMT, Eirik Bjorsnos wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 581:
>>
>>> 579: if ((flag & 8) == 8) {
>>> 580: /* "Data Descriptor" present */
>>> 581: if (hasZip64Extra(e) ||
>>
>> You probably
On Wed, 15 Nov 2023 19:26:06 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote:
>> Correcting the explanation of the `DateFormat.SHORT` constant.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> abbreviated/full clarification
Marked as reviewed by
On Wed, 8 Nov 2023 13:45:14 GMT, Eirik Bjorsnos wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
On Wed, 8 Nov 2023 20:26:32 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which enhances the existing CEN header validation
>> checking to ensure that the
>> size of the CEN Header + name length + comment length + extra length do not
>> exceed 65,535 bytes per the PKWare APP.NOTE
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the Islamic Calendar to
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
Marked as
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Fri, 3 Nov 2023 20:01:44 GMT, Eirik Bjorsnos wrote:
> > I can kick of a test run internally next week or perhaps Sunday
>
> Thanks for your reviews, Lance and Iris!
>
> FWIW, the test ran fine on Github Actions, including on `linux-x86` (which is
> 32-bit, right?):
>
> ```
> TEST:
On Wed, 8 Nov 2023 13:54:23 GMT, Eirik Bjorsnos wrote:
> > > > I think the changes look good overall. Thank you for this. I am not
> > > > sure that the `@requires` is needed at this point.
> > >
> > >
> > > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the
> > > 8GB
Please review this PR which enhances the existing CEN header validation
checking to ensure that the
size of the CEN Header + name length + comment length + extra length do not
exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12. Also
check that current CEN header will not
On Wed, 8 Nov 2023 16:27:56 GMT, Eirik Bjorsnos wrote:
> @LanceAndersen
>
> I noticed that this PR did not update `ZipInputStream.readLOC` to perform
> consistency validation between expected and actual extra field size and
> values. Any particular reason why processing of LOC headers was not
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote:
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number i
On Tue, 7 Nov 2023 05:43:06 GMT, Joe Wang wrote:
>> Xalan 2.7.3: merge minor changes from the upstream project.
>>
>> Test: existing XML tests pass
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove commented out block in
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote:
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java
line 104:
> 102:
>
On Mon, 6 Nov 2023 11:28:23 GMT, Ryan Wallace wrote:
> I had a look and its been in since JDK 9
> (https://bugs.openjdk.org/browse/JDK-8158295) but haven’t found any mention
> of this as a specific desired behaviour so I am going with just noticed now.
> Its not a major blocker as the user
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
On Mon, 30 Oct 2023 17:57:23 GMT, Eirik Bjorsnos wrote:
>> This way of updating the copyright was suggested by @jaikiran in the March
>> 10th comment above. Would be nice to get this clarified, yes.
>
> There is actually very little left of Martin's code after my rewrite, besides
> whitespace,
On Thu, 2 Nov 2023 18:21:07 GMT, Eirik Bjorsnos wrote:
> > Thinking some more about this, I would like to see us keep the Zip
> > generated by python, store it in a byte array (or equivalent) as it also
> > validate that we can still process the zip given this was the original test
> > and
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional
On Mon, 13 Mar 2023 03:18:26 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/CenSizeTooLarge.java line 53:
>>
>>> 51:
>>> 52: // Maximum size (unsigned short) of an extra field allowed by the
>>> standard
>>> 53: static final int MAX_EXTRA_FIELD_SIZE = 0X;
>>
>>
On Mon, 30 Oct 2023 12:13:59 GMT, Eirik Bjorsnos wrote:
> > I think the changes look good overall. Thank you for this. I am not sure
> > that the `@requires` is needed at this point.
>
> Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB
> memory requirement? If so, I
On Mon, 30 Oct 2023 11:57:09 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Sat, 28 Oct 2023 17:08:07 GMT, Eirik Bjorsnos wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
On Fri, 27 Oct 2023 19:16:33 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 27 Oct 2023 18:40:56 GMT, Justin Lu wrote:
>> Please review this PR which updates ChoiceFormat and MessageFormat to no
>> longer call overridable methods in their constructors.
>>
>> The overridable methods called in the constructors are:
>> _ChoiceFormat::applyPattern_,
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote:
>> Spec clarification of `ListFormat.equals()` method, utilizing newly
>> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also
>> been drafted.
>
> Naoto Sato has updated the pull request incrementally with one
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote:
>> Windows 11 does not reserve as many names as prior versions of Windows so do
>> not expect exceptions for COM7 and LPT1.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comment.
>
> Thanks for your review comments. I will implement them and push again.
>
On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
Marked as reviewed by lancea (Reviewer).
On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 11 Oct 2023 19:27:46 GMT, Joe Wang wrote:
> Thanks for the update.
>
> I'm not sure it's necessary to repeat tests with Base64 input. I think
> Daniel's comment was that the data can be optionally base64-encoded into a
> string, not that the tests needed to be duplicated.
>
> The
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote:
>> Please review this PR which cleans up the static test utility class
>> _HexDumpReader_.
>>
>> This cleans up the code by replacing the nested _ByteArrayBuilder_ class
>> with _HexFormat_, and simplifies the File processing by using a
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote:
> Please review this PR which cleans up the static test utility class
> _HexDumpReader_.
>
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
> _HexFormat_, and simplifies the File processing by using a stream.
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote:
> Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument
> on calling `ListFormat::parseObject()`. A corresponding CSR has also been
> drafted.
Marked as reviewed by lancea (Reviewer).
-
PR Review:
On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes unused (internal)
> method from the `private` `URLClassPath$JarLoader`?
>
> The `validIndex` method which is being removed here was being used when JAR
> index was supported. We
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those time zones are
> the
On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote:
> The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp.
> The problem appears with the Graal compiler but may also occur on other
> platforms.
Marked as reviewed by lancea (Reviewer).
-
PR Review:
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after
On Thu, 21 Sep 2023 15:35:16 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Use assertEquals
Marked as reviewed by lancea
On Tue, 19 Sep 2023 21:10:41 GMT, Joe Wang wrote:
> Fix a NPE. The DTD patch (JDK-8306632) moved initialization to factories, for
> example, for SAXParser, the SecurityManagers are created in the
> SAXParserFactory impl and passed on to instances of SAXParsers. The
> (deprecated)
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Add missing space
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Revamp isZip64ExtBlockSizeValid
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
On Thu, 14 Sep 2023 21:53:30 GMT, Brian Burkhalter wrote:
> Add a `finally` block to delete the created files.
Given this is a small test, perhaps it would be worthwhile to convert to Junit
as part of your cleanup
-
PR Review:
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
This makes sense to remove.
Joe is on holiday so please wait for his input as there are some additional
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Remove tab(s) from comment
On Mon, 11 Sep 2023 23:42:37 GMT, Sergey Bylokhov wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added additional tests, along with additional cleanup and refactoring
>
>
On Tue, 12 Sep 2023 08:47:03 GMT, Andrey Turbanov wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added additional tests, along with additional cleanup and refactoring
>
>
4 extra header but we are missing the
> csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Added additional tests, along with addi
Please review this PR which improves the Zip64 extra header validation:
- Throw a ZipException If the extra len field is 0 and :
-- size, csize, or loc offset are not set to 0x
-- disk starting number is not set to 0x
- We have a valid size for the Zip64 extra header but we are
On Fri, 28 Jul 2023 18:41:48 GMT, Joe Wang wrote:
> Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to
> specify how DTDs are handled. This property is uniformly supported across the
> JDK XML libraries. It complements, rather than replaces, the existing
> properties
On Mon, 28 Aug 2023 16:31:06 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib ) has
> released Zlib 1.3 on August 18, 2023.
>
> T
On Tue, 29 Aug 2023 13:25:57 GMT, Alan Bateman wrote:
> Okay, assuming tests are passing on windows-x64 and macos-aarch64 as these
> are the two that will usually use the bundled zlib.
Yes, both were clean in my mach5 runs
-
PR Comment:
On Mon, 28 Aug 2023 17:10:04 GMT, Alan Bateman wrote:
> Are there any changes from the upstream zlib 1.3 code that should be called
> out or is zlib 1.3 copied in without any changes?
It was a clean copy(which I have been able to do as of zlib 1.2.13). Sorry I
should have mentioned this in
Hi all,
Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK
The [Zlib Data Compression Library](https://github.com/madler/zlib ) has
released Zlib 1.3 on August 18, 2023.
There are a [small number of
updates](https://github.com/madler/zlib/compare/v1.2.13...master ) between
On Wed, 23 Aug 2023 21:46:34 GMT, Brian Burkhalter wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make the isOpen method to package private
>
> test/jdk/java/io/BufferedOutputStream/WriteAfterClose.java line 61:
>
On Mon, 14 Aug 2023 14:52:00 GMT, Lance Andersen wrote:
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered
On Tue, 15 Aug 2023 18:22:00 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revise retrieval of jdk.util.zip.disableZip64ExtraFieldValidation and
>> tweak a c
Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003]
>0x600c4: CRC : 0xd8f689cb
>0x600c8: Compressed Size : 0x23e
>0x600cc: Uncompressed Size: 0x392
>0x600d0: Name Length : 0x20
>0x600d2: Extra Length :0x8
> [ta
On Tue, 15 Aug 2023 18:13:16 GMT, Alan Bateman wrote:
>> Reworked similar to above.
>
>> Reworked similar to above.
>
> Thanks. Related is that there aren't tests in this PR that run with
> -Djdk.util.zip.disableZip64ExtraFieldValidation and
>
Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003]
>0x600c4: CRC : 0xd8f689cb
>0x600c8: Compressed Size : 0x23e
>0x600cc: Uncompressed Size: 0x392
>0x600d0: Name Length : 0x20
>0x600d2: Extra Length :0x8
> [ta
On Tue, 15 Aug 2023 10:21:42 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add additional zip to the DataProvider so it is exercised
>
> src/java.base/share/clas
On Tue, 15 Aug 2023 10:36:47 GMT, Alan Bateman wrote:
>> I don't think this is a question of "taste" because
>> `isZip64ExtBlockSizeValid()` suggests that the method will check for *valid*
>> sizes and to my understanding `0` is not a valid input. This method might
>> also be called from
Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003]
>0x600c4: CRC : 0xd8f689cb
>0x600c8: Compressed Size : 0x23e
>0x600cc: Uncompressed Size: 0x392
>0x600d0: Name Length : 0x20
>0x600d2: Extra Length :0x8
> [ta
101 - 200 of 579 matches
Mail list logo
