Re: RFR: 8305814: Update Xalan Java to 2.7.3 [v2]

On Tue, 7 Nov 2023 05:43:06 GMT, Joe Wang wrote: >> Xalan 2.7.3: merge minor changes from the upstream project. >> >> Test: existing XML tests pass > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove commented out block in

Re: RFR: 8305814: Update Xalan Java to 2.7.3

On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote: > Xalan 2.7.3: merge minor changes from the upstream project. > > Test: existing XML tests pass src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java line 104: > 102: > buff.append(posneg).append(formatDig

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

On Mon, 6 Nov 2023 11:28:23 GMT, Ryan Wallace wrote: > I had a look and its been in since JDK 9 > (https://bugs.openjdk.org/browse/JDK-8158295) but haven’t found any mention > of this as a specific desired behaviour so I am going with just noticed now. > Its not a major blocker as the user can

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v8]

On Mon, 30 Oct 2023 17:57:23 GMT, Eirik Bjorsnos wrote: >> This way of updating the copyright was suggested by @jaikiran in the March >> 10th comment above. Would be nice to get this clarified, yes. > > There is actually very little left of Martin's code after my rewrite, besides > whitespace,

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

On Thu, 2 Nov 2023 18:21:07 GMT, Eirik Bjorsnos wrote: > > Thinking some more about this, I would like to see us keep the Zip > > generated by python, store it in a byte array (or equivalent) as it also > > validate that we can still process the zip given this was the original test > > and the

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v8]

On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v6]

On Mon, 13 Mar 2023 03:18:26 GMT, Eirik Bjorsnos wrote: >> test/jdk/java/util/zip/ZipFile/CenSizeTooLarge.java line 53: >> >>> 51: >>> 52: // Maximum size (unsigned short) of an extra field allowed by the >>> standard >>> 53: static final int MAX_EXTRA_FIELD_SIZE = 0X; >> >> 4.4.1

Re: RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v3]

On Mon, 30 Oct 2023 12:13:59 GMT, Eirik Bjorsnos wrote: > > I think the changes look good overall. Thank you for this. I am not sure > > that the `@requires` is needed at this point. > > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB > memory requirement? If so, I g

Re: RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v7]

On Mon, 30 Oct 2023 11:57:09 GMT, Eirik Bjorsnos wrote: >> Please review this PR which speeds up TestTooManyEntries and clarifies its >> purpose: >> >> - The name 'TestTooManyEntries' does not clearly convey the purpose of the >> test. What is tested is the validation that the total CEN size f

Re: RFR: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files [v3]

On Sat, 28 Oct 2023 17:08:07 GMT, Eirik Bjorsnos wrote: >> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the >> number of compressed or uncompressed bytes read from the inflater is larger >> than the Zip64 magic value. >> >> While the ZIP format mandates that the data de

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

On Fri, 27 Oct 2023 19:16:33 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Im

Re: RFR: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method [v4]

On Fri, 27 Oct 2023 18:40:56 GMT, Justin Lu wrote: >> Please review this PR which updates ChoiceFormat and MessageFormat to no >> longer call overridable methods in their constructors. >> >> The overridable methods called in the constructors are: >> _ChoiceFormat::applyPattern_, _ChoiceFormat:

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one additional

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revis

Re: RFR: 8314891: Additional Zip64 extra header validation [v8]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes broug

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v10]

On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again. > @ma

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v8]

On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16

On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote: > This change updates the IANA subtag registry to the update released on > 2023-10-16. > > Announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html Marked as reviewed by lancea (Reviewer). --

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v7]

On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v4]

On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v8]

On Wed, 11 Oct 2023 19:27:46 GMT, Joe Wang wrote: > Thanks for the update. > > I'm not sure it's necessary to repeat tests with Base64 input. I think > Daniel's comment was that the data can be optionally base64-encoded into a > string, not that the tests needed to be duplicated. > > The gene

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream.

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader

On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote: > Please review this PR which cleans up the static test utility class > _HexDumpReader_. > > This cleans up the code by replacing the nested _ByteArrayBuilder_ class with > _HexFormat_, and simplifies the File processing by using a stream. Chan

Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Marked as reviewed by lancea (Reviewer). - PR Review: https://

Re: RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader

On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes unused (internal) > method from the `private` `URLClassPath$JarLoader`? > > The `validIndex` method which is being removed here was being used when JAR > index was supported. We remo

Re: RFR: 8317126: Redundant entries in Windows `tzmappings` file

On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote: > Removing redundant entries in `lib/tzmappings` file on Windows. The file maps > Windows time zones to Java time zones according to the region. Since `001` > means world, no region-specific entries are needed if those time zones are > the sa

Re: RFR: 8315721: CloseRace.java#id0 fails transiently on libgraal

On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote: > The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp. > The problem appears with the Graal compiler but may also occur on other > platforms. Marked as reviewed by lancea (Reviewer). - PR Review: https://

Re: RFR: JDK-8316559: Refactor some util/Calendar tests to JUnit [v2]

On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote: >> Please review this PR which converts some tests under _Calendar_ to use >> JUnit. These tests either previously used the internal _IntlTest_, or used >> no framework at all. >> >> Any files named BugXXX.java will be renamed after revie

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v9]

On Thu, 21 Sep 2023 15:35:16 GMT, Brian Burkhalter wrote: >> Add a `finally` block to delete the created files. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8315960: Use assertEquals Marked as reviewed by lancea (Re

Re: RFR: 8316383: NullPointerException in AbstractSAXParser after JDK-8306632

On Tue, 19 Sep 2023 21:10:41 GMT, Joe Wang wrote: > Fix a NPE. The DTD patch (JDK-8306632) moved initialization to factories, for > example, for SAXParser, the SecurityManagers are created in the > SAXParserFactory impl and passed on to instances of SAXParsers. The > (deprecated) XMLReaderFact

Re: RFR: 8314891: Additional Zip64 extra header validation [v7]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Add missing space

Re: RFR: 8314891: Additional Zip64 extra header validation [v6]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Revamp isZip64ExtBlockSizeValid

Re: RFR: 8314891: Additional Zip64 extra header validation [v5]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes broug

Re: RFR: 8314891: Additional Zip64 extra header validation [v4]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes broug

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind

On Thu, 14 Sep 2023 21:53:30 GMT, Brian Burkhalter wrote: > Add a `finally` block to delete the created files. Given this is a small test, perhaps it would be worthwhile to convert to Junit as part of your cleanup - PR Review: https://git.openjdk.org/jdk/pull/15757#pullrequestrevi

Re: RFR: 8316144: Remove unused field jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element._Depth

On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote: > A field `short _Depth` in the > `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and > can be removed. This makes sense to remove. Joe is on holiday so please wait for his input as there are some additional co

Re: RFR: 8314891: Additional Zip64 extra header validation [v3]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Remove tab(s) from comment

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

On Mon, 11 Sep 2023 23:42:37 GMT, Sergey Bylokhov wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added additional tests, along with additional cleanup and refactoring > >

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

On Tue, 12 Sep 2023 08:47:03 GMT, Andrey Turbanov wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added additional tests, along with additional cleanup and refactoring > >

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

tra header but we are missing the > csize or loc fields if they are expected to be part of the header > > Mach5 tiers 1-3 are clean Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Added additional tests, along with addi

RFR: 8314891: Additional Zip64 extra header validation

Please review this PR which improves the Zip64 extra header validation: - Throw a ZipException If the extra len field is 0 and : -- size, csize, or loc offset are not set to 0x -- disk starting number is not set to 0x - We have a valid size for the Zip64 extra header but we are missin

Re: RFR: 8306632: Add a JDK Property for specifying DTD support

On Fri, 28 Jul 2023 18:41:48 GMT, Joe Wang wrote: > Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to > specify how DTDs are handled. This property is uniformly supported across the > JDK XML libraries. It complements, rather than replaces, the existing > properties th

Integrated: 8315117: Update Zlib Data Compression Library to Version 1.3

On Mon, 28 Aug 2023 16:31:06 GMT, Lance Andersen wrote: > Hi all, > > Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK > > The [Zlib Data Compression Library](https://github.com/madler/zlib ) has > released Zlib 1.3 on August 18, 2023. > > Ther

Re: RFR: 8315117: Update Zlib Data Compression Library to Version 1.3

On Tue, 29 Aug 2023 13:25:57 GMT, Alan Bateman wrote: > Okay, assuming tests are passing on windows-x64 and macos-aarch64 as these > are the two that will usually use the bundled zlib. Yes, both were clean in my mach5 runs - PR Comment: https://git.openjdk.org/jdk/pull/15453#issue

Re: RFR: 8315117: Update Zlib Data Compression Library to Version 1.3

On Mon, 28 Aug 2023 17:10:04 GMT, Alan Bateman wrote: > Are there any changes from the upstream zlib 1.3 code that should be called > out or is zlib 1.3 copied in without any changes? It was a clean copy(which I have been able to do as of zlib 1.2.13). Sorry I should have mentioned this in th

RFR: 8315117: Update Zlib Data Compression Library to Version 1.3

Hi all, Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK The [Zlib Data Compression Library](https://github.com/madler/zlib ) has released Zlib 1.3 on August 18, 2023. There are a [small number of updates](https://github.com/madler/zlib/compare/v1.2.13...master ) between

Re: RFR: 4799358: BufferOutputStream.write() should immediately throw IOExcept on closed stream [v2]

On Wed, 23 Aug 2023 21:46:34 GMT, Brian Burkhalter wrote: >> Vyom Tewari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make the isOpen method to package private > > test/jdk/java/io/BufferedOutputStream/WriteAfterClose.java line 61: >

Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size)

On Mon, 14 Aug 2023 14:52:00 GMT, Lance Andersen wrote: > This PR updates the extra field validation added as part of > [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with > issues seen with 3rd party tools/libraries where a ZipException may be > encountered

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v8]

On Tue, 15 Aug 2023 18:22:00 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revise retrieval of jdk.util.zip.disableZip64ExtraFieldValidation and >> tweak a c

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v9]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v6]

On Tue, 15 Aug 2023 18:13:16 GMT, Alan Bateman wrote: >> Reworked similar to above. > >> Reworked similar to above. > > Thanks. Related is that there aren't tests in this PR that run with > -Djdk.util.zip.disableZip64ExtraFieldValidation and > -D"jdk.util.zip.disableZip64ExtraFieldValidation=t

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v8]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v6]

On Tue, 15 Aug 2023 10:21:42 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add additional zip to the DataProvider so it is exercised > > src/java.base/share/clas

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2]

On Tue, 15 Aug 2023 10:36:47 GMT, Alan Bateman wrote: >> I don't think this is a question of "taste" because >> `isZip64ExtBlockSizeValid()` suggests that the method will check for *valid* >> sizes and to my understanding `0` is not a valid input. This method might >> also be called from other

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v7]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v6]

On Tue, 15 Aug 2023 00:07:01 GMT, Sergey Bylokhov wrote: > [TEST.zip](https://github.com/openjdk/jdk/files/12340301/TEST.zip) > > try this example, zip -T passed, unzip works fine, but openjdk rejects it. Yes, the Zip64 header in the CEN has a field size of 2 and as we are validating the Zip64

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v5]

On Mon, 14 Aug 2023 21:16:27 GMT, Volker Simonis wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added an additional test with with 0 extra header followed by an extra >> header

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v6]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v5]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v4]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3]

On Mon, 14 Aug 2023 18:49:25 GMT, Lance Andersen wrote: >> This PR updates the extra field validation added as part of >> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with >> issues seen with 3rd party tools/libraries where a ZipException may be &

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

On Mon, 14 Aug 2023 17:59:19 GMT, Sergey Bylokhov wrote: > > It's unfortunate that there are tools and plugins in the eco system that > > have these issues. I think you've got the right balance here, meaning > > tolerating a zip64 extra block with a block size of 0 and rejecting > > corrupted

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2]

On Mon, 14 Aug 2023 18:03:20 GMT, Sergey Bylokhov wrote: >> Lance Andersen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2]

On Mon, 14 Aug 2023 17:15:21 GMT, Volker Simonis wrote: >> Lance Andersen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2]

Mod Time: 0x2e418983 [Sat Feb 01 17:12:06 EST 2003] >0x600c4: CRC : 0xd8f689cb >0x600c8: Compressed Size : 0x23e >0x600cc: Uncompressed Size: 0x392 >0x600d0: Name Length : 0x20 >0x600d2: Extra Length :0x8 >

RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size)

This PR updates the extra field validation added as part of [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with issues seen with 3rd party tools/libraries where a ZipException may be encountered when opening select APK, ZIP or JAR files. Please see refer to the links prov

Re: RFR: 8311006: missing @since info in jdk.xml.dom

On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15129#pullreques

Re: RFR: 8310991: missing @since tags in java.xml

On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote: > Please review a patch that adds the @since tag to DOM package. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15109#pullrequestreview-1557752047

Re: CFV: New Core Libraries Group Member: Joe Wang

Vote: Yes. On 27/07/2023 19:36, Roger Riggs wrote: I hereby nominate Joe Wang to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including DOM, SAX, StAX, Transform, V

Re: CFV: New Core Libraries Group Member: Brent Christian

Vote: Yes. On 27/07/2023 19:36, Roger Riggs wrote: I hereby nominate Brent Christian to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader, NIO J

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

Vote: Yes. On 27/07/2023 19:35, Roger Riggs wrote: I hereby nominate Brian Burkhalter to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channe

Re: RFR: 8312416: Tests in Locale should have more descriptive names

On Wed, 26 Jul 2023 07:11:16 GMT, Justin Lu wrote: > Please review this change which renames tests for Locale from > `bugNNN.java` to something more descriptive. > > In addition to the name changes, accompanying copyright year, name usage > within the test, and other minor changes were inc

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v5]

On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> `equals` and `hashCode` in the java.text area. >> >> * Some changes to `equals` and `hashCode` are refactoring rather than >> modernization. Such changes can be

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v4]

On Thu, 13 Jul 2023 22:43:27 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: [jdk21] RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote: > Please review this PR which backports > https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d > > Thank you Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/125#p

Re: RFR: 8155902: DataOuputStream should clarify that it might write primitive types as multiple byte groups [v4]

On Tue, 11 Jul 2023 17:36:18 GMT, Brian Burkhalter wrote: >> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes >> no guarantee as to how the underlying output stream actually writes the >> bytes provided to it. > > Brian Burkhalter has updated the pull request increment

Re: [jdk21] RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer

On Tue, 11 Jul 2023 17:21:13 GMT, Alan Bateman wrote: > Clean backport of https://git.openjdk.org/jdk/pull/14679 Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/113#pullrequestreview-1524851331

Re: RFR: 8311528: Remove IDE specific SuppressWarnings

On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote: > Removing the IDE specific `@SuppressWarnings` attached to > `java.util.Calendar#equals()`. `equals()` implementation now checks the type > of the other instance for this. Marked as reviewed by lancea (Reviewer). - PR Review: ht

Re: RFR: 8310818: Refactor more Locale tests to use JUnit [v2]

On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote: >> Please review this PR which refactors additional tests in Locale to use >> JUnit. >> >> If a test was named bugNNN.java, it was renamed to something more >> descriptive. >> >> Below is a list of all the changes >> >> - Refactor and Ren

Re: RFR: 8310999: Add @since info in jdk.jsobject files

On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-1

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text

On Mon, 3 Jul 2023 11:12:32 GMT, Pavel Rappo wrote: > Please review this PR to use modern APIs and language features to simplify > `equals` and `hashCode` in the java.text area. > > * Some changes to `equals` and `hashCode` are refactoring rather than > modernization. Such changes can be as tr

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v6]

On Fri, 30 Jun 2023 16:49:22 GMT, Justin Lu wrote: >> Please review this PR which refactors Currency tests to use JUnit. >> >> The most significant change occurs in `ValidateISO4217.java`. Other changes >> to this file excluding the JUnit refactoring include >> >> - Tests are no longer depende

Re: RFR: 8310987: Missing @since tag(s) in java/util/logging/ErrorManager.java

On Fri, 30 Jun 2023 09:06:20 GMT, Daniel Fuchs wrote: > Please find here a trivial doc fix to add a missing `@since 1.4` to the > java.util.logging.ErrorManager class. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14725#pullrequestreview-15

Re: RFR: 8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()

On Tue, 27 Jun 2023 19:55:02 GMT, Roger Riggs wrote: > Fix a test bug when run on aarch64, it was supposed to confirm it was not > running on Arm. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14685#pullrequestreview-1501766576

Integrated: 8310828: java.sql java.sql.rowset packages have no `@since` info

On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote: > Hi all, > > Please review this trivial change which adds the `@since` javadoc tag to the > various ` java.sql `and `java.sql.rowset` packages. > > Best > Lance This pull request has now been integrated. Chang

Re: RFR: JDK-8310975 java.util.FormatItemModifier should not be protected

On Tue, 27 Jun 2023 16:11:43 GMT, Jim Laskey wrote: > The nested class is incorrectly marked as protected. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14681#pullrequestreview-1501494580

Re: RFR: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash [v2]

On Tue, 27 Jun 2023 03:39:30 GMT, Naoto Sato wrote: >> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There >> are other locations than `ISO_LOCAL_DATE` that have the same description. >> Those are corrected too. > > Naoto Sato has updated the pull request incrementally wi

Re: RFR: JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag

On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote: > Please review a trivial update to remove a redundant `@since` tag. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499179572

RFR: 8310828: java.sql java.sql.rowset packages have no `@since` info

Hi all, Please review this trivial change which adds the `@since` javadoc tag to the various ` java.sql `and `java.sql.rowset` packages. Best Lance - Commit messages: - Remove empty line - Add @since to package-info.java Changes: https://git.openjdk.org/jdk/pull/14652/files Web

Re: RFR: 8310837: Use ByteArrayLittleEndian in java.util.zip

On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote: > Using `ByteArrayLittleEndian` is simpler and faster. > > `make test TEST="micro:java.util.zip.ZipFileOpen"`: > > > Benchmark (size) Mode Cnt Score Error Units > - ZipFileOpen.openCloseZipFile 512 avgt 15

Re: RFR: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer [v8]

On Fri, 23 Jun 2023 23:23:07 GMT, Brian Burkhalter wrote: >> Clarify the behavior of `java.lang.Readable` when the specified >> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full. > > Brian Burkhalter has updated the pull request incrementally with one > additional comm

Re: RFR: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer

On Thu, 22 Jun 2023 19:00:58 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/lang/Readable.java line 49: >> >>> 47: * @param cb the buffer to read characters into >>> 48: * @return The number of {@code char} values added to the buffer, >>> 49: * possibly z

Re: RFR: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer

On Thu, 22 Jun 2023 18:22:35 GMT, Brian Burkhalter wrote: > Clarify the behavior of `java.lang.Readable` when the specified > `java.nio.CharBuffer` parameter is empty but read-only, and when it is full. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/

<    1   2   3   4   5   6   7   >