Re: RFR: 8317993: Add capturing factories to classes in java.util.function package [v3]

2023-10-18 Thread Per Minborg
real code. Users that prefers having a > normal type declaration can still do that. > > Note: Functional interfaces of primitives have not been considered (in this > round). Otherwise, functional interfaces that might be ambiguous or that > supports composition have been included. Hence,

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package [v2]

2023-10-18 Thread Per Minborg
real code. Users that prefers having a > normal type declaration can still do that. > > Note: Functional interfaces of primitives have not been considered (in this > round). Otherwise, functional interfaces that might be ambiguous or that > supports composition have been included. Hence,

Re: RFR: 8317870: Add @sealedGraph to Thread.Builder

2023-10-18 Thread Per Minborg
On Wed, 11 Oct 2023 15:00:03 GMT, Alan Bateman wrote: >> This PR proposes to Add @sealedGraph to `Thread.Builder`. > > @pron Do you have any comment on this one? I remember we decided not to do > this in JDK 21. @AlanBateman and @pron : Should we drop this PR? I will lazily do that in a week

Re: RFR: 8317868: Add @sealedGraph to MethodHandleDesc and descendants [v2]

2023-10-18 Thread Per Minborg
On Wed, 11 Oct 2023 11:18:41 GMT, Per Minborg wrote: >> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Update copyright ye

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` t

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` t

RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
This PR proposes to add a number of "capturing factories" in classes in the `java.util.function` package. The PR additionally (an optionally) proposes to add a new function `UnaryOperator::andThenUnary` to allow composition while retaining the `UnaryOperator` type. With the new change, it is

Re: RFR: 8317514: Ensure MemorySegment is initialized before touching NativeMemorySegmentImpl [v2]

2023-10-13 Thread Per Minborg
On Fri, 13 Oct 2023 17:31:15 GMT, Maurizio Cimadamore wrote: >> This PR makes sure that `MemorySegment` is initialized *before* any of its >> subclasses. >> This is done by centralizing all the memory segment factories in a single >> implementation class (`SegmentFactories`). >> Doing so

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v4]

2023-10-12 Thread Per Minborg
> This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Declare two fields `final` > * Use distinct classes rather than anonymous classes Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Re

Integrated: 8315850: Improve AbstractMap anonymous Iterator classes

2023-10-12 Thread Per Minborg
On Thu, 7 Sep 2023 11:48:51 GMT, Per Minborg wrote: > This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Declare two fields `final` > * Use distinct classes rather than anonymous classes This pull request has now been integrated. Changeset: d95b548c Au

Integrated: 8317873: Add @sealedGraph to IllegalFormatException

2023-10-12 Thread Per Minborg
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote: > This PR proposes to add @sealedGraph to `IllegalFormatException` This pull request has now been integrated. Changeset: eca6ea43 Author: Per Minborg URL: https://git.openjdk.org/jdk/commit/eca6ea43d085a68b9b9760e732275175cb1b0

Integrated: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage

2023-10-11 Thread Per Minborg
On Wed, 11 Oct 2023 08:07:31 GMT, Per Minborg wrote: > This PR proposes to Add @sealedGraph to `StringTemplate.Processor.Linkage` This pull request has now been integrated. Changeset: 2d46b297 Author: Per Minborg URL: https://git.openjdk.org/jdk/com

Re: RFR: 8317956: Make jdk.internal.util.Architecture current architecture final

2023-10-11 Thread Per Minborg
On Wed, 11 Oct 2023 13:25:14 GMT, Roger Riggs wrote: > The static for the current architecture should be final to allow some > optimizations. Marked as reviewed by pminborg (Committer). - PR Review: https://git.openjdk.org/jdk/pull/16150#pullrequestreview-1671239088

Re: RFR: 8317868: Add @sealedGraph to MethodHandleDesc and descendants [v2]

2023-10-11 Thread Per Minborg
On Wed, 11 Oct 2023 07:57:11 GMT, Chen Liang wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Revoke change in DMHD > > src/java.b

Re: RFR: 8317868: Add @sealedGraph to MethodHandleDesc and descendants [v2]

2023-10-11 Thread Per Minborg
> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Update copyright year - Revoke change in DMHD - Changes: - all: https://git.openjdk.

RFR: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage

2023-10-11 Thread Per Minborg
This PR proposes to Add @sealedGraph to `StringTemplate.Processor.Linkage` - Commit messages: - Add @sealedGraph to StringTemplate.Processor.Linkage Changes: https://git.openjdk.org/jdk/pull/16141/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16141=00 Issue:

RFR: 8317873: Add @sealedGraph to IllegalFormatException

2023-10-11 Thread Per Minborg
This PR proposes to add @sealedGraph to `IllegalFormatException` - Commit messages: - Add @sealedGraph to IllegalFormatException Changes: https://git.openjdk.org/jdk/pull/16140/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16140=00 Issue:

RFR: 8317870: Add @sealedGraph to Thread.Builder

2023-10-11 Thread Per Minborg
This PR proposes to Add @sealedGraph to `Thread.Builder`. - Commit messages: - Add @sealedGraph to Thread.Builder Changes: https://git.openjdk.org/jdk/pull/16138/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16138=00 Issue: https://bugs.openjdk.org/browse/JDK-8317870

RFR: 8317868: Add @sealedGraph to MethodHandleDesc and descendants

2023-10-11 Thread Per Minborg
This PR proposes to add @sealedGraph to MethodHandleDesc and descendants. - Commit messages: - Add @sealedGraph to MethodHandleDesc and descendants Changes: https://git.openjdk.org/jdk/pull/16137/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16137=00 Issue:

Re: RFR: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements

2023-10-10 Thread Per Minborg
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote: > Alternative to #16082 > > Name (unchanged) Cnt Base Error Test Error > Unit Change > URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007 > ms/op 1,09x (p = 0,000*) >

Re: RFR: 8316851: Add @sealedGraph to Executable [v2]

2023-09-26 Thread Per Minborg
> This PR proposes to add the @sealedGraph tag to > `java.lang.reflect.Executable`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/15897

Integrated: 8316851: Add @sealedGraph to Executable

2023-09-26 Thread Per Minborg
On Mon, 25 Sep 2023 08:11:48 GMT, Per Minborg wrote: > This PR proposes to add the @sealedGraph tag to > `java.lang.reflect.Executable`. This pull request has now been integrated. Changeset: 9e6cb620 Author: Per Minborg URL: https://git.openjdk.org/jdk/

RFR: 8316851: Add @sealedGraph to Executable

2023-09-25 Thread Per Minborg
This PR proposes to add the @sealedGraph tag to `java.lang.reflect.Executable`. - Commit messages: - Add @SealedGraph to Executable Changes: https://git.openjdk.org/jdk/pull/15897/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15897=00 Issue:

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-22 Thread Per Minborg
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutab

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-21 Thread Per Minborg
oved > because the JVM is probably able to optimize away object creation anyway via > escape analysis. Also, all maps will occupy less space as we get rid of a > number of objects and references stored for each map. > > We need to benchmark this solution to better understand its

Re: RFR: 8316493: Make immutable maps @ValueBased [v2]

2023-09-20 Thread Per Minborg
oved > because the JVM is probably able to optimize away object creation anyway via > escape analysis. Also, all maps will occupy less space as we get rid of a > number of objects and references stored for each map. > > We need to benchmark this solution to better understand its

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Per Minborg
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > ma

RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Per Minborg
This PR outlines a solution for making immutable maps `@ValueBased` by removing cacheing of certain values in `AbstractMap`. By removing these caching fields in `AbstractMap`, we can make the immutable maps `@ValueBased` and at the same time, performance is likely improved because the JVM is

Withdrawn: 8316196: VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form

2023-09-15 Thread Per Minborg
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote: > This PR proposes to use hexadecimal formatting for raw addresses in > `VarHandleSegmentViewBase`. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/15742

Re: RFR: 8316196: VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form [v2]

2023-09-15 Thread Per Minborg
On Fri, 15 Sep 2023 06:06:18 GMT, Per Minborg wrote: >> This PR proposes to use hexadecimal formatting for raw addresses in >> `VarHandleSegmentViewBase`. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The increm

Re: RFR: 8316196: VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form [v2]

2023-09-15 Thread Per Minborg
> This PR proposes to use hexadecimal formatting for raw addresses in > `VarHandleSegmentViewBase`. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

Integrated: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Per Minborg
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote: > This PR proposes to improve the MemorySegment::toString to reduce cluttering > and add missing comas. This pull request has now been integrated. Changeset: 8dc2d928 Author: Per Minborg URL: https://git.openjdk.org/jdk/

Re: RFR: 8316196: VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form

2023-09-14 Thread Per Minborg
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote: > This PR proposes to use hexadecimal formatting for raw addresses in > `VarHandleSegmentViewBase`. src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: > 275: } > 276: > 277: public static String t

RFR: 8316196: VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form

2023-09-14 Thread Per Minborg
This PR proposes to use hexadecimal formatting for raw addresses in `VarHandleSegmentViewBase`. - Commit messages: - VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form Changes: https://git.openjdk.org/jdk/pull/15742/files Webrev:

Re: RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Per Minborg
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote: > This PR proposes to improve the MemorySegment::toString to reduce cluttering > and add missing comas. src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: > 275: } > 276: > 277: public static Str

RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Per Minborg
This PR proposes to improve the MemorySegment::toString to reduce cluttering and add missing comas. - Commit messages: - Improve MemorySegment::toString Changes: https://git.openjdk.org/jdk/pull/15740/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15740=00 Issue:

Integrated: 8316050: Use hexadecimal encoding in MemorySegment::toString

2023-09-13 Thread Per Minborg
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote: > This PR proposes to use hexadecimal representation for a memory segment > address rather than a decimal one. This pull request has now been integrated. Changeset: f9ab115a Author: Per Minborg URL: https://git.openjdk.o

Re: RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString [v2]

2023-09-13 Thread Per Minborg
> This PR proposes to use hexadecimal representation for a memory segment > address rather than a decimal one. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Change from limit to byteSize in MS::toString - C

RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString

2023-09-11 Thread Per Minborg
This PR proposes to use hexadecimal representation for a memory segment address rather than a decimal one. - Commit messages: - Use hexadecimal encoding in MemorySegment::toString Changes: https://git.openjdk.org/jdk/pull/15670/files Webrev:

Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-11 Thread Per Minborg
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Per Minborg
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v3]

2023-09-08 Thread Per Minborg
> This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Code reuse > * A field declared `final` > * Add missing `@Override` annotations Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Fix addit

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v2]

2023-09-07 Thread Per Minborg
> This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Code reuse > * A field declared `final` > * Add missing `@Override` annotations Per Minborg has updated the pull request incrementally with one additional commit since the last revision: R

RFR: 8315850: Improve AbstractMap anonymous Iterator classes

2023-09-07 Thread Per Minborg
This PR proposes to slightly improve some iterators of `AbstractMap`: * Code reuse * A field declared `final` * Add missing `@Override` annotations - Commit messages: - Improve AbstractMap anonymous Iterator classes Changes: https://git.openjdk.org/jdk/pull/15615/files Webrev:

Integrated: 8314260: Unable to load system libraries on Windows when using a SecurityManager

2023-09-07 Thread Per Minborg
On Tue, 5 Sep 2023 08:52:50 GMT, Per Minborg wrote: > This PR proposes to read the system environment variable "SystemRoot" using a > privileged operation so it will work in the event a default SecurityManager > is in place. > > As the `SecurityManager` is deprecate

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v4]

2023-09-07 Thread Per Minborg
ed for reading environmental variables. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add privilidged action and restrict grants - Changes: - all: https://git.openjdk.org/jdk/pull/15564/files - new: https://git.openjdk.org/j

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v2]

2023-09-05 Thread Per Minborg
On Tue, 5 Sep 2023 09:36:59 GMT, ExE Boss wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a SecurityManager for TestLinker > > test/jdk/java/foreign/TestLinker.java line 30: &

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v3]

2023-09-05 Thread Per Minborg
ed for reading environmental variables. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add extra test run with no SecutityManager - Changes: - all: https://git.openjdk.org/jdk/pull/15564/files - new: https://git.openjdk.org/j

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v2]

2023-09-05 Thread Per Minborg
ed for reading environmental variables. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add a SecurityManager for TestLinker - Changes: - all: https://git.openjdk.org/jdk/pull/15564/files - new: https://git.openjdk.org/j

RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager

2023-09-05 Thread Per Minborg
This PR proposes to read the system environment variable "SystemRoot" using a privileged operation so it will work in the event a default SecurityManager is in place. As the `SecurityManager` is deprecated for removal, no support methods were added for reading environmental variables.

Integrated: 8315454: Add a way to create an immutable snapshot of a BitSet

2023-09-05 Thread Per Minborg
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote: > This PR proposes adding a new method to BitSet that provides an immutable > snapshot of the set in the form of an `IntPredicate`. > > The predicate is eligible for constant folding. > > Here are some classes in the JDK

Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v5]

2023-09-04 Thread Per Minborg
EncodeDecode.testEncodeUTF8 61024 75 15 > 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*) > URLEncodeDecode.testEncodeUTF8 61024 100 15 > 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*) Per Minborg has updated the p

Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v4]

2023-09-04 Thread Per Minborg
EncodeDecode.testEncodeUTF8 61024 75 15 > 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*) > URLEncodeDecode.testEncodeUTF8 61024 100 15 > 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*) Per Minborg has updated the

Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v3]

2023-09-01 Thread Per Minborg
EncodeDecode.testEncodeUTF8 61024 75 15 > 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*) > URLEncodeDecode.testEncodeUTF8 61024 100 15 > 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*) Per Minborg has updated the

Re: RFR: 8315454: Add an immutable BitSet [v2]

2023-09-01 Thread Per Minborg
EncodeDecode.testEncodeUTF8 61024 75 15 > 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*) > URLEncodeDecode.testEncodeUTF8 61024 100 15 > 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*) Per Minborg has updated the pul

Re: RFR: 8315454: Add an immutable BitSet

2023-09-01 Thread Per Minborg
On Fri, 1 Sep 2023 09:00:32 GMT, Hannes Greule wrote: > Maybe it would make sense to start with a JDK-internal variant before > exploring potential public API? This is certainly one alternative. - PR Comment: https://git.openjdk.org/jdk/pull/15530#issuecomment-1702421871

Re: RFR: 8315454: Add an immutable BitSet

2023-09-01 Thread Per Minborg
On Fri, 1 Sep 2023 08:50:42 GMT, Chen Liang wrote: > What about the missing functionalities, such as ranged get, cardinality, > next/previousSet/ClearBit? This was explored in https://github.com/openjdk/jdk/pull/15493 - PR Comment:

RFR: 8315454: Add an immutable BitSet

2023-09-01 Thread Per Minborg
This PR proposes adding a new method to BitSet that provides an immutable snapshot of the set in the form of an `IntPredicate`. The predicate is eligible for constant folding. Here are some classes in the JDK that would benefit directly from constant-folding of BitSets: PoolReader (6)

Re: RFR: 8310843: Reimplement ByteArray and ByteArrayLittleEndian with Unsafe [v10]

2023-08-22 Thread Per Minborg
On Thu, 13 Jul 2023 23:05:48 GMT, Glavo wrote: >> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that >> can be used in many places to performance tuning. >> >> Currently they are implemented by `VarHandle`, so using them may have some >> impact on startup time. >> >>

Integrated: 8314071: Test java/foreign/TestByteBuffer.java timed out

2023-08-17 Thread Per Minborg
On Thu, 17 Aug 2023 09:36:32 GMT, Per Minborg wrote: > This PR proposes improving performance for two `VarHandle` objects and > increasing the timeout for the tests. The size of a mapped file is also > reduced from 3 GiB to 2.5 GiB. This still crosses the 2 31 > boundary. This

RFR: 8314071: Test java/foreign/TestByteBuffer.java timed out

2023-08-17 Thread Per Minborg
This PR proposes improving performance for two `VarHandle` objects and increasing the timeout for the tests. The size of a mapped file is also reduced from 3 GiB to 2.5 GiB. This still crosses the 2 31 boundary. - Commit messages: - Improve performance and increase timeout

Integrated: 8298095: Refine implSpec for SegmentAllocator

2023-08-10 Thread Per Minborg
On Mon, 24 Jul 2023 12:32:59 GMT, Per Minborg wrote: > This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate > methods as well as clarifying the docs a bit more. Also, a local variable is > renamed. This pull request has now been integrated. Changeset: 35b60f

Re: RFR: 8298095: Refine implSpec for SegmentAllocator [v5]

2023-08-10 Thread Per Minborg
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate > methods as well as clarifying the docs a bit more. Also, a local variable is > renamed. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Simp

Re: RFR: 8313889: Fix -Wconversion warnings in foreign benchmarks

2023-08-08 Thread Per Minborg
On Mon, 7 Aug 2023 14:40:42 GMT, Jorn Vernee wrote: > Fix these -Wconversion warnings in the foreign benchmarks: > > > ./test/micro/org/openjdk/bench/java/lang/foreign/libQSortJNI.c: In function > ‘Java_org_openjdk_bench_java_lang_foreign_QSort_jni_1qsort_1optimized’: >

Re: RFR: 8298095: Refine implSpec for SegmentAllocator [v4]

2023-08-08 Thread Per Minborg
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate > methods as well as clarifying the docs a bit more. Also, a local variable is > renamed. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev

Integrated: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643

2023-08-07 Thread Per Minborg
This PR fixes a formatting error in a copyright header. - Commit messages: - Restore enablePreview - Fix copyright formatting in TestFree Changes: https://git.openjdk.org/jdk/pull/15175/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15175=00 Issue:

Integrated: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643

2023-08-07 Thread Per Minborg
On Mon, 7 Aug 2023 12:27:39 GMT, Per Minborg wrote: > This PR fixes a formatting error in a copyright header. This pull request has now been integrated. Changeset: bbbfa217 Author: Per Minborg URL: https://git.openjdk.org/jdk/commit/bbbfa217a030e90e41c036203f85b764927f4848 St

Re: RFR: 8310643: Misformatted copyright messages in FFM [v3]

2023-08-07 Thread Per Minborg
> This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Per Minborg has updated the pull request incremen

Integrated: 8310643: Misformatted copyright messages in FFM

2023-08-07 Thread Per Minborg
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote: > This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct?

Re: RFR: 8310643: Misformatted copyright messages in FFM [v2]

2023-08-07 Thread Per Minborg
> This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Per Minborg has updated the pull request incremen

Re: RFR: 8310643: Misformatted copyright messages in FFM

2023-08-07 Thread Per Minborg
On Sat, 29 Jul 2023 12:29:13 GMT, David Holmes wrote: >> This PR suggests updating some of the ill-formed copyright headers in the >> FFM API and the implementation and test thereof. >> >> Some of the test files will have now the "classpath" exception. Is this >> correct? > >

RFR: 8310643: Misformatted copyright messages in FFM

2023-07-26 Thread Per Minborg
This PR suggests updating some of the ill-formed copyright headers in the FFM API and the implementation and test thereof. Some of the test files will have now the "classpath" exception. Is this correct? - Commit messages: - Update copyright formatting Changes:

Re: RFR: 8298095: Refine implSpec for SegmentAllocator [v3]

2023-07-26 Thread Per Minborg
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate > methods as well as clarifying the docs a bit more. Also, a local variable is > renamed. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Upd

Re: RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-25 Thread Per Minborg
On Tue, 25 Jul 2023 10:57:48 GMT, Matthias Baesken wrote: > > I put this patch into our internal test queue to see how it works on AIX. > > AIX tests are fine too. Great! Thanks for testing this! - PR Comment: https://git.openjdk.org/jdk/pull/14994#issuecomment-1649617257

Integrated: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-24 Thread Per Minborg
On Mon, 24 Jul 2023 09:51:33 GMT, Per Minborg wrote: > This PR suggests making a test independent of the underlying platform byte > ordering and to test both ordering variants rather than just one. This pull request has now been integrated. Changeset: d1cc2782 Author: Per Minbor

Re: RFR: 8298095: Refine implSpec for SegmentAllocator [v2]

2023-07-24 Thread Per Minborg
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate > methods as well as clarifying the docs a bit more. Also, a local variable is > renamed. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Upd

RFR: 8298095: Refine implSpec for SegmentAllocator

2023-07-24 Thread Per Minborg
This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate methods as well as clarifying the docs a bit more. Also, a local variable is renamed. - Commit messages: - Improve javadocs - Update javadocs for SegmentAllocator::allocate methods Changes:

RFR: JDK-8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [[i4](struct)] but found [[I4](struct)]

2023-07-24 Thread Per Minborg
This PR suggests making a test independent of the underlying platform byte ordering and to test both ordering variants rather than just one. - Commit messages: - Make test independent of platform byte ordering Changes: https://git.openjdk.org/jdk/pull/14994/files Webrev:

Re: RFR: 8310591: Missing `@since` tags in java.lang.foreign [v3]

2023-06-22 Thread Per Minborg
> This PR adds missing `@Since` and `@PreviewFeature` annotations to some of > the Panama FFM entities. > > This PR should also be back-ported to 21. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revert "Har

Integrated: 8310591: Missing `@since` tags in java.lang.foreign

2023-06-22 Thread Per Minborg
On Thu, 22 Jun 2023 07:18:13 GMT, Per Minborg wrote: > This PR adds missing `@Since` and `@PreviewFeature` annotations to some of > the Panama FFM entities. > > This PR should also be back-ported to 21. This pull request has now been integrated. Changeset: 5a30fb66 Author:

Re: RFR: 8310591: Missing `@since` tags in java.lang.foreign [v2]

2023-06-22 Thread Per Minborg
> This PR adds missing `@Since` and `@PreviewFeature` annotations to some of > the Panama FFM entities. > > This PR should also be back-ported to 21. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Add newline

RFR: 8310591: Missing `@since` tags in java.lang.foreign

2023-06-22 Thread Per Minborg
This PR adds missing `@Since` and `@PreviewFeature` annotations to some of the Panama FFM entities. This PR should also be back-ported to 21. - Commit messages: - Add @Since and @PreviewFeature where missing Changes: https://git.openjdk.org/jdk/pull/14611/files Webrev:

Re: RFR: 8310502 : optimization for UUID#toString [v3]

2023-06-21 Thread Per Minborg
On Wed, 21 Jun 2023 09:48:54 GMT, 温绍锦 wrote: >>> Another thing to try is moving fastUUID out of Long - moving to an array of >>> precomputed hex values means it is not tied to Long internals anymore. >> >> A note about `@Stable`: `Integer.digits` and `HEX256` are not, and they >> might see

[jdk21] Integrated: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-21 Thread Per Minborg
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit > [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

Re: RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid

2023-06-21 Thread Per Minborg
On Wed, 21 Jun 2023 00:07:54 GMT, Maurizio Cimadamore wrote: > Possible suggestion/thing to try: use a bullet list to spell out all cases > for `index`. E.g. we know there's index == 0 (all variadic). Then we know > there's index = N (no variadic). Then there's index == m, 0 < m < N - which

Re: [jdk21] RFR: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-21 Thread Per Minborg
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit > [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

Re: [jdk21] RFR: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-20 Thread Per Minborg
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit > [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

RFR: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-19 Thread Per Minborg
Hi all, This pull request contains a backport of commit [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Per Minborg on 16 Jun 2023

Integrated: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-16 Thread Per Minborg
On Tue, 13 Jun 2023 14:13:42 GMT, Per Minborg wrote: > This PR proposes adding `@sealedGraph` to `GroupLayout` so the latter will be > rendered in the javadocs the same way the other layouts that has public > sub-interfaces. This pull request has now been integrated. Changeset:

RFR: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-13 Thread Per Minborg
This PR proposes adding `@sealedGraph` to `GroupLayout` so the latter will be rendered in the javadocs the same way the other layouts that has public sub-interfaces. - Commit messages: - Add @sealedGraph to GroupLayout Changes: https://git.openjdk.org/jdk/pull/14449/files

Re: RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-13 Thread Per Minborg
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache ar

Integrated: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-13 Thread Per Minborg
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache ar

Re: RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Per Minborg
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote: > This PR proposes adding `@Stable` to certain wrapper classes' cache arrays > (e.g. `Integer` and `Long`). > > Comments are welcome as to how to improve the VM's handling now that the > backing cache ar

RFR: 8295555: Primitive wrapper caches could be `@Stable`

2023-06-12 Thread Per Minborg
This PR proposes adding `@Stable` to certain wrapper classes' cache arrays (e.g. `Integer` and `Long`). Comments are welcome as to how to improve the VM's handling now that the backing cache array is `@Stable`. Are there simplifications to be made or are there other optimizations we might add?

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

2023-06-02 Thread Per Minborg
On Fri, 2 Jun 2023 08:08:17 GMT, Per Minborg wrote: >> Right, I guess I'm asking: can/should we do better? ;) It might be nice to >> define the term once and for all for the entire JDK, similar to how >> 'reachability' also has a central definition. (and then add a

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

2023-06-02 Thread Per Minborg
On Thu, 1 Jun 2023 21:47:23 GMT, Jorn Vernee wrote: >> I think the term is used pretty much all over the javadoc (not just FFM's) - >> e.g. look for this preamble: >> >> * > href="{@docRoot}/java.base/java/lang/doc-files/ValueBased.html">value-based, >> * immutable and thread-safe >> ``` >

Re: RFR: 8308281: Java snippets in the FFM API need to be updated [v6]

2023-05-23 Thread Per Minborg
s.java` > class or separate ones for each FFM class. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove last hybrid snippet - Changes: - all: https://git.openjdk.org/jdk/pull/14030/files - new: https://git.openj

Re: RFR: 8308281: Java snippets in the FFM API need to be updated [v5]

2023-05-23 Thread Per Minborg
s.java` > class or separate ones for each FFM class. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge master - Remove hybrid snippets - Use hybrid snippets for Arena - Fix according to commen

Re: RFR: 8308281: Java snippets in the FFM API need to be updated [v4]

2023-05-23 Thread Per Minborg
s.java` > class or separate ones for each FFM class. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove hybrid snippets - Changes: - all: https://git.openjdk.org/jdk/pull/14030/files - new: https://git.openj

Withdrawn: 8307205: Downcall to clibrary printf fails on OS X AArch64

2023-05-23 Thread Per Minborg
On Mon, 22 May 2023 15:21:37 GMT, Per Minborg wrote: > This PR adds a test that shows the documented way of calling `printf` works. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/14088

<    1   2   3   4   5   6   7   >