On Wed, 16 Nov 2022 15:12:41 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> test/jdk/java/io/File/TempDirectoryNotExisting.java line 45:
>
>> 43:
>>
On Mon, 21 Nov 2022 16:35:46 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the
On Wed, 16 Nov 2022 15:06:14 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 52:
>
On Tue, 8 Nov 2022 12:03:06 GMT, Erik Gahlin wrote:
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
Marked as reviewed by coffeys (Reviewer).
LGTM
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
This pull request has now been integrated.
Changeset: 8c40b7dc
Aut
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 11 commits:
>
> -
By moving the JFR event up to the java.security.cert.CertificateFactory class,
we can record all generate cert events, including those from 3rd party
providers. I've also altered the logic so that an event is genertate for every
generate cert call (not just ones missing from the JDK provider
On Thu, 13 Oct 2022 19:19:05 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - test update
>> - Merge branch 'master' into secEvent-8292177
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- remove p
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that.
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contain
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote:
> Fixed to utilize `StaticProperty` so that the system property value for
> `java.locale.useOldISOCodes` set on the command line is honored even with
> lazy `Locale` initialization.
Marked as reviewed by coffeys (Reviewer).
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that.
On Mon, 10 Oct 2022 20:54:58 GMT, Sean Mullan wrote:
>> modified code to have Security class hold the initial properties and
>> provided an accessor method
>
> What about creating a new `JavaSecurityPropertiesAccess` class and moving the
> accessor method there? It seems it would be cleaner to
On Mon, 10 Oct 2022 07:19:30 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurit
On Mon, 10 Oct 2022 14:19:18 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>>
>>> 74: static class JavaSecurityAccessImpl implements JavaSecurityAccess {
>>> 75: /* cache a copy for recording purposes */
>>> 76: static
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Address O
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Check fo
On Fri, 30 Sep 2022 19:32:29 GMT, Sean Mullan wrote:
>> Thanks @egahlin - maybe we can leave it at beginChunk setting then.
>>
>> I've been doing some testing to satisfy myself that the impact of this event
>> on performance is minimal, Running the new `emitInitialSecurityProperties()`
>> is
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
LGTM
-
Marked as reviewed by coffeys (Reviewer).
PR:
On Thu, 29 Sep 2022 11:41:02 GMT, Erik Gahlin wrote:
>> As per yesterday's stack trace, JFR triggers loading of the Security class -
>> so your scenario won't arise with current state. We could include the new
>> Event with period of `endChunk `instead of `beingChunk `setting. That should
>>
On Wed, 28 Sep 2022 16:32:17 GMT, Sean Mullan wrote:
>> Correct - this type of event period (beginChunk) will fire once when the JFR
>> recording is begun. It should capture Security Properties (if
>> java.security.Security is loaded) for any recording, no matter when it might
>> begin or
On Wed, 28 Sep 2022 12:26:49 GMT, Sean Mullan wrote:
>> Yes - the thinking here is that since this is a one time event, we can have
>> it enabled. It's similar to the InitialSystemProperty event.
>>
>> We won't force loading of Security properties/class. We shouldn't at least.
>> If no
On Wed, 28 Sep 2022 07:06:30 GMT, Jaikiran Pai wrote:
> Hello Sean,
>
> > Debug output is also now added for these properties via
> > -Djava.security.debug=properties
>
> Looking at the existing code upstream, it appears that the value `properties`
> is already recognized for
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Null check o
On Tue, 27 Sep 2022 20:29:31 GMT, Sean Mullan wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
New JFR event to record state of initial security properties.
Debug output is also now added for these properties via
-Djava.security.debug=properties
-
Commit messages:
- merge with master
- Correct test bug ids
- fix up imports
- Add security debug test logic
- Add JFR
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
This pull request has now been integrated.
Changeset: bc2af47e
Author: Sean Coffey
URL:
https://git.openjdk.org/jdk/
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Correct Label annontation capitals
-
Changes:
- all:
On Mon, 19 Sep 2022 16:43:26 GMT, Valerie Peng wrote:
>> Yes, I think this would generate too much noise and detract from the main
>> motivation for these events, which is to help users analyze the security of
>> algorithms that are being used by their applications at the JCE layer.
>
> Plus
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
update from review comments
-
Changes:
- all: https://git.openj
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
>
This new event is disabled by default just like the other crypto related events
that were added some time back (e.g. `TLSHands
On Mon, 19 Sep 2022 14:25:55 GMT, Jaikiran Pai wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> src/java.base/share/classes/java/security/Provider.java line 1293:
>
>> 1291: }
>> 1292:
>> 1293: if (s != null &&
On Mon, 19 Sep 2022 15:27:05 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 32:
>>
>>> 30:
>>> 31: import jdk.jfr.Event;
>>> 32: import jdk.jfr.events.*;
>>
>> Hello Sean, r
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Reviewer request: @seanjmullan @egahlin
-
PR: https://git.openjdk.org/jdk/pull/9657
Add a JFR Event for `java.security.Provider.getService(String type, String
algorithm)` calls.
-
Commit messages:
- Track successful getInstance calls only
- Merge branch 'master' into 8254711-jfr-jca
- Refactor and use of static Event on
- Merge branch 'master' into
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
Marked as reviewed by coffeys (Reviewer).
test/jdk/java/util/TimeZone/tools/share/makeZoneData.pl line 32:
> 30: # static TimeZoneData.
> 31: # For J2SE since JDK1.4,
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
1 minor comment. Looks good to me.
test/jdk/java/util/TimeZone/tools/share/Makefile line 33:
> 31: #
> 32:
> 33: TZDATA =
101 - 139 of 139 matches
Mail list logo
