Integrated: 8331077 : nroff man page update for jar tool

2024-05-02 Thread Weibing Xiao
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of  > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was n

Re: RFR: 8331077 : nroff man page update for jar tool

2024-05-01 Thread Weibing Xiao
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of  > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was n

Re: RFR: 8331077 : nroff man page update for jar tool [v2]

2024-05-01 Thread Weibing Xiao
> nroff man page update for jar tool. > This update is caused by the change of  > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated t

RFR: 8331077 : nroff man page update for jar tool

2024-05-01 Thread Weibing Xiao
nroff man page update for jar tool. This update is caused by the change of  https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos - Commit messages: - 8331077 : nroff

Withdrawn: 8331077 : nroff man page update for jar tool

2024-05-01 Thread Weibing Xiao
On Wed, 1 May 2024 14:54:02 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page wa

Re: RFR: 8331077 : nroff man page update for jar tool [v3]

2024-05-01 Thread Weibing Xiao
On Wed, 1 May 2024 16:15:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> >> This update is caused by the change of >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nr

Re: RFR: 8331077 : nroff man page update for jar tool [v3]

2024-05-01 Thread Weibing Xiao
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao ha

Re: RFR: 8331077 : nroff man page update for jar tool [v2]

2024-05-01 Thread Weibing Xiao
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao ha

RFR: 8331077 : nroff man page update for jar tool

2024-05-01 Thread Weibing Xiao
nroff man page update for jar tool. This update is caused by the change of https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos - Commit messages: - 8331077 : nroff

[jdk22] Integrated: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-11 Thread Weibing Xiao
On Wed, 10 Jan 2024 17:42:21 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > > It needs to be backported to JDK22. This pull request has now been integrated. Changeset: 3daa936f Author: Weibing Xiao Committer: Jaikiran

[jdk22] Withdrawn: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-10 Thread Weibing Xiao
On Wed, 10 Jan 2024 17:02:03 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > It is a clean backport. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk22/pull/55

Re: [jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-10 Thread Weibing Xiao
On Wed, 10 Jan 2024 17:02:03 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > It is a clean backport. Use this PR instead https://github.com/openjdk/jdk22/pull/56. - PR Comment: https://git.openjdk.org/jdk22/pull/55#issuec

[jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-10 Thread Weibing Xiao
Better Error Handling for Jar Tool When Processing Non-existent Files. It needs to be backported to JDK22. - Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk22/pull/56/files Webrev:

[jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-10 Thread Weibing Xiao
Better Error Handling for Jar Tool When Processing Non-existent Files. It is a clean backport. - Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk22/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk22=55=00

Integrated: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files

2024-01-08 Thread Weibing Xiao
On Wed, 13 Dec 2023 18:16:56 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull

Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v4]

2023-12-20 Thread Weibing Xiao
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull re

Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v2]

2023-12-19 Thread Weibing Xiao
On Tue, 19 Dec 2023 17:24:15 GMT, Weibing Xiao wrote: >> Better Error Handling for Jar Tool Processing of "@File" >> >> This is a new PR for this PR since the original developer left the team. See >> all of the review history at https://github.com/openjd

Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v3]

2023-12-19 Thread Weibing Xiao
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull re

Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v2]

2023-12-19 Thread Weibing Xiao
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull re

RFR: 8318971 : Better Error Handling for Jar Tool Processing of @File

2023-12-13 Thread Weibing Xiao
Better Error Handling for Jar Tool Processing of "@File" This is a new PR for this PR since the original developer left the team. See all of the review history at https://github.com/openjdk/jdk/pull/16423. Thank you. - Commit messages: - 8318971 : Better Error Handling for Jar

Integrated: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2023-11-30 Thread Weibing Xiao
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > s

Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2023-11-30 Thread Weibing Xiao
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > s

RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2023-11-30 Thread Weibing Xiao
File.mkdirs() occasionally fails to create folders on Windows shared folders. It turned out that Windows API FindFirstFileW created the error ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error still returns this error code, which supposedly should not. Adding this

Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2023-11-30 Thread Weibing Xiao
On Mon, 6 Nov 2023 20:19:25 GMT, Brian Burkhalter wrote: >> src/java.base/windows/native/libjava/canonicalize_md.c line 142: >> >>> 140: || (errval == ERROR_NETWORK_UNREACHABLE) >>> 141: || (errval == ERROR_NETWORK_ACCESS_DENIED) >>> 142: || (errval ==

Integrated: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection

2023-08-25 Thread Weibing Xiao
On Tue, 15 Aug 2023 17:30:54 GMT, Weibing Xiao wrote: > Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v14]

2023-08-24 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v13]

2023-08-24 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: format the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v12]

2023-08-24 Thread Weibing Xiao
On Thu, 24 Aug 2023 18:45:01 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v12]

2023-08-24 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code according to code review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]

2023-08-23 Thread Weibing Xiao
On Tue, 22 Aug 2023 18:21:17 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v11]

2023-08-23 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactoring the code according to the comment - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]

2023-08-22 Thread Weibing Xiao
On Tue, 22 Aug 2023 18:21:17 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]

2023-08-22 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: format the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]

2023-08-22 Thread Weibing Xiao
On Mon, 21 Aug 2023 22:10:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]

2023-08-21 Thread Weibing Xiao
On Mon, 21 Aug 2023 22:10:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]

2023-08-21 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: use original logic to create socket to avoid the compatibility issue - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files -

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v7]

2023-08-21 Thread Weibing Xiao
On Sat, 19 Aug 2023 02:15:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v8]

2023-08-21 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code based on the review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]

2023-08-18 Thread Weibing Xiao
On Fri, 18 Aug 2023 13:30:54 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v7]

2023-08-18 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactor the code and test cases - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]

2023-08-18 Thread Weibing Xiao
On Fri, 18 Aug 2023 13:20:50 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]

2023-08-18 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: re-write close method - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]

2023-08-18 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the Connection code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v4]

2023-08-17 Thread Weibing Xiao
On Thu, 17 Aug 2023 21:20:04 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v4]

2023-08-17 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactor the code and remove pre-created keystore - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v2]

2023-08-16 Thread Weibing Xiao
On Wed, 16 Aug 2023 22:49:24 GMT, Mark Sheppard wrote: >> Weibing Xiao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test code > > test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeFailur

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v3]

2023-08-16 Thread Weibing Xiao
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v3]

2023-08-16 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updated the code according to the review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.

Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v2]

2023-08-16 Thread Weibing Xiao
he format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the test code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/

RFR: 8314063 : The socket is not closed in Connection::createSocket when t…

2023-08-15 Thread Weibing Xiao
Please refer to JDK-8314063. The failure scenario is due to the setting of connection timeout. It is either too small or not an optimal value for the system. When the client tries to connect to the server with LDAPs protocol. It requires the handshake after the socket is created and connected,

Integrated: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-14 Thread Weibing Xiao
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote: > com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/bro

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]

2023-08-14 Thread Weibing Xiao
On Wed, 9 Aug 2023 12:52:35 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v6]

2023-08-14 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull reques

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v4]

2023-08-09 Thread Weibing Xiao
On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]

2023-08-09 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull reques

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]

2023-08-08 Thread Weibing Xiao
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v4]

2023-08-08 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull reques

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]

2023-08-04 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull reques

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]

2023-08-04 Thread Weibing Xiao
On Fri, 4 Aug 2023 18:24:04 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]

2023-08-04 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull reques

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Weibing Xiao
On Thu, 3 Aug 2023 17:59:10 GMT, Alan Bateman wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

2023-08-04 Thread Weibing Xiao
com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if the is an IOException generation when the output stream was flushing the buffer. Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. - Commit messages: - reformat the code - remove

Integrated: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64

2022-11-28 Thread Weibing Xiao
On Mon, 28 Nov 2022 16:52:09 GMT, Weibing Xiao wrote: > fix the illegal characters of directory names in Windows This pull request has now been integrated. Changeset: cdf9ed07 Author: Weibing Xiao Committer: Roger Riggs URL: https://git.openjdk.org/jdk/com

RFR: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64

2022-11-28 Thread Weibing Xiao
fix the illegal characters of directory names in Windows - Commit messages: - fix illegal charater of directory name in Windows Changes: https://git.openjdk.org/jdk/pull/11393/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11393=00 Issue:

Integrated: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-11-23 Thread Weibing Xiao
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote: > print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. This pull request has now been integrated. Changeset: 8df3bc4e Author:Weibing Xiao Com

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v5]

2022-11-21 Thread Weibing Xiao
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update according to the review co

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-11-18 Thread Weibing Xiao
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updated from the review c

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v3]

2022-11-18 Thread Weibing Xiao
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update according to review c

Withdrawn: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-11-17 Thread Weibing Xiao
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9989

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-11-17 Thread Weibing Xiao
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-11-16 Thread Weibing Xiao
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote: > print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. 1) Removed the link for CSR. 2) Add a new method in SystemProps.java to check if the warning m

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v2]

2022-11-16 Thread Weibing Xiao
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: the change according to review c

RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-11-15 Thread Weibing Xiao
print warning message for java.io.tmpdir when it is set through the command line and the value is not good for creating file folder. - Commit messages: - remove extra line - warning message for java.io.tmpdir Changes: https://git.openjdk.org/jdk/pull/11174/files Webrev:

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-17 Thread Weibing Xiao
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Weibing Xiao
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-14 Thread Weibing Xiao
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into improve-directory-not-existing

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v3]

2022-10-14 Thread Weibing Xiao
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request co

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-09-08 Thread Weibing Xiao
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist 1) Remove the setting in java.security, not displaying the folder name of java.io.tmpdir 2) Add the change for NIO 3) Update the testing fi

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v2]

2022-09-08 Thread Weibing Xiao
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: add the change for nio and update the code according to the comments - C

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-09-07 Thread Weibing Xiao
On Wed, 24 Aug 2022 04:42:54 GMT, David Schlosnagle wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > src/java.base/share/classes/java/io/File.java line 2180: > >> 2178: >> 2179: >> 2180: if(!tmpdir.exists() || !tmpdir.canWrite()) {

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-09-07 Thread Weibing Xiao
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist CSR https://bugs.openjdk.org/browse/JDK-8293246 - PR: https://git.openjdk.org/jdk/pull/9989

RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist

2022-09-07 Thread Weibing Xiao
8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist - Commit messages: - new approach - change based on the review - updating according to the comments - Merge branch 'master' of https://github.com/openjdk/jdk into