On Mon, 1 Jul 2024 18:22:48 GMT, Chen Liang wrote:
> Clarify that `ParameterizedType.getOwnerType()` always return `null` in a few
> scenarios.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19977
On Mon, 1 Jul 2024 19:20:48 GMT, Chen Liang wrote:
> Clarify that only `Class` is returned for core reflection implementation, and
> the return type is `Type` to support other implementations, such as ones
> modeling unloaded or remote types.
This pull request has been closed without being int
On Mon, 23 Sep 2024 19:24:51 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.tanh() using libm
>>
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
On Tue, 2 Jul 2024 12:20:17 GMT, Yasumasa Suenaga wrote:
> We cannot pass GNU style options like `--enable-preview` to `jlink
> --add-option`. It is hard to use for complex application.
>
> We have workaround for this issue (see JBS), but I think it is better to fix
> on JDK side.
This pull r
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods c
On Thu, 25 Jul 2024 22:18:03 GMT, Justin Lu wrote:
> Please review this PR which adds public StringBuilder overloads to the
> formatting methods of java.text.Format and implementing subclasses.
>
> While Format, NumberFormat, and DateFormat are abstract, these new methods
> are not added as ab
On Tue, 17 Sep 2024 15:23:41 GMT, Rafael Winterhalter
wrote:
>> When a type uses a type variable without a declaration, no exception is
>> thrown. This change triggers a `TypeNotFoundException` to be thrown.
>
> Rafael Winterhalter has updated the pull request incrementally with one
> addition
On Mon, 16 Sep 2024 12:56:14 GMT, David M. Lloyd wrote:
> Please review this small change to fix a misspelling. The constant is not
> used directly; rather it is used by ordinal, which explains why the error was
> not found sooner.
@dmlloyd
Your change (at version d74e7908602eb50c8a89ee5767aa
On Sun, 21 Jul 2024 13:29:36 GMT, Technici4n wrote:
> Hi,
>
> Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the
> `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for
> example.
>
> There has been some discussion on nio-dev about more broadl
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
@nizarbenalla
Your change (at version f7cead81b09d392d673b
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 01:53:01 GMT, Shaojin Wen wrote:
>> This is a follow-up to PR #20273, which improves performance when the number
>> of parameters exceeds 20.
>>
>> When the number of parameters is large, the possibility of reuse will be
>> lower, so we can use the static concat method and w
On Wed, 12 Jun 2024 10:45:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed
On Thu, 18 Apr 2024 13:53:34 GMT, Oussama Louati wrote:
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
> MethodType, and CallSite constants.
> ### Purpose of Indify
>
> - **Transformati
On Fri, 6 Sep 2024 00:21:07 GMT, Shaojin Wen wrote:
>> A small optimization, when CompactStrings is turned off, the coder method is
>> not generated, which improves the startup performance
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last rev
On Thu, 5 Sep 2024 22:47:00 GMT, Shaojin Wen wrote:
>> A small optimization, optimize the BufferWriter implementation and use of
>> ClassFile, provide faster patchInt and skip
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote:
>> A small optimization to improve the performance of
>> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove benc
On Thu, 5 Sep 2024 00:48:26 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggesti
On Tue, 3 Sep 2024 17:33:37 GMT, David M. Lloyd wrote:
>> Please review this change, which reduces the number of allocations in
>> `StackMapDecoder::writeFrames` by using a sorted array instead of a
>> `TreeMap` to sort and uniquify entries before writing. It also
>> adds a validation missed b
On Mon, 2 Sep 2024 14:50:33 GMT, Shaojin Wen wrote:
>> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size
>> greater than 325, break it into multiple small methods and call them
>> directly in DirectCodeBuilder
>
> Shaojin Wen has updated the pull request incrementally
On Fri, 17 May 2024 12:01:23 GMT, Chen Liang wrote:
> Core reflection's generic signature parsing uses an ancient library with
> outdated visitor pattern on a tree model and contains unnecessary
> boilerplates. This is a duplication of ClassFile API's signature model. We
> should just move to
On Wed, 28 Aug 2024 13:16:03 GMT, Shaojin Wen wrote:
> A small optimization makes BufWriterImpl's writeU1/U2/Int/Long methods more
> C2-friendly and improves performance.
@wenshao
Your change (at version cd1140c1782255a5a1fcaaac89a37d21bf32582b) is now ready
to be sponsored by a Committer.
-
On Wed, 28 Aug 2024 13:12:35 GMT, Shaojin Wen wrote:
> A small optimization to improve the performance of
> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot
@wenshao
Your change (at version 3c58fab74c9f78b7f3008c4f6fa32a7aab79f053) is now ready
to be sponsored by a Committer.
-
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
@wenshao
Your change (at version 9d7cc54c449d4e12d0eb30c103e8aa3aaf206b6d) is now ready
to be s
On Mon, 1 Jul 2024 21:48:44 GMT, Chen Liang wrote:
> `Method.invoke` and `Constructor.newInstance` wraps `Error` in
> `InvocationTargetException`, which is bug-prone for users. Worse, this is
> only ambiguously mentioned in the API specification.
>
> This patch proposes to explicitly mention t
On Sun, 25 Aug 2024 21:40:14 GMT, Shaojin Wen wrote:
>> optimize the construction of MethodType and MethodTypeDesc to reduce memory
>> allocate
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use MethodTypeDescImpl.ofValida
On Thu, 30 May 2024 12:50:36 GMT, Claes Redestad wrote:
> Extracting duplicate method references to static field reduce proxy class
> spinning and loading. In this case 2 less classes loaded when using
> `findAny()` on each type of stream.
This pull request has been closed without being integr
On Tue, 20 Aug 2024 12:39:14 GMT, Shaojin Wen wrote:
>> The current implementation of ofDescriptor puts return type and parameter
>> types together in an ArrayList, and then splits them into return type and
>> array of parameter types. This ArrayList creation is unnecessary,
>> considering mos
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote:
> This is a test-only addition to add a test for virtual threads invoking a
> synchronized native method and invoking a native method that enter/exits a
> monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo
> for so
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote:
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> di
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote:
> j.u.Formatter$FixedString can be refactored to simplify the code using Record
@wenshao
Your change (at version c7ce3c724183ad3b4a09a9fac1d7411fdd8e) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.op
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote:
>> This PR implements the same algorithm as the current generateMHInlineCopy
>> based on bytecode to improve startup performance.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision
On Fri, 26 Jul 2024 06:29:05 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
On Thu, 20 Jun 2024 19:17:25 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to s
On Mon, 10 Jun 2024 02:12:11 GMT, Glavo wrote:
> Things have changed since https://github.com/openjdk/jdk/pull/14636 was
> closed, so let me reopen it.
>
> https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE
> caused a startup regression. In order to not have any more
On Thu, 6 Oct 2022 06:28:04 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated instruc
On Mon, 5 Feb 2024 04:25:16 GMT, Chris Hennick wrote:
> This provides a slightly more accurate bounding limit for
> `computeNextExponentialSoftCapped` when calling it from
> `computeNextGaussian`. This could cause the `while
> (computeNextExponentialSoftCapped(rng, limit) < limit)` check in
>
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote:
>> Similar to how `MethodHandle#invoke(Exact)` methods are already handled,
>> this change adds special casing for `VarHandle.{access-mode}` methods.
>>
>> The exception message is less exact, but I think that's acceptable.
>
> Hannes Greule
On Tue, 30 Jul 2024 05:59:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 26 Jul 2024 00:00:49 GMT, Shaojin Wen wrote:
> 8337245: Fix wrong comment of StringConcatHelper
@wenshao
Your change (at version d453e6c2837cf7d8802f7fea624324361e085edf) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/20344#iss
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote:
>> Integer.stringSize and Long.stringSize are used not only in java.lang, but
>> also in other places. We put stringSize in DecimalDigits to reduce duplicate
>> code and the use of JLA.
>
> Shaojin Wen has updated the pull request incremental
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
@wenshao
Your change (at versio
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote:
>> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We
>> need a JMH Benchmark to evaluate the performance of various batch operations
>> and the effect of MergeStore.
>
> Shaojin Wen has updated the pull request with
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote:
>> class LocalTime {
>> public String toString() {
>> // ...
>> if (nanoValue % 1000_000 == 0) {
>> buf.append(Integer.toString((nanoValue / 1000_000) +
>> 1000).substring(1));
>>
On Tue, 23 Jul 2024 12:56:07 GMT, Shaojin Wen wrote:
>> Currently simpleConcat is implemented using mix and prepend, but in this
>> simple scenario, it can be implemented in a simpler way and can improve
>> performance.
>
> Shaojin Wen has updated the pull request incrementally with one additio
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Mon, 15 Jul 2024 02:30:54 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Wed, 20 Sep 2023 04:52:31 GMT, Chen Liang wrote:
> Please review this patch that:
> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
> 2. Implemented `spliterator` to optimize for a single element.
>
> The default implementations for multiple-element immutable collections
On Thu, 18 Jul 2024 05:21:36 GMT, Shaojin Wen wrote:
> class LocalDate {
> public String toString() {
> if (absYear < 1000) {
> if (yearValue < 0) {
> buf.append(yearValue - 1).deleteCharAt(1);
> } else {
> buf.append(yearVal
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote:
> The StringBuilder.repeat method was added in JDK 21, which can be used to
> make some minor optimizations to existing code, including
> DateTimeFormatterBuilder
@wenshao
Your change (at version db3027b03030304dbec990c943eff0f037363e37) is
On Tue, 21 May 2024 22:56:45 GMT, Justin Lu wrote:
> Please review this test-only clean up PR which converts the java.util.Base64
> tests to run under JUnit.
>
> In general, this allows for the tests to run independently, separates the
> data providers from the tests, as well being able to uti
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this simple patch?
> Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not
> necessary, could be removed.
> Thanks
This pull request has been closed without being integrated.
-
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote:
> Hi all,
> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the
> footprint memory usage increased significantly when run the testcase with
> -Xcomp jvm options, then cause the testcase was killed by docker by OOM.
> Maybe
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Mon, 3 Jun 2024 18:00:35 GMT, Sean Gwizdak wrote:
>> Improve the speed of Method.hashCode by caching the hashcode on first use.
>> I've seen an application where Method.hashCode is a hot path, and this is a
>> fairly simple speedup. The memory overhead is low.
>>
>> This addresses issue
>
On Wed, 10 Jul 2024 22:02:12 GMT, Shaojin Wen wrote:
>> The current HexFormat defines an Enum to represent LowerCase and UpperCase
>>
>>
>> class HexFormat {
>> private enum Case {
>> LOWERCASE,
>> UPPERCASE
>> }
>> }
>>
>>
>> This will cause the JVM to load one more c
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Wed, 1 May 2024 22:39:05 GMT, Chen Liang wrote:
>> API changes as discussed on the mailing list:
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html
>>
>> Additional questions:
>> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE`
>
> Chen Liang has upda
On Wed, 29 May 2024 19:27:17 GMT, Chen Liang wrote:
>> I propose to add type-checked ConstantPool.entryByIndex and
>> ClassReader.readEntryOrNull taking an extra Class parameter, which throws
>> ConstantPoolException instead of ClassCastException on type mismatch, which
>> can happen to malfor
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based ne
On Sun, 12 May 2024 02:42:32 GMT, Chen Liang wrote:
>> Summary of the changes:
>> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps;
>> they are exclusively used by jdeps in sources, and they are not used in any
>> tests too. This will ease the removal of `com.sun.tools.
On Fri, 10 May 2024 04:55:21 GMT, Chen Liang wrote:
>> GenerateJLIClassesHelper has been making wrong assumptions about Invoker's
>> LambdaForm method type parameters. Since they are distinct from those of
>> Linkers, they are now tracked and generated separately. It seems that no
>> proper in
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method fo
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
On Tue, 9 Jul 2024 16:12:58 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote:
> Add API to access ZipEntry.extraAttributes
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19204
On Wed, 27 Mar 2024 10:24:51 GMT, Jan Lahoda wrote:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The curr
On Fri, 28 Jun 2024 11:11:51 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote:
> In JDK 21, StringBuilder added a repeat method, which can be used to improve
> j.u.Formatter#trailingZeros
@wenshao
Your change (at version a98bd05c857d0a04dfad471dd28f905be1345376) is now ready
to be sponsored by a Committer.
---
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote:
>> Can I please get a review for this small change? The motivation is that
>> javac does not recognize `package.html` files.
>>
>> The conversion was simple, I used a script to rename the files, append "*"
>> on the left and remove some HTM
On Wed, 7 Feb 2024 16:07:02 GMT, Hamlin Li wrote:
> HI,
> Can you have a look at this patch adding some tests for Math.round
> instrinsics?
> Thanks!
>
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only
> spotted by running test exhaustively against 32/6
On Tue, 23 Jan 2024 13:04:43 GMT, SendaoYan wrote:
>> 8323640: [TESTBUG]testMemoryFailCount in
>> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail
>> because OOM killed
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last rev
On Thu, 18 Jan 2024 18:50:56 GMT, Jim Laskey wrote:
> Currently String::translateEscapes does not support unicode escapes, reported
> as a IllegalArgumentException("Invalid escape sequence: ...").
> String::translateEscapes should translate unicode escape sequences to provide
> full coverage,
On Fri, 28 Jun 2024 12:46:49 GMT, Shaojin Wen wrote:
>> Currently, the java.util.Formatter$Conversion::isValid method is implemented
>> based on switch, which cannot be inlined because codeSize > 325. This
>> problem can be avoided by implementing it with ImmutableBitSetPredicate.
>>
>> use `-
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.
On Sun, 10 Mar 2024 16:11:12 GMT, Shaojin Wen wrote:
> The current BigDecimal(String) constructor calls String#toCharArray, which
> has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is g
On Fri, 5 Apr 2024 00:00:58 GMT, Evemose wrote:
> **Subject**
> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
> `java.util.List`
>
> **Motivation**
> The motivation behind this proposal is to enhance the functionality of the
> `List` interface by providing a more flexible
On Fri, 1 Sep 2023 15:13:46 GMT, Martin Balao wrote:
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of
On Tue, 2 Apr 2024 15:04:40 GMT, Per Minborg wrote:
> This PR proposes to add an internal layout transformer that could be used to
> transform MemoryLayout entities. For example, it would be possible to convert
> a struct layout to use network order ((big-endian) instead of native byte
> order
On Wed, 24 Jan 2024 00:26:09 GMT, Joshua Cao wrote:
> Add notes for `HashMap::putAll()` conservative resizing.
>
> Note: everything below this line is from the original change. After
> discussion, we decided to keep the conservative resizing, but we should add
> an `@implNote` for the decision
On Tue, 16 Jan 2024 07:40:44 GMT, John Hendrikx wrote:
> Update the documentation for `@return` tag of `putIfAbsent` to match the main
> description. `putIfAbsent` uses the same wording as `put` for its `@return`
> tag, but that is incorrect. `putIfAbsent` never returns the **previous**
> val
On Wed, 10 Jan 2024 20:54:20 GMT, Peter Levart wrote:
> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It
> returns `-1` (meaning that regions are equal) when passing the same instance
> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless
> of
On Fri, 9 Feb 2024 23:40:00 GMT, Dan Lutker wrote:
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
This pull request has been closed without being integrated.
On Thu, 25 Jan 2024 21:35:45 GMT, Sergey wrote:
> The feature allows to extract a private field value in a single expression,
> like so:
>
> object.getClass().getDeclaredField().setAccessible().get(object)
This pull request has been closed without being integrated.
-
PR: https://
On Sun, 26 Nov 2023 16:52:40 GMT, fabioromano1 wrote:
> A faster and simpler way to generate random BigIntegers, avoiding eventually
> trimming of leading zeros in magnitude array.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/1
On Mon, 18 Dec 2023 13:42:35 GMT, Sergey Tsypanov wrote:
> Currently if we create a record it's fields are compared in their declaration
> order. This might be ineffective in cases when two objects have "heavy"
> fields equals to each other, but different "lightweight" fields (heavy and
> ligh
On Sat, 6 Jan 2024 18:01:01 GMT, fabioromano1 wrote:
> The method `MutableBigInteger.divWord(long, int)` can use the algorithm of
> Hacker's Delight (2nd ed), section 9.3, the same used in
> `Long.divideUnsigned(long, long)` and `Long.remainderUnsigned(long, long)`,
> to get the computation fa
On Tue, 16 Jan 2024 10:19:44 GMT, Andrey Turbanov wrote:
> There are 3 methods in `java.util.TimeZone` which are `public static` and
> marked as `synchronized`:
> 1. getTimeZone(String)
> 2. getAvailableIDs(int)
> 3. getAvailableIDs()
>
> This means it is a bottle neck for the whole VM.
> I've
On Tue, 23 Jan 2024 08:10:54 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch introduces `JitCompiler::isConstantExpression` which can be used
> to statically determine whether an expression has been constant-folded by the
> Jit compiler, leading to more constant-folding opportunities. For exampl
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing an archive if there is a
> missing file supplied.
> The current behaviour will recognise missing files as an error but continue
> processing,
> creating a temporary archive and
On Mon, 11 Dec 2023 01:28:29 GMT, Valeh Hajiyev wrote:
> This commit addresses the current limitation in the `PriorityQueue`
> implementation, which lacks a constructor to efficiently create a priority
> queue with a custom comparator and an existing collection. In order to create
> such a que
On Thu, 21 Sep 2023 12:51:56 GMT, Raffaello Giulietti
wrote:
> By correctly sizing an intermediate `byte[]` and making use of the internal
> `newStringNoRepl()` method, one allocation per conversion can be avoided when
> the runtime uses compact strings.
This pull request has been closed with
On Thu, 14 Dec 2023 12:39:52 GMT, Adam Sotona wrote:
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments an
On Wed, 18 Oct 2023 06:12:29 GMT, Xiaohong Gong wrote:
> Currently the vector floating-point math APIs like
> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
> which causes large performance gap on AArch64. Note that those APIs are
> optimized by C2 compiler on X86 p
1 - 100 of 207 matches
Mail list logo
