Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-09-25 Thread Chen Liang
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that adds a new dynamic proxies implementation as > hidden classes. > > Summary: > 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true` > for early adoption. > 2. ClassLoader.defineClass0 tak

Re: RFR: 8242888: Convert dynamic proxy to hidden classes [v2]

2024-09-25 Thread Chen Liang
On Mon, 27 May 2024 00:04:07 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Flip flags, hidden is enabled only by choice >> - Merge branch 'master' of https://github.com/op

Re: RFR: 8242888: Convert dynamic proxy to hidden classes [v2]

2024-09-25 Thread Chen Liang
> Please review this change that adds a new dynamic proxies implementation as > hidden classes. > > Summary: > 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true` > for early adoption. > 2. ClassLoader.defineClass0 takes a ClassLoader instance but discards it in > native

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-26 Thread Chen Liang
On Mon, 27 May 2024 00:03:41 GMT, ExE Boss wrote: >> Please review this change that convert dynamic proxies implementations to >> hidden classes, intended to target JDK 24. >> >> Summary: >> 1. Adds new implementation while preserving the old implementation behind >> `-Djdk.reflect.useLegacyPr

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-26 Thread ExE Boss
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that convert dynamic proxies implementations to > hidden classes, intended to target JDK 24. > > Summary: > 1. Adds new implementation while preserving the old implementation behind > `-Djdk.reflect.useLegacyProxyI

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-24 Thread Alan Bateman
On Thu, 23 May 2024 23:24:16 GMT, Chen Liang wrote: > Hmm, actually, looking at the specs of the method again, does it imply that > Proxy classes are never unloaded once defined in a ClassLoader, as seen in > `Proxy::getProxyClass`: It's not specified, Proxy pre-dates hidden classes although i

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Chen Liang
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that convert dynamic proxies implementations to > hidden classes, intended to target JDK 24. > > Summary: > 1. Adds new implementation while preserving the old implementation behind > `-Djdk.reflect.useLegacyProxyI

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Alan Bateman
On Thu, 23 May 2024 13:28:16 GMT, Chen Liang wrote: > I have updated the compatibility risk description of the CSR. > > My CSR proposes to allow dynamic unloading of the proxy implementation > classes, but currently it's not implemented as they are strongly referenced > in the ClassLoaderValue

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread forax
> From: "-" > To: "Remi Forax" > Cc: "Chen Liang" , "core-libs-dev" > , "hotspot-dev" , > "kulla-dev" > Sent: Thursday, May 23, 2024 2:56:58 PM > Subject: Re: RFR: 8242888: Convert dynamic proxy to hidden classes

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Chen Liang
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that convert dynamic proxies implementations to > hidden classes, intended to target JDK 24. > > Summary: > 1. Adds new implementation while preserving the old implementation behind > `-Djdk.reflect.useLegacyProxyI

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Chen Liang
penjdk.org > > Sent: Thursday, May 23, 2024 1:28:01 PM > > Subject: Re: RFR: 8242888: Convert dynamic proxy to hidden classes > > > On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > > > >> Please review this change that convert dynamic proxies implementation

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Remi Forax
- Original Message - > From: "Chen Liang" > To: "core-libs-dev" , "hotspot-dev" > , kulla-...@openjdk.org > Sent: Thursday, May 23, 2024 1:28:01 PM > Subject: Re: RFR: 8242888: Convert dynamic proxy to hidden classes > On Thu, 23 May 20

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Alan Bateman
On Thu, 23 May 2024 11:25:00 GMT, Chen Liang wrote: > A CSR targeting 24 describing the compatibility concerns and behavioral > differences is here, somehow not linked by skara: > https://bugs.openjdk.org/browse/JDK-8332770 The incompatibilities were much > greater in the previous iterations o

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-23 Thread Chen Liang
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that convert dynamic proxies implementations to > hidden classes, intended to target JDK 24. > > Summary: > 1. Adds new implementation while preserving the old implementation behind > `-Djdk.reflect.useLegacyProxyI

Re: RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-22 Thread Alan Bateman
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that convert dynamic proxies implementations to > hidden classes, intended to target JDK 24. > > Summary: > 1. Adds new implementation while preserving the old implementation behind > `-Djdk.reflect.useLegacyProxyI

RFR: 8242888: Convert dynamic proxy to hidden classes

2024-05-22 Thread Chen Liang
Please review this change that convert dynamic proxies implementations to hidden classes, intended to target JDK 24. Summary: 1. Adds new implementation while preserving the old implementation behind `-Djdk.reflect.useLegacyProxyImpl=true` in case there are compatibility issues. 2. ClassLoader.d