On Wed, 30 Aug 2023 22:01:28 GMT, Brent Christian wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - update mode to be int rather than long
>> - update tests
>> - Review feedback on javadoc
>
>
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Wed, 30 Aug 2023 16:29:31 GMT, Mandy Chung wrote:
> Indeed, Set.of factory methods are easy to use. I'm okay with taking it out.
It would be easy to add in the future if needed, say if more options were
introduced and the common case requires 2 or more options.
-
PR Comment:
On Wed, 30 Aug 2023 15:31:27 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/StackStreamFactory.java line 694:
>>
>>> 692: // no method information is available; should just filter
>>> 693: // "Continuation::yield0".
>>> 694: return
On Wed, 30 Aug 2023 07:09:34 GMT, Alan Bateman wrote:
> The updated proposal/javadoc looks good, just in two minds on whether the
> overload with the varargs should be added. The Set.of factory methods make is
> really easy to use the existing getInstance(Set) method.
Indeed, Set.of factory
On Wed, 30 Aug 2023 15:03:27 GMT, Daniel Fuchs wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - update mode to be int rather than long
>> - update tests
>> - Review feedback on javadoc
>
>
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
> 8268829: Provide an optimized way to walk the stack with Class object only
>
> `StackWalker::walk` creates one `StackFrame` per frame and the current
> implementation
> allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some
> frameworks
> like logging may only interest in