Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Mandy Chung
On Wed, 6 Sep 2023 21:35:49 GMT, Brent Christian wrote: >> Some benchmarks need the Class reference but some do not. For simplicity, >> use only walkers that retain Class reference so that all benchmarks can run >> with the default walker. > > In my mind, a "default" StackWalker (obtained

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Brent Christian
On Tue, 5 Sep 2023 17:52:44 GMT, Mandy Chung wrote: >> test/micro/org/openjdk/bench/java/lang/StackWalkBench.java line 64: >> >>> 62: default -> throw new IllegalArgumentException(name); >>> 63: }; >>> 64: } >> >> The previous `WALKER_DEFAULT` would not have retained

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Mandy Chung
On Thu, 31 Aug 2023 23:17:02 GMT, Brent Christian wrote: >> Mandy Chung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - Merge >> - Remove the new getInstance method taking varargs >> - update mode to be int

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-05 Thread Joe Darcy
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-05 Thread Mandy Chung
On Tue, 5 Sep 2023 16:44:24 GMT, Brent Christian wrote: >> Mandy Chung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - Merge >> - Remove the new getInstance method taking varargs >> - update mode to be int

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-05 Thread Brent Christian
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-01 Thread Alan Bateman
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-08-31 Thread Mandy Chung
> 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some > frameworks > like logging may only interest in