On Mon, 4 Jul 2022 19:30:50 GMT, Alan Bateman wrote:
> The updated TestDelegation test is looking a bit better now but I think it
> would be simplified a lot more by getting rid of the data providers, just
> aren't needed in this test.
Unless you feel this is a must, I would prefer to keep
On Tue, 5 Jul 2022 09:54:15 GMT, Lance Andersen wrote:
> Unless you feel this is a must, I would prefer to keep the DataProviders. The
> benefit I see is the test code does not need to be duplicated per parameter,
> each test scenario can be run as an individual test so that you do not need
>
On Tue, 5 Jul 2022 19:17:27 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
On Tue, 5 Jul 2022 10:56:45 GMT, Alan Bateman wrote:
> > Unless you feel this is a must, I would prefer to keep the DataProviders.
> > The benefit I see is the test code does not need to be duplicated per
> > parameter, each test scenario can be run as an individual test so that you
> > do
On Mon, 4 Jul 2022 19:30:40 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
On Mon, 27 Jun 2022 16:43:55 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
On Sun, 26 Jun 2022 13:33:40 GMT, Lance Andersen wrote:
> I thought about using TestProvider and then talked myself out of it. So yes,
> I can do that. If you have a preferred name other than
> `TestOverRideFSPMethods` please let me know
The only change that should be needed to TestProvider
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
On Sun, 26 Jun 2022 13:13:35 GMT, Alan Bateman wrote:
> The implementation changes in latest version address my previous points,
> thanks! I don't the test as it duplicates most of the existing of the
> TestProvider in this directory and the naming is inconsistent with the
> existing tests. I
On Sun, 26 Jun 2022 11:13:58 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption...
On Thu, 23 Jun 2022 07:18:07 GMT, Alan Bateman wrote:
>> src/java.base/unix/classes/sun/nio/fs/UnixFileAttributes.java line 80:
>>
>>> 78: static UnixFileAttributes getIfExists(UnixPath path) throws
>>> UnixException {
>>> 79: UnixFileAttributes attrs = new UnixFileAttributes();
On Thu, 23 Jun 2022 10:55:00 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 22:26:23 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> -
On Thu, 23 Jun 2022 08:05:42 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
On Wed, 22 Jun 2022 22:18:05 GMT, Brian Burkhalter wrote:
> I think that this is the only use of `stat2()`. It could be deleted if this
> method were replaced with this:
The purpose of these additions to the SPI is to improve the performance of user
facing methods that don't throw an
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
On Wed, 22 Jun 2022 19:54:47 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java line
>> 1218:
>>
>>> 1216:
>>> 1217: /**
>>> 1218: * Reads a file's attributes as a bulk operation if it exists.
>>
>> Maybe instead "it" put "the file"?
On Wed, 22 Jun 2022 19:22:50 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> -
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A
Hi,
Please review the following patch which will:
- Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
the methods
- public boolean exists(Path path, LinkOption... options)
- public A readAttributesIfExists(Path path,
Class type, LinkOption... options)
This
29 matches
Mail list logo
