Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-08-10 Thread Jaikiran Pai
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote: >> (This is a recreation of a previous pull request which had received some >> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that >> personal branch and recreate it due to some git issues) >> >> Can I please get a

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-08-10 Thread Stuart Marks
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote: >> (This is a recreation of a previous pull request which had received some >> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that >> personal branch and recreate it due to some git issues) >> >> Can I please get a

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-08-10 Thread Lance Andersen
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote: >> (This is a recreation of a previous pull request which had received some >> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that >> personal branch and recreate it due to some git issues) >> >> Can I please get a

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-08-09 Thread Jaikiran Pai
> (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of this change which addresses >

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Lance Andersen
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Naoto Sato
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Chris Hegarty
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
(This is a recreation of a previous pull request which had received some reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that personal branch and recreate it due to some git issues) Can I please get a review of this change which addresses

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v3]

2022-06-22 Thread Stuart Marks
On Fri, 10 Jun 2022 08:26:02 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which addresses >> https://bugs.openjdk.java.net/browse/JDK-8285405? >> >> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the >> existing