On Tue, 5 Jul 2022 04:51:50 GMT, Ryan Ernst wrote:
>> YAO (Yet Another Opinion)! But I think we're actually converging.
>>
>> David's wording:
>>>Invocations of this method are serialized such that only one invocation will
>>>actually proceed with the shutdown sequence and terminate the VM
On Tue, 5 Jul 2022 04:47:40 GMT, Ryan Ernst wrote:
>> First, the signal handlers actually invoke Shutdown.exit, not
>> Shutdown.shutdown - see Terminator.setup(). (If they did the latter, like
>> DestroyJavaVM, then an exit(status) call from another thread could still do
>> the final VM
On Mon, 4 Jul 2022 16:47:28 GMT, Chris Hegarty wrote:
>> I think the wording in the latest commit (9d972b) is problematic. One reason
>> is that you've changed it to "will run shutdown hooks" but it doesn't run
>> the hooks, it starts them, and so conflicts with the previous paragraph. I
>>
On Tue, 5 Jul 2022 07:23:49 GMT, David Holmes wrote:
>> I like the new suggested wording, but I would slightly tweak it. As Alan
>> mentioned in another comment the first paragraph makes clear the method
>> never returns normally. How does the following sound?
>>
>>> If this method is invoked
On Tue, 5 Jul 2022 03:24:28 GMT, Ryan Ernst wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 88:
>>
>>> 86: * Shutdown is serialized such that only one invocation will run
>>> 87: * shutdown hooks and terminate the VM with the given status code.
>>> That
>>> 88:
On Tue, 5 Jul 2022 04:06:03 GMT, David Holmes wrote:
>> Signal handlers for eg SIGTERM invoke Shutdown.shutdown. That method holds
>> the same lock as Shutdown.exit and runs shutdown hooks. So if a signal
>> handler triggers shutdown, and before the system halts Runtime.exit is
>> invoked,
On Tue, 5 Jul 2022 00:16:50 GMT, David Holmes wrote:
>> Ryan Ernst has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> iterate on wording
>
> src/java.base/share/classes/java/lang/Runtime.java line 88:
>
>> 86: * Shutdown is
On Mon, 4 Jul 2022 16:17:27 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Mon, 4 Jul 2022 16:17:27 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Mon, 4 Jul 2022 16:31:22 GMT, Alan Bateman wrote:
>> I reworded with the suggested text in mind. I also added another sentence
>> referencing native signal handlers, which may also initiate shutdown. I
>> think this clarification is important so that it is clear the status code of
>> all
On Mon, 4 Jul 2022 16:13:10 GMT, Ryan Ernst wrote:
>> David's refinement looks good. The sentence on deadlock is accurate as
>> shutdown hooks run on other threads, not the thread calling System.ext.
>
> I reworded with the suggested text in mind. I also added another sentence
> referencing
On Mon, 4 Jul 2022 08:42:02 GMT, Alan Bateman wrote:
>> +1 - except for the "deadlock" part (see other comment). I think the old
>> paragraph is at least confusing, and perhaps even just wrong. Let's say
>> we've run `shutdown` so run all the hooks but not halted. Then someone
>> calls
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to Runtime.exit.
Ryan Ernst has updated the pull request
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Mon, 4 Jul 2022 08:07:25 GMT, Chris Hegarty wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 89:
>>
>>> 87: * of the first invocation will be used; the status codes from
>>> other invocations
>>> 88: * will be ignored. If this method is invoked from a shutdown
On Mon, 4 Jul 2022 01:59:37 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 89:
>>
>>> 87: * of the first invocation will be used; the status codes from
>>> other invocations
>>> 88: * will be ignored. If this method is invoked from a shutdown hook
On Mon, 4 Jul 2022 01:57:11 GMT, Kim Barrett wrote:
> Is "deadlock" accurate?
Yes.
In the context of the specification, "shutdown hook" means _application_
shutdown hook - as far as the specification is concerned, application shutdown
hooks are the only kind of hooks. Right?
For example,
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Sun, 3 Jul 2022 22:19:50 GMT, David Holmes wrote:
>> Ryan Ernst has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better clarify multiple threads behavior
>
> src/java.base/share/classes/java/lang/Runtime.java line 89:
>
>> 87: *
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
On Sat, 2 Jul 2022 13:23:27 GMT, David Holmes wrote:
> Sorry, I did not think this issue was intended to change the specification in
> any way, but I see now that it actually does - whether that was the intent or
> not.
While, maybe, not strictly envisioned by the JIRA issue, the
On Sat, 2 Jul 2022 19:32:04 GMT, Alan Bateman wrote:
>> If a shutdown hook is running, then shutdown has started, right? This new
>> wording isn’t really a change, it’s the current behavior (the “otherwise”
>> portion of the old wording). But the wording is meant to be more accurate
>> for
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to Runtime.exit.
Ryan Ernst has updated the pull request
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote:
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to
On Sat, 2 Jul 2022 14:07:57 GMT, Ryan Ernst wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 88:
>>
>>> 86: * Invocations of this method block indefinitely. It is
>>> therefore
>>> 87: * inadvisable to invoke this method from a shutdown hook as it will
>>> 88:
On Sat, 2 Jul 2022 13:21:06 GMT, David Holmes wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote:
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote:
> This is a followup to simplify Shutdown.exit after the removal of
> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
> on the approach has been reached in this PR, a CSR will be filed to
> propose the spec change to
This is a followup to simplify Shutdown.exit after the removal of
finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
on the approach has been reached in this PR, a CSR will be filed to
propose the spec change to Runtime.exit.
-
Commit messages:
- 8288984:
30 matches
Mail list logo
