On Thu, 21 Jul 2022 13:23:43 GMT, Ryan Ernst wrote:
>> This commit ensures streams returned by ModuleReader::list are closed.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master'
> This commit ensures streams returned by ModuleReader::list are closed.
Ryan Ernst has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Merge branch 'master' into try_files/module_reader_uses
- fix caller sensitive test
On Thu, 21 Jul 2022 06:53:53 GMT, Chris Hegarty wrote:
>> Done in
>> [4a94c64](https://github.com/openjdk/jdk/pull/9557/commits/4a94c645fe1e37abc694f81fd8e401c5dc367d68)
>
> @rjernst it seems that the _revert_ part of the above has been done, but not
> the "have the callerSensitiveMethods
On Wed, 20 Jul 2022 20:54:27 GMT, Ryan Ernst wrote:
>> yes, this would solve it.
>
> Done in
> [4a94c64](https://github.com/openjdk/jdk/pull/9557/commits/4a94c645fe1e37abc694f81fd8e401c5dc367d68)
@rjernst it seems that the _revert_ part of the above has been done, but not
the "have the
> This commit ensures streams returned by ModuleReader::list are closed.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
silly spaces
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9557/files
- new:
On Wed, 20 Jul 2022 20:58:55 GMT, Ryan Ernst wrote:
>> This commit ensures streams returned by ModuleReader::list are closed.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by
On Wed, 20 Jul 2022 20:17:27 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line
>> 411:
>>
>>> 409: try (ModuleReader reader = mref.open();
>>> 410: Stream stream = reader.list()) {
>>> 411: return stream
>>
>>
> This commit ensures streams returned by ModuleReader::list are closed.
Ryan Ernst has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional
On Wed, 20 Jul 2022 08:14:39 GMT, Chris Hegarty wrote:
>> This commit ensures streams returned by ModuleReader::list are closed.
>
> test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line 411:
>
>> 409: try (ModuleReader reader = mref.open();
>> 410:
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote:
> This commit ensures streams returned by ModuleReader::list are closed.
test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line 411:
> 409: try (ModuleReader reader = mref.open();
> 410: Stream stream =
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote:
> This commit ensures streams returned by ModuleReader::list are closed.
Hello Ryan, the failures reported in the GitHub Actions jobs look related to
this change. One such failure is in `CallerSensitiveAccess` test which throws
an exception
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote:
> This commit ensures streams returned by ModuleReader::list are closed.
LGTM
-
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9557
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote:
> This commit ensures streams returned by ModuleReader::list are closed.
Note that ModulePatcher::list delegates to ModuleReader::list, but since the
stream it builds closes the underlying stream, the use doesn't need to be
closed within the
This commit ensures streams returned by ModuleReader::list are closed.
-
Commit messages:
- 8290504: Close streams returned by ModuleReader::list
Changes: https://git.openjdk.org/jdk/pull/9557/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=9557=00
Issue:
14 matches
Mail list logo
