On Mon, 21 Nov 2022 01:11:55 GMT, David Holmes wrote:
> > tools/launcher/ArgsFileTest.java was working because it didn't contain any
> > test with --disable-@files option verifying VM really starts
>
> What about the killswitch test ??
KillSwitch test did not construct valid command line, it
On Fri, 18 Nov 2022 11:44:32 GMT, Adam Sotona wrote:
> tools/launcher/ArgsFileTest.java was working because it didn't contain any
> test with --disable-@files option verifying VM really starts
What about the killswitch test ??
-
PR: https://git.openjdk.org/jdk/pull/11183
On Fri, 18 Nov 2022 11:43:56 GMT, Adam Sotona wrote:
>> Option --disable-@files is passed to VM option causing it to fail.
>> Proposed patch skips --disable-@files option in
>> src/java.base/share/native/libjli/java.c ParseArguments processing, so it is
>> not passed to the VM.
>> The patch
On Thu, 17 Nov 2022 01:26:51 GMT, David Holmes wrote:
>> Option --disable-@files is not recognised as valid JVM option, however it is
>> already implemented in the launcher.
>> Proposed patch skips --disable-@files option in
>> src/hotspot/share/runtime/arguments.cpp processing, so it does not
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into
> the category of unknown options.
> The patch
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall
On Wed, 16 Nov 2022 16:10:45 GMT, Adam Sotona wrote:
> Alternate suggestions are welcome, or link to relevant documentation, or an
> example of another filtered option.
I think I would start in ParseArguments (libjli/java.c) to see the options that
are handled, translated, or passed through.
On Wed, 16 Nov 2022 14:38:18 GMT, Alan Bateman wrote:
> Are you sure this is right place to do this? There are other "launcher
> options" that aren't passed through to CreateJavaVM and I'm surprised this
> one is.
I've found this place as a single spot handling (or skipping) tons of options
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall
Option --disable-@files is not recognised as valid JVM option, however it is
already implemented in the launcher.
Proposed patch skips --disable-@files option in
src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into
the category of unknown options.
The patch also corrects
10 matches
Mail list logo
