Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Roger Riggs
On Fri, 30 Sep 2022 16:52:40 GMT, Brent Christian wrote: >> Due to some [bootstrapping >> issues](https://stackoverflow.com/questions/71834059/why-invokedynamic-based-string-concatenation-is-not-available-for-javac-in-java) >> in `java.base` explicit String concatenation is not translated into

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Brent Christian
On Fri, 30 Sep 2022 16:14:38 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/text/PatternEntry.java line 291: >> >>> 289: // We re-use these objects in order to improve performance >>> 290: private StringBuilder newChars = new StringBuilder(); >>> 291: priv

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Сергей Цыпанов
On Thu, 29 Sep 2022 22:29:43 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweak indentation in PaternEntry > > src/java.base/share/classes/java/text/PatternEntry.java line 291: > >> 289:

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-29 Thread Justin Lu
> Problem: Unnecessary instances of StringBuffer within java.text (internal > only) > > Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method > names Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Tweak indentat