On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
Is it going to be covered with new reflection sometimes?
-
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
Thanks. This is for serialization and not the use of the core
On Tue, 4 Oct 2022 11:55:02 GMT, Claes Redestad wrote:
>> @mlchung I can put here a stack trace of the application invoking the code
>> if you are interested
>
> @stsypanov would be helpful to understand when this code still gets executed.
> Also note that JEP 416 was integrated in JDK 18 so so
On Tue, 4 Oct 2022 11:41:31 GMT, Сергей Цыпанов wrote:
>>> I agree that getting rid of the clone can help -- but since [JEP
>>> 416](https://openjdk.org/jeps/416) the generators modified here is mostly a
>>> fallback and the bulk of the use will use `MethodHandles` (unless you
>>> disable JEP
On Mon, 3 Oct 2022 16:44:56 GMT, Mandy Chung wrote:
>> I agree that getting rid of the clone can help -- but since [JEP
>> 416](https://openjdk.org/jeps/416) the generators modified here is mostly a
>> fallback and the bulk of the use will use `MethodHandles` (unless you
>> disable JEP 416 and
On Mon, 3 Oct 2022 11:03:48 GMT, Claes Redestad wrote:
> I agree that getting rid of the clone can help -- but since [JEP
> 416](https://openjdk.org/jeps/416) the generators modified here is mostly a
> fallback and the bulk of the use will use `MethodHandles` (unless you disable
> JEP 416 and
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
Marked as reviewed by redestad (Reviewer).
Approving since cha
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
I agree that getting rid of the clone can help -- but since [JE
On Sun, 2 Oct 2022 22:16:46 GMT, Claes Redestad wrote:
>> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
>> unused and should be removed in order to prevent allocations from
>> `Method.getExceptionTypes()`
>
> Seems reasonable, although these generators should only r
On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote:
> `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
> unused and should be removed in order to prevent allocations from
> `Method.getExceptionTypes()`
Seems reasonable, although these generators should only rarely
`checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is
unused and should be removed in order to prevent allocations from
`Method.getExceptionTypes()`
-
Commit messages:
- 8294698: Remove unused 'checkedExceptions' param from
MethodAccessorGenerator.generateMeth
11 matches
Mail list logo
