Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2024-01-08 Thread Adam Sotona
On Fri, 5 Jan 2024 23:55:53 GMT, Mandy Chung wrote: > > Profiling of the benchmarks revealed several slowdowns: > > ``` > > * many expensive conversions from `Class` to `ClassDesc` to > > `ClassEntry`, or even more expensive `MethodTypeDesc` > > > > * building proxy class from scratch from

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2024-01-05 Thread Mandy Chung
On Thu, 21 Dec 2023 01:33:29 GMT, Adam Sotona wrote: > Profiling of the benchmarks revealed several slowdowns: > > * many expensive conversions from `Class` to `ClassDesc` to > `ClassEntry`, or even more expensive `MethodTypeDesc` > > * building proxy class from scratch from symbols

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-12-21 Thread Adam Sotona
On Thu, 21 Dec 2023 12:01:25 GMT, Sergey Tsypanov wrote: >> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - performance improvements >> - SplitConstantPool performance fix > >

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-12-21 Thread Sergey Tsypanov
On Thu, 21 Dec 2023 01:12:07 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-12-20 Thread Adam Sotona
On Thu, 21 Dec 2023 01:12:07 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-12-20 Thread Adam Sotona
On Thu, 21 Dec 2023 01:12:07 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-12-20 Thread Adam Sotona
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes. > > This patch converts it to use Classfile API. > > It is continuation of https://github.com/openjdk/jdk/pull/10991 > > Any comments and suggestions are welcome. > > Please review. > > Thank you, > Adam Adam

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v3]

2023-03-16 Thread Adam Sotona
On Thu, 9 Mar 2023 14:41:47 GMT, Chen Liang wrote: >> Isn't the "unrelated process such as generating lambda forms" critical for >> the `ProxyGenerator` functionality? > > More accurately, I mean the overhead generated by this: >