Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v5]

2023-03-16 Thread Leonid Mesnik
> The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: t

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v4]

2023-03-16 Thread David Holmes
On Fri, 17 Mar 2023 00:02:12 GMT, Leonid Mesnik wrote: >> The StreamPumper is fixed to process the last line even it is not finishes >> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify >> that tests are not broken. > > Leonid Mesnik has updated the pull request incremen

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v3]

2023-03-16 Thread Leonid Mesnik
On Thu, 16 Mar 2023 06:19:14 GMT, Thomas Stuefe wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comments added > > That also affects OutputAnalyzer, right? Does this affect parsing or is this > only printing? >

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v4]

2023-03-16 Thread Leonid Mesnik
> The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: f

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v3]

2023-03-15 Thread Thomas Stuefe
On Wed, 15 Mar 2023 22:49:57 GMT, Leonid Mesnik wrote: >> The StreamPumper is fixed to process the last line even it is not finishes >> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify >> that tests are not broken. > > Leonid Mesnik has updated the pull request incremen

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v2]

2023-03-15 Thread David Holmes
On Wed, 15 Mar 2023 14:23:43 GMT, Leonid Mesnik wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed test > > test/lib/jdk/test/lib/process/StreamPumper.java line 145: > >> 143: } >> 144:

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v3]

2023-03-15 Thread David Holmes
On Wed, 15 Mar 2023 22:49:57 GMT, Leonid Mesnik wrote: >> The StreamPumper is fixed to process the last line even it is not finishes >> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify >> that tests are not broken. > > Leonid Mesnik has updated the pull request incremen

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v3]

2023-03-15 Thread Leonid Mesnik
> The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: c

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v2]

2023-03-15 Thread Leonid Mesnik
On Wed, 15 Mar 2023 14:23:06 GMT, Leonid Mesnik wrote: >> The StreamPumper is fixed to process the last line even it is not finishes >> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify >> that tests are not broken. > > Leonid Mesnik has updated the pull request incremen

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v2]

2023-03-15 Thread Leonid Mesnik
> The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: f

Re: RFR: 8303697: ProcessTools doesn't print last line of process output

2023-03-15 Thread David Holmes
On Wed, 15 Mar 2023 05:41:33 GMT, Leonid Mesnik wrote: > The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. Not clear on this one sorry. I would have thought the: i

RFR: 8303697: ProcessTools doesn't print last line of process output

2023-03-14 Thread Leonid Mesnik
The StreamPumper is fixed to process the last line even it is not finishes with '\n' or '\r'. The test included. Testing with tier1-3 also to verify that tests are not broken. - Commit messages: - fix - 8303697 Changes: https://git.openjdk.org/jdk/pull/13034/files Webrev: https:

Re: RFR: 8303697: ProcessTools doesn't print last line of process output

2023-03-14 Thread Leonid Mesnik
On Wed, 15 Mar 2023 05:41:33 GMT, Leonid Mesnik wrote: > The StreamPumper is fixed to process the last line even it is not finishes > with '\n' or '\r'. The test included. Testing with tier1-3 also to verify > that tests are not broken. The ByteArrayOutputStream is moved into try block just to