On Mon, 17 Apr 2023 17:04:32 GMT, Alan Bateman wrote:
> What you have is fine, I'm just making the point that the exception message
> is somewhat secondary
I guess this is also a question of testing the interface vs. testing the
implementation.
To get good coverage of validation scenarios, I
On Sun, 16 Apr 2023 10:27:07 GMT, Lance Andersen wrote:
>> Okay, although I assume this test will fail if it throws a more general
>> IOException (it's allowed to do that) or there is any adjustment to the
>> error message.
>
> Yes, in the unlikely event that either FileSystemException or the
On Sun, 16 Apr 2023 08:39:32 GMT, Alan Bateman wrote:
>> added validation for other file being null but also kept the existing
>> validation of the message
>
> Okay, although I assume this test will fail if it throws a more general
> IOException (it's allowed to do that) or there is any adjustm
On Sat, 15 Apr 2023 10:24:58 GMT, Lance Andersen wrote:
>> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 96:
>>
>>> 94: var file = zipfs.getPath(DIRECTORY_NAME);
>>> 95: var x = assertThrows(FileSystemException.class, () ->
>>> Files.newInputStream(
On Sat, 15 Apr 2023 05:43:09 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> re-arrage assertEquals params
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 96:
>
>> 94:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Sat, 15 Apr 2023 00:36:35 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 21:59:33 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
On Fri, 14 Apr 2023 21:30:40 GMT, Eirik Bjorsnos wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address additional feedback
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMessageTest.java line 40:
>
>> 38:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 21:40:17 GMT, Lance Andersen wrote:
>> Please review this trivial change when ZipFS returns the wrong
>> java.nio.file.FileSystemException message due the the parameters being
>> reversed.
>>
>> I also included a simple junit test as part of the fix.
>>
>> Mach5 tiers1-3 a
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 21:07:37 GMT, Naoto Sato wrote:
> Looks good, Lance. Nit: copyright year -> 2023
Geez, working in too many workspaces. Thank you, just pushed the update
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509300245
On Fri, 14 Apr 2023 21:08:28 GMT, Christian Stein wrote:
> Looks good to me.
Thank you Christian
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509301103
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance Andersen has updated the pull r
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clea
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clea
Please review this trivial change when ZipFS returns the wrong
java.nio.file.FileSystemException message due the the parameters being reversed.
I also included a simple junit test as part of the fix.
Mach5 tiers1-3 are clean
Best
Lance
-
Commit messages:
- (zipfs) Opening a direc
19 matches
Mail list logo