Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
From: kulla-dev on behalf of Brian Goetz > I think there's something fishy going on. Yes, transformation lambdas become significantly slower when moved from ClassModel to Classfile (unless I missed anything else). I’ll do some experiments to get the performance back.

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Brian Goetz
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Brian Goetz
Observation: It's dramatic how injecting a tiny amount of shared mutable state ripples throughout the design. After thinking about this some more, I think the main problem is that we are still trying to have the cache be transparent, which means that Classfile is taking on all the complexity

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-08 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >