Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

2023-06-09 Thread Adam Sotona
To: Adam Sotona , core-libs-dev@openjdk.org , kulla-...@openjdk.org Subject: Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9] I still don't understand this point. Why are separate tests sharing a context at all? On 6/8/2023 9:26 AM, Adam Sotona wrote: Unfortunately

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

2023-06-08 Thread Brian Goetz
I still don't understand this point.  Why are separate tests sharing a context at all? On 6/8/2023 9:26 AM, Adam Sotona wrote: Unfortunately thread-unsafe context makes sharing of it in tests executed in parallel a nightmare. I can fix our Corpus tests and hope the race condition won't raise

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

2023-06-08 Thread Adam Sotona
On Thu, 8 Jun 2023 11:26:39 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

2023-06-08 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >