Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries [v3]

2023-09-20 Thread Adam Sotona
On Wed, 20 Sep 2023 07:35:40 GMT, Chen Liang wrote: >> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, >> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a >> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or >> MethodType

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries [v3]

2023-09-20 Thread Chen Liang
> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, > FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a > typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or > MethodTypeDesc). > > This API is not added to NameAndTypeEntry itse

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries [v2]

2023-09-20 Thread Chen Liang
On Fri, 30 Jun 2023 02:42:08 GMT, Chen Liang wrote: >> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, >> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a >> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or >> MethodType

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries [v2]

2023-06-29 Thread Chen Liang
> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, > FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a > typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or > MethodTypeDesc). > > This API is not added to NameAndTypeEntry itse

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries

2023-06-29 Thread Chen Liang
On Thu, 29 Jun 2023 13:26:00 GMT, Brian Goetz wrote: >> src/java.base/share/classes/jdk/internal/classfile/constantpool/InvokeDynamicEntry.java >> line 46: >> >>> 44: default MethodTypeDesc typeSymbol() { >>> 45: return Util.methodTypeSymbol(nameAndType()); >>> 46: } >> >> Simi

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries

2023-06-29 Thread Brian Goetz
On Thu, 29 Jun 2023 09:59:30 GMT, Chen Liang wrote: > 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, > FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a > typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or > MethodTypeDesc

Re: RFR: 8311084: Add typeSymbol() API for applicable constant pool entries

2023-06-29 Thread Brian Goetz
On Thu, 29 Jun 2023 13:23:51 GMT, Brian Goetz wrote: >> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, >> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a >> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or >> MethodTyp

RFR: 8311084: Add typeSymbol() API for applicable constant pool entries

2023-06-29 Thread Chen Liang
5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or MethodTypeDesc). This API is not added to NameAndTypeEntry itself, for a Na