On Sat, 8 Jul 2023 07:14:12 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/util/HexDigits.java line 44:
>>
>>> 42: * 0 -> '00' -> ('0' << 8) | '0' -> 0x3030
>>> 43: * 1 -> '01' -> ('0' << 8) | '1' -> 0x3130
>>> 44: * 2 -> '02' -> ('0' << 8) | '2' -> 0x3230
On Fri, 7 Jul 2023 23:42:51 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/util/UUID.java line 475:
>>
>>> 473: long msb = mostSigBits;
>>> 474: byte[] buf = new byte[36];
>>> 475: UNSAFE.putLongUnaligned(
>>
>> I understood that since UUID was not used during
On Fri, 7 Jul 2023 15:13:02 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> code style
>
> src/java.base/share/classes/java/util/HexDigits.java line 44:
>
>> 42: * 0 -> '00' -> ('0' << 8) | '0'
On Fri, 7 Jul 2023 15:09:07 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> code style
>
> src/java.base/share/classes/java/util/UUID.java line 475:
>
>> 473: long msb = mostSigBits;
>> 474:
On Fri, 7 Jul 2023 15:02:54 GMT, Roger Riggs wrote:
> Is there a significant performance difference?
Yes, see https://github.com/openjdk/jdk/pull/14745#issuecomment-1615435719 for
the revision at
https://github.com/openjdk/jdk/pull/14745/commits/425559f65a3e5f72323abdadbbf9df426e196d9b
On my
On Sat, 1 Jul 2023 14:42:07 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Sat, 1 Jul 2023 23:32:57 GMT, Chen Liang wrote:
> /integrate
A "reviewer" means a role in the jdk project in the OpenJDK organization:
https://openjdk.org/census#jdk
-
PR Comment: https://git.openjdk.org/jdk/pull/14745#issuecomment-1624502704
On Sat, 1 Jul 2023 14:42:07 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make