On Wed, 3 Jan 2024 13:55:24 GMT, Thomas Wuerthinger wrote:
> Are these new compiler intrinsics required or an optional performance
> optimization?
Performance. If the intrinsic isn't there then some methods executed on virtual
threads, or on a virtual thread as the target for some op, will
On Wed, 20 Dec 2023 10:40:23 GMT, Serguei Spitsyn wrote:
>>> You can't do this! The Java code knows nothing about JVM TI being
>>> enabled/disabled and will call this function unconditionally.
>>
>> Indeed. I wonder if anyone is testing minimal builds to catch issues like
>> this.
>
> Good
On Wed, 20 Dec 2023 14:15:48 GMT, Alan Bateman wrote:
> Update: ignore this I mis-read that it updates the current thread's suspend
> value, not the thread's suspend value.
Thanks, Alan. I've also got confused with this and even filed a follow up bug.
:)
Yes, the initial design was the
On Mon, 18 Dec 2023 17:09:59 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`,
On Wed, 20 Dec 2023 08:02:14 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvm.cpp line 4024:
>>
>>> 4022: #else
>>> 4023: fatal("Should only be called with JVMTI enabled");
>>> 4024: #endif
>>
>> You can't do this! The Java code knows nothing about JVM TI being
>> enabled/disabled
On Wed, 20 Dec 2023 04:44:35 GMT, David Holmes wrote:
> You can't do this! The Java code knows nothing about JVM TI being
> enabled/disabled and will call this function unconditionally.
Indeed. I wonder if anyone is testing minimal builds to catch issues like this.
-
PR Review
On Mon, 18 Dec 2023 17:09:59 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`,
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`,
