Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Mon, 31 Jul 2023 09:51:44 GMT, sid8606 wrote: >> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 45: >> >>> 43: if (reg == Z_SP) continue; >>> 44: // though Z_R6 is argument register it is a saved register >>> 45: if (!abi.is_volatile_reg(reg) || reg == Z_R6) { >> >> So, is the

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Mon, 31 Jul 2023 08:08:37 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Preserve and restore register Z_R6 >> >> Though Z_R6 is argument register it is a saved register >> so preserve and

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread Jorn Vernee
On Fri, 28 Jul 2023 03:59:26 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Preserve and restore register Z_R6 > > Though

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Fri, 28 Jul 2023 12:36:13 GMT, Andrew Haley wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Preserve and restore register Z_R6 >> >> Though Z_R6 is argument register it is a saved register >> so preserve and

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-28 Thread Andrew Haley
On Fri, 28 Jul 2023 03:59:26 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Preserve and restore register Z_R6 > > Though

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-27 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Preserve and restore register Z_R6 Though Z_R6 is argument register it is a saved register so preserve and