On Tue, 19 Sep 2023 18:30:10 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update
On Tue, 19 Sep 2023 18:30:10 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update
> Modified all tests under lib-test/jdk to use JUnit
Qing Xiao has updated the pull request incrementally with three additional
commits since the last revision:
- Update test/lib-test/jdk/test/lib/hexdump/ObjectStreamPrinterTest.java
Co-authored-by: liach
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
On Tue, 15 Aug 2023 08:07:09 GMT, Christian Stein wrote:
>> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
>>> rights reserved.
>>
>> Should it just modify the second year, here is `2021`,
> Modified all tests under lib-test/jdk to use JUnit
Qing Xiao has updated the pull request incrementally with one additional commit
since the last revision:
Change test static method to instance method
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15131/files
- new:
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
Should all static `@Test` methods be converted to instance methods, as
recommended by JUnit? See
https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-definitions
> Test Method
> Modified all tests under lib-test/jdk to use JUnit
Qing Xiao has updated the pull request incrementally with three additional
commits since the last revision:
- Delete extra space
Co-authored-by: Andrey Turbanov
- Update years in comments in test/lib-test/jdk/test/lib/hexdump
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 84:
> 82: Arguments.of("canonical", "%08x ", "%02x ", 16, "|", 31,
> HexPrinter.Formatters.PRINTABLE, "|" +
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
Please only keep first and last/latest year of changes.
test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2019, 2020, 2023, Oracle and/or its
On Tue, 15 Aug 2023 08:03:59 GMT, John Jiang wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
>> rights reserved.
>
> Should it
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
> rights reserved.
Should it just modify the
Modified all tests under lib-test/jdk to use JUnit
-
Commit messages:
- Corrected the testSecondArrayIsNull() in ArrayDiffTest and modified format.
- Modified all tests under lib-test/jdk to use JUnit
Changes: https://git.openjdk.org/jdk/pull/15131/files
Webrev:
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
Marked as reviewed by cstein (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/15131#pullrequestreview-1578082673
15 matches
Mail list logo
