On Tue, 2 Jan 2024 22:06:36 GMT, Eirik Bjørsnøs wrote:
> A CSR for this change has been proposed and is ready for review:
> [JDK-8322871](https://bugs.openjdk.org/browse/JDK-8322871)
I've reviewed the CSR so you can finalize. The implementation change looks fine.
-
PR Comment:
On Tue, 2 Jan 2024 12:21:21 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
On Tue, 2 Jan 2024 12:21:21 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
> Please consider this PR which makes `DeflaterOutputStream.close()` always
> close its wrapped output stream.
>
> Currently, closing of the wrapped output stream happens outside the finally
> block where `finish()` is called. If `finish()` throws, this means the
> wrapped stream will not be
