On Tue, 16 Jan 2024 18:18:38 GMT, Lance Andersen wrote:
> This comment could use a bit of wordsmithing to indicate what "correct" means
It's hard to write good prose for these tricky error scenarios. But just saying
"correct" without defining it is a bit too lazy, yes :-)
Please take a look
On Mon, 15 Jan 2024 10:26:53 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
On Mon, 15 Jan 2024 10:26:53 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
> Please consider this PR which makes `DeflaterOutputStream.close()` always
> close its wrapped output stream exactly once.
>
> Currently, closing of the wrapped output stream happens outside the finally
> block where `finish()` is called. If `finish()` throws, this means the
> wrapped stream