On Mon, 7 Aug 2023 17:35:34 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/java/lang/Math.java line 3425:
>>
>>> 3423: // Constants used in scalb
>>> 3424: private static final double twoToTheDoubleScaleUp =
>>> powerOfTwoD(512);
>>> 3425: private static final double
On Mon, 7 Aug 2023 16:43:49 GMT, Raffaello Giulietti
wrote:
>> Couple of static fields in Math could be declared `final`.
>
> src/java.base/share/classes/java/lang/Math.java line 3425:
>
>> 3423: // Constants used in scalb
>> 3424: private static final double twoToTheDoubleScaleUp =
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
src/java.base/share/classes/java/lang/Math.java line 3425:
> 3423: // Constants used in scalb
> 3424: private static final double twoToTheDoubleScaleUp =
>
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
+1
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565684801
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565476822
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
Looks good and trivial.
-
Marked as reviewed by redestad (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565168404
Couple of static fields in Math could be declared `final`.
-
Commit messages:
- [PATCH] Make fields final in java.util.Math: twoToTheDoubleScaleUp,
twoToTheDoubleScaleDown
Changes: https://git.openjdk.org/jdk/pull/14875/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14875=00
