Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v3]

2023-09-14 Thread Adam Sotona
On Thu, 14 Sep 2023 16:17:35 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v3]

2023-09-14 Thread Brian Goetz
On Fri, 8 Sep 2023 10:27:28 GMT, Adam Sotona wrote: >> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` >> methods are confusing and unsafe to use without knowledge of constant pool >> specification. >> This patch renames `ConstantPool::entryCount` to

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v3]

2023-09-08 Thread Adam Sotona
> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` > methods are confusing and unsafe to use without knowledge of constant pool > specification. > This patch renames `ConstantPool::entryCount` to `ConstantPool::size` and > adds checks to `ConstantPool::entryByIndex` for