On Sun, 21 Jan 2024 13:48:49 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 21 Dec 2023 08:37:23 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sat, 21 Oct 2023 01:22:04 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Sat, 21 Oct 2023 01:22:04 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>>
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Fri, 20 Oct 2023 11:04:28 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/util/FormatProcessor.java line 247:
>>
>>> 245: throw new MissingFormatArgumentException(group + " is
>>> not immediately followed by an embedded expression");
>>> 246: } else {
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Fri, 20 Oct 2023 08:52:04 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix FormatterBuilder testcase handle lineSeparator on windows
>
>
On Thu, 19 Oct 2023 06:38:35 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>>
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Mon, 18 Sep 2023 00:48:26 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 3420:
>>
>>> 3418: && fmt.a instanceof StringBuilder sb
>>> 3419: ) {
>>> 3420: sb.append(value);
>>
>> There's a lot of `if`s here,
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Mon, 18 Sep 2023 02:59:06 GMT, Shaojin Wen wrote:
>> The change code of print fast-path has been deleted, and parse fast-path has
>> added support for the pattern "%8.3f".
>>
>> Where to draw the line of parse fast-path? I have seen patterns that cause
>> performance problems, and they can
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 27 Sep 2023 19:51:25 GMT, Raffaello Giulietti
wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>>
On Mon, 25 Sep 2023 12:20:36 GMT, Shaojin Wen wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify
On Mon, 25 Sep 2023 12:20:36 GMT, Shaojin Wen wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify
On Mon, 25 Sep 2023 11:36:10 GMT, Shaojin Wen wrote:
> The reason why I split it into multiple small methods is to avoid a single
> method codeSize > 325. After merging small methods, the performance will
> decrease.
Yes, I can refactor to keep the same structure and verify performance is
On Mon, 25 Sep 2023 12:28:06 GMT, Claes Redestad wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Mon, 25 Sep 2023 11:46:36 GMT, Claes Redestad wrote:
> > The reason why I split it into multiple small methods is to avoid a single
> > method codeSize > 325. After merging small methods, the performance will
> > decrease.
>
> Yes, I can refactor to keep the same structure and verify
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
@cl4es made performance optimizations for the simple specifiers of
String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the same
idea, I continued to make improvements. I made patterns like %2d %02d also be
optimized.
The following are the test results based on MacBookPro M1
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor according to rgiulietti's suggestion and add testcases
>
> Meaningful external reviews take a _lot_ of
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Mon, 9 Oct 2023 20:40:43 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 5 Oct 2023 20:02:44 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 28 Sep 2023 21:40:17 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Thu, 28 Sep 2023 21:40:17 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Refactor according to rgiulietti's suggestion and add testcases
>
> Meaningful external reviews take a _lot_ of
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 28 Sep 2023 21:12:37 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Wed, 27 Sep 2023 21:26:46 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Wed, 27 Sep 2023 19:51:25 GMT, Raffaello Giulietti
wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix : the exception thrown when the input does not include conversion is
>> different from baselne.
>
> You might
On Wed, 27 Sep 2023 19:13:02 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Wed, 27 Sep 2023 21:26:46 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Wed, 27 Sep 2023 19:13:02 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Wed, 27 Sep 2023 09:35:47 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify performance is
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify performance is
On Wed, 27 Sep 2023 09:35:47 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Mon, 25 Sep 2023 14:28:56 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Mon, 25 Sep 2023 12:28:06 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix logic error
>
> src/java.base/share/classes/java/util/Formatter.java line 2949:
>
>> 2947: }
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 12:06:52 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 11:46:36 GMT, Claes Redestad wrote:
> > The reason why I split it into multiple small methods is to avoid a single
> > method codeSize > 325. After merging small methods, the performance will
> > decrease.
>
> Yes, I can refactor to keep the same structure and verify
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Mon, 25 Sep 2023 11:36:10 GMT, 温绍锦 wrote:
> The reason why I split it into multiple small methods is to avoid a single
> method codeSize > 325. After merging small methods, the performance will
> decrease.
Yes, I can refactor to keep the same structure and verify performance is
neutral or
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 24 Sep 2023 13:08:58 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Sun, 24 Sep 2023 11:59:51 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 24 Sep 2023 11:59:51 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
On Mon, 18 Sep 2023 00:48:26 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 3420:
>>
>>> 3418: && fmt.a instanceof StringBuilder sb
>>> 3419: ) {
>>> 3420: sb.append(value);
>>
>> There's a lot of `if`s here, and
On Sun, 17 Sep 2023 22:16:08 GMT, Claes Redestad wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Mon, 18 Sep 2023 02:59:06 GMT, 温绍锦 wrote:
>> The change code of print fast-path has been deleted, and parse fast-path has
>> added support for the pattern "%8.3f".
>>
>> Where to draw the line of parse fast-path? I have seen patterns that cause
>> performance problems, and they can be
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
@cl4es made performance optimizations for the simple specifiers of
String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the same
idea, I continued to make improvements. I made patterns like %2d %02d also be
optimized.
The following are the test results based on MacBookPro M1
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
83 matches
Mail list logo
