Re: RFR: 8319761: Simplify fields of Array VarHandles

2023-11-09 Thread Magnus Ihse Bursie
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote: > 1. Primitive array VHs are now singletons and no longer need to record their > array base and offset in their object themselves. > 2. Moved Unsafe offset calculation to a utility method, like `index` in > VarHandleByteArrayView. Build

Re: RFR: 8319761: Simplify fields of Array VarHandles

2023-11-09 Thread Chen Liang
On Thu, 9 Nov 2023 07:48:04 GMT, Per Minborg wrote: > Sharing code might sometimes have performance issues because the shared code > is used differently from different call sites. See > https://bugs.openjdk.org/browse/JDK-8015417. Is this something we should > check here? This patch mainly

Re: RFR: 8319761: Simplify fields of Array VarHandles

2023-11-08 Thread Per Minborg
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote: > 1. Primitive array VHs are now singletons and no longer need to record their > array base and offset in their object themselves. > 2. Moved Unsafe offset calculation to a utility method, like `index` in > VarHandleByteArrayView. Sharing

Re: RFR: 8319761: Simplify fields of Array VarHandles

2023-11-08 Thread Magnus Ihse Bursie
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote: > 1. Primitive array VHs are now singletons and no longer need to record their > array base and offset in their object themselves. > 2. Moved Unsafe offset calculation to a utility method, like `index` in > VarHandleByteArrayView. @liach You

Re: RFR: 8319761: Simplify fields of Array VarHandles

2023-11-08 Thread ExE Boss
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote: > 1. Primitive array VHs are now singletons and no longer need to record their > array base and offset in their object themselves. > 2. Moved Unsafe offset calculation to a utility method, like `index` in > VarHandleByteArrayView. Note that

RFR: 8319761: Simplify fields of Array VarHandles

2023-11-08 Thread Chen Liang
1. Primitive array VHs are now singletons and no longer need to record their array base and offset in their object themselves. 2. Moved Unsafe offset calculation to a utility method, like `index` in VarHandleByteArrayView. - Commit messages: - Use the base offset and index scale