Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-21 Thread Eric Liu
On Tue, 21 Nov 2023 13:29:32 GMT, Eric Liu wrote: >> Got it. I will fix it soon. Thanks! > > compiler/vectorapi and jdk/incubator/vector passed. Full test is running. I > would report the result when it has been finished. Full jtreg passed without new failure. - PR Review

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-21 Thread Eric Liu
On Mon, 20 Nov 2023 09:26:43 GMT, Eric Liu wrote: >> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1415: >> >>> 1413: break; >>> 1414: case S: >>> 1415: (this->*unpklo)(dst, H, src); >> >> AS above: try making` is_unsigned` a parameter. > > Got it. I will fix it

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-20 Thread Eric Liu
On Thu, 16 Nov 2023 08:59:09 GMT, Andrew Haley wrote: >> Eric Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update m4 >> >> Change-Id: I82bf5f9384f79e09965a0498ad2de45cec6f0a29 > >

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-16 Thread Andrew Haley
On Thu, 16 Nov 2023 08:44:26 GMT, Eric Liu wrote: >> Vector API defines zero-extend operations [1], which are going to be >> intrinsified and generated to `VectorUCastNode` by C2. This patch adds >> backend implementation for `VectorUCastNode` on AArch64. >> >> The micro benchmark shows

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-16 Thread Eric Liu
On Wed, 15 Nov 2023 15:24:11 GMT, Andrew Haley wrote: >> Eric Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update m4 >> >> Change-Id: I82bf5f9384f79e09965a0498ad2de45cec6f0a29 > > src/hotspot/cpu/aarch64/aarch64_vector_ad.m4

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-16 Thread Eric Liu
> Vector API defines zero-extend operations [1], which are going to be > intrinsified and generated to `VectorUCastNode` by C2. This patch adds > backend implementation for `VectorUCastNode` on AArch64. > > The micro benchmark shows significant performance improvement. In my test > machine