On Fri, 2 Feb 2024 20:43:54 GMT, Lance Andersen wrote:
> I think the proposed change above makes things clearer. Perhaps also make the
> same change in zipfs as well while you are at it?
I have pushed the rename to "ZipEntry.externalFileAttributes". Also renamed
`ZipFileSystem.Entry.posixPerms
On Fri, 2 Feb 2024 20:19:51 GMT, Eirik Bjørsnøs wrote:
> > I think the change is OK, any reason to not make it
> > `externalFileAttributes`?
>
> None other than length / verbosity. But since this refers to the _attributes
> of the external file_, dropping any name element also loses some seman
On Fri, 2 Feb 2024 19:55:51 GMT, Lance Andersen wrote:
> I think the change is OK, any reason to not make it `externalFileAttributes`?
None other than length / verbosity. But since this refers to the _attributes
of the external file_, dropping any name element also loses some semantics,
intro
On Tue, 30 Jan 2024 16:17:13 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>> the
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name `ZipEntry.posixPerms`.
> [JDK-8250968](https://bugs.openj
