On Fri, 15 Dec 2023 11:15:30 GMT, Lance Andersen wrote:
>> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
>> think it makes sense to include it in this PR, convert it to JUnit and move
>> it into `ReadZip.readAfterClose`.
>>
>> This removes the last remaining
On Fri, 15 Dec 2023 11:15:30 GMT, Lance Andersen wrote:
>> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
>> think it makes sense to include it in this PR, convert it to JUnit and move
>> it into `ReadZip.readAfterClose`.
>>
>> This removes the last remaining
On Mon, 18 Dec 2023 19:38:55 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merge the ReadAfterClose test into ReadZip, converting it to JUnit.
>
>
On Thu, 14 Dec 2023 14:55:08 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip`,
>> `ZipFile/input.jar` and `ZipFile/crash.jar`
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases
On Thu, 14 Dec 2023 15:00:15 GMT, Eirik Bjorsnos wrote:
> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
> think it makes sense to include it in this PR, convert it to JUnit and move
> it into `ReadZip.readAfterClose`.
>
> This removes the last remaining binary
